[Bug 1364607] Review Request: python-XStatic-objectpath - ObjectPath JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364607

Matthias Runge  changed:

   What|Removed |Added

 Status|POST|CLOSED
 CC||mru...@redhat.com
 Resolution|--- |WONTFIX
Last Closed||2020-01-02 04:33:43



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1364607] Review Request: python-XStatic-objectpath - ObjectPath JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364607

Matthias Runge  changed:

   What|Removed |Added

  Flags||needinfo?(d...@redhat.com)



--- Comment #8 from Matthias Runge  ---
What's the status here? Since this was a fedora package review, it is possible
to get it added to Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1364607] Review Request: python-XStatic-objectpath - ObjectPath JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364607

Haïkel Guémar  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #7 from Haïkel Guémar  ---
I already sponsored David, so removing FE-NEEDSPONSOR


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1364607] Review Request: python-XStatic-objectpath - ObjectPath JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364607

Haïkel Guémar  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags||fedora-review+



--- Comment #6 from Haïkel Guémar  ---
Approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 15 files have
 unknown license. Detailed output of licensecheck in
 /home/haikel/1364607-python-XStatic-objectpath/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
 -XStatic-objectpath , xstatic-objectpath-common , python3-XStatic-
 objectpath
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported 

[Bug 1364607] Review Request: python-XStatic-objectpath - ObjectPath JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364607

Haïkel Guémar  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|karlthe...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1364607] Review Request: python-XStatic-objectpath - ObjectPath JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364607



--- Comment #5 from David Moreau Simard  ---
Spec URL:
https://raw.githubusercontent.com/dmsimard/python-XStatic-objectpath-distgit/master/python-XStatic-objectpath.spec
SRPM URL:
https://github.com/dmsimard/python-XStatic-objectpath-distgit/raw/master/python-XStatic-objectpath-1.2.1.0-1.fc24.src.rpm
Description: ObjectPath JavaScript library packaged for setuptools
(easy_install) / pip.

Parse js object paths using both dot and bracket notation.
Stringify an array of properties into a valid path.
Fedora Account System Username: dmsimard

Koji scratch build available at
http://koji.fedoraproject.org/koji/taskinfo?taskID=15158916

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364607] Review Request: python-XStatic-objectpath - ObjectPath JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364607



--- Comment #4 from David Moreau Simard  ---
@Matthias, oh, wow.. indeed ! I cleaned the mockroot for the build and now it
works. That's a relief and definitely good to know.

Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364607] Review Request: python-XStatic-objectpath - ObjectPath JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364607



--- Comment #3 from Matthias Runge  ---
David, it's a known issue, that you can not build xstatic packages, if you have
another xstatic package installed on your host.

https://bitbucket.org/thomaswaldmann/xstatic/issues/2/cannot-build-a-new-xstatic-package-with

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364607] Review Request: python-XStatic-objectpath - ObjectPath JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364607

Haïkel Guémar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364607] Review Request: python-XStatic-objectpath - ObjectPath JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364607

Haïkel Guémar  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)



--- Comment #2 from Haïkel Guémar  ---
I'll be sponsoring David, reviews are welcome.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364607] Review Request: python-XStatic-objectpath - ObjectPath JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364607



--- Comment #1 from David Moreau Simard  ---
The scratch build works in koji for both rawhide and f24 but pulling this
bugzilla down with fedora-review isn't working and gives the error:

===
+ /usr/bin/python2 setup.py build
Traceback (most recent call last):
  File "setup.py", line 1, in 
from xstatic.pkg import objectpath as xs
ImportError: cannot import name objectpath
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.UVeJZ8 (%build)
Bad exit status from /var/tmp/rpm-tmp.UVeJZ8 (%build)
Child return code was: 1
===

Can't figure it out for the time being, will give a fresh look later.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364607] Review Request: python-XStatic-objectpath - ObjectPath JavaScript library packaged for setuptools (easy_install) / pip.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364607

David Moreau Simard  changed:

   What|Removed |Added

 Blocks||1329341 (RDO-NEWTON)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1329341
[Bug 1329341] Tracker: Blockers and Review requests for new RDO Newton
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org