[Bug 1365794] Review Request: python-keyrings-alt - Alternate keyring implementations for python-keyring

2018-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1365794

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX
  Flags|needinfo?(ignatenko@redhat. |
   |com)|
Last Closed||2018-02-23 06:52:08



--- Comment #5 from Igor Gnatenko  ---
Sorry, don't have time for this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1365794] Review Request: python-keyrings-alt - Alternate keyring implementations for python-keyring

2017-10-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1365794

Petr Viktorin  changed:

   What|Removed |Added

 CC||pvikt...@redhat.com
  Flags||needinfo?(ignatenko@redhat.
   ||com)



--- Comment #4 from Petr Viktorin  ---
What's the status here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1365794] Review Request: python-keyrings-alt - Alternate keyring implementations for python-keyring

2016-12-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1365794



--- Comment #3 from Charalampos Stratakis  ---
Pull request has been merged and version 1.2 was released which includes the
MIT license file, so the review can proceed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1365794] Review Request: python-keyrings-alt - Alternate keyring implementations for python-keyring

2016-09-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1365794



--- Comment #2 from Charalampos Stratakis  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[!]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
Note: https://github.com/jaraco/keyrings.alt/issues/6

Sent a pull request upstream as well to include a license:
https://github.com/jaraco/keyrings.alt/pull/8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1365794] Review Request: python-keyrings-alt - Alternate keyring implementations for python-keyring

2016-08-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1365794



--- Comment #1 from Charalampos Stratakis  ---
Missing some BuildRequires from both subpackages in order to run the tests:

BuildRequires:  python2-setuptools_scm
BuildRequires:  python-keyring
BuildRequires:  python2-mock

BuildRequires:  python3-setuptools_scm
BuildRequires:  python3-keyring
BuildRequires:  python3-mock


README.txt file doesn't exist, it should be README.rst

Correct path for nspkg.pth files should be in the form:

%{python2_sitelib}/%{srcname}-%{version}-py%{python2_version}-nspkg.pth

and

%{python3_sitelib}/%{srcname}-%{version}-py%{python3_version}-nspkg.pth

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1365794] Review Request: python-keyrings-alt - Alternate keyring implementations for python-keyring

2016-08-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1365794

Charalampos Stratakis  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1365794] Review Request: python-keyrings-alt - Alternate keyring implementations for python-keyring

2016-08-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1365794

Charalampos Stratakis  changed:

   What|Removed |Added

 CC||cstra...@redhat.com
   Assignee|nob...@fedoraproject.org|cstra...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1365794] Review Request: python-keyrings-alt - Alternate keyring implementations for python-keyring

2016-08-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1365794

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1365765




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1365765
[Bug 1365765] python-wheel 0.29.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org


[Bug 1365794] Review Request: python-keyrings-alt - Alternate keyring implementations for python-keyring

2016-08-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1365794

Igor Gnatenko  changed:

   What|Removed |Added

  Alias||python-keyrings-alt



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org