https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #79 from Fedora Update System ---
tpm2-tss-1.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.
--
You are receiving
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #78 from Fedora Update System ---
tpm2-tss-1.0-2.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.
--
You are receiving this
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
Fedora Update System changed:
What|Removed |Added
Status|ON_QA
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #76 from Yunying Sun ---
(In reply to Ralf Corsepius from comment #75)
> Yes. The time to wait changes after a release. It is 3 days (+rel-eng
> delays) during prerelease-phases and 7 days (+rel-eng delays)
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #75 from Ralf Corsepius ---
(In reply to Yunying Sun from comment #74)
> That's in Oct. Has the wait days been extended to 7 days recently?
Yes. The time to wait changes after a release. It is 3 days (+rel-eng
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #74 from Yunying Sun ---
(In reply to Jason Tibbitts from comment #73)
> Without karma, a Fedora update must stay in testing for seven days. An EPEL
> update must stay in testing for fourteen days.
>
> Of
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #73 from Jason Tibbitts ---
Without karma, a Fedora update must stay in testing for seven days. An EPEL
update must stay in testing for fourteen days.
Of course, if you can get three positive test results on
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #72 from Yunying Sun ---
It has been more than 4 days since the updates for this package been pushed to
f25 & epel7 testing, but no update till now:
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #71 from Fedora Update System ---
tpm2-tss-1.0-2.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
Fedora Update System changed:
What|Removed |Added
Status|MODIFIED|ON_QA
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #69 from Yunying Sun ---
SPEC & source tarball have been imported to SCM:
https://src.fedoraproject.org/cgit/rpms/tpm2-tss.git
Build completed for master/f25/epel7:
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #68 from Fedora Update System ---
tpm2-tss-1.0-2.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-22cc02f80e
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
Fedora Update System changed:
What|Removed |Added
Status|ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #67 from Fedora Update System ---
tpm2-tss-1.0-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a49b0a42ea
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #66 from Jon Ciesla ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/tpm2-tss
--
You are receiving this mail because:
You are on the CC list for the bug.
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #65 from Yunying Sun ---
Thanks Dan, really appreciate the approval and sponsoring.
I've created the new package request. "fedpkg clone" currently fails with error
"Could not read from remote repository".
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
Dan Horák changed:
What|Removed |Added
Blocks|177841 (FE-NEEDSPONSOR) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
Dan Horák changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
---
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #63 from Yunying Sun ---
> > Questions left:
> > 1. > N/A*%check is present and all tests pass.
> > Is the %check section a MUST?
>
> it's a SHOULD
>
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #62 from Dan Horák ---
(In reply to Yunying Sun from comment #61)
> (In reply to Dan Horák from comment #60)
> > formal review is here, see the notes explaining OK* and BAD statuses below:
> > ...
> > So almost
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #61 from Yunying Sun ---
(In reply to Dan Horák from comment #60)
> formal review is here, see the notes explaining OK* and BAD statuses below:
> ...
> So almost good, but please answer my question (and/or
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #60 from Dan Horák ---
formal review is here, see the notes explaining OK* and BAD statuses below:
OK source files match upstream:
c610fa5273909394fa54174afcd7541a5c87d16b TPM2.0-TSS-1.0.tar.gz
OK
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
Dan Horák changed:
What|Removed |Added
Assignee|fed...@besser82.io |d...@danny.cz
--- Comment
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #58 from Gang Wei ---
(In reply to Yunying Sun from comment #55)
> (In reply to Josh Boyer from comment #54)
> > (In reply to Dan Horák from comment #53)
> > > Isn't this request a duplicate of
> > >
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #57 from Jerry Snitselaar ---
Looking to the future and RHEL, I noticed when taking a look autoconf-archive
and libcmocka are only available in EPEL. The autoconf-archive was just using
the pthread macro, so
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #56 from Dan Horák ---
(In reply to Yunying Sun from comment #55)
> (In reply to Josh Boyer from comment #54)
> > (In reply to Dan Horák from comment #53)
> > > Isn't this request a duplicate of
> > >
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
Yunying Sun changed:
What|Removed |Added
Flags|needinfo?(fedora@besser82.i |
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
Josh Boyer changed:
What|Removed |Added
CC||jsnit...@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
Dan Horák changed:
What|Removed |Added
CC||yunying@intel.com
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
Dan Horák changed:
What|Removed |Added
Flags||needinfo?
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #53 from Dan Horák ---
Isn't this request a duplicate of
https://admin.fedoraproject.org/pkgdb/package/rpms/tss2/ ?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
Don Bayly changed:
What|Removed |Added
Group|qa |
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #52 from Dan Horák ---
Björn, are you going to continue with the review here?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
Josh Boyer changed:
What|Removed |Added
Group|devel |
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
Don Bayly changed:
What|Removed |Added
Group|intel |
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #51 from Yunying Sun ---
Regarding some of the rpmlint warnings:
> tpm2-tss.src: W: invalid-license TCGL
TCGL license has been added to the Fedora license list by Tom, see comment 43.
tpm2-tss.src: W:
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #50 from Yunying Sun ---
(running fedora-review on this package myself)
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
Don Bayly changed:
What|Removed |Added
Group||intel
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #49 from Yunying Sun ---
(In reply to Björn "besser82" Esser from comment #42)
> Created attachment 1214569 [details]
> License-file contained in upstream-tarball
>
> Well, the license-file shipped with the
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #48 from Yunying Sun ---
More reviews are done on 1395522, 1394789, 1399648, 1398922.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #47 from yunying@intel.com ---
(In reply to Raphael Groner from comment #45)
> Please follow the official process to get sponsored as a packager:
> https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #46 from yunying@intel.com ---
Upstream has released 1.0 at Nov 3 2016:
https://github.com/01org/TPM2.0-TSS/releases
I updated this package to 1.0 upstream as well, to make sure this package is up
to date.
Updated SPEC:
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
Raphael Groner changed:
What|Removed |Added
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
Janet Morgan changed:
What|Removed |Added
Blocks||1275027
--
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #44 from yunying@intel.com ---
(In reply to Tom "spot" Callaway from comment #43)
> I just added the TCGL to the Fedora license list. It is Free and GPL
> compatible, but only when applied to source code. When applied to
>
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
Tom "spot" Callaway changed:
What|Removed |Added
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
Björn "besser82" Esser changed:
What|Removed |Added
Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #42 from Björn "besser82" Esser ---
Created attachment 1214569
--> https://bugzilla.redhat.com/attachment.cgi?id=1214569=edit
License-file contained in upstream-tarball
Well, the license-file shipped with
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
Björn "besser82" Esser changed:
What|Removed |Added
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #41 from yunying@intel.com ---
Hi everyone, this is my first package, and after some reviews and updates, it
has been quiet for some days. Could someone kindly help with further review,
approve and sponsor? Thanks in advance.
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #40 from l...@us.ibm.com ---
(In reply to Orion Poplawski from comment #39)
> (In reply to lo1 from comment #38)
> > Previusly, as I saw Yunying's koji and copr output built fine in the
> > rawhide, I did a little digging and found
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #39 from Orion Poplawski ---
(In reply to lo1 from comment #38)
> Previusly, as I saw Yunying's koji and copr output built fine in the
> rawhide, I did a little digging and found that gcc and gcc-c++ are the
>
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #38 from l...@us.ibm.com ---
(In reply to Igor Gnatenko from comment #35)
> (In reply to yunying.sun from comment #31)
> > (In reply to lo1 from comment #30)
> > > Changelog needs to be updated every time you make changes:
> > >
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #37 from yunying@intel.com ---
(In reply to Igor Gnatenko from comment #35)
> (In reply to yunying.sun from comment #31)
> > (In reply to lo1 from comment #30)
> All BuildRequires must be specified. Even gcc/gcc-c++.
gcc
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #36 from yunying@intel.com ---
(In reply to Igor Gnatenko from comment #35)
> (In reply to yunying.sun from comment #31)
> > (In reply to lo1 from comment #30)
> All BuildRequires must be specified. Even gcc/gcc-c++.
@Igor,
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #35 from Igor Gnatenko ---
(In reply to yunying.sun from comment #31)
> (In reply to lo1 from comment #30)
> > Changelog needs to be updated every time you make changes:
> >
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #34 from yunying@intel.com ---
(In reply to lo1 from comment #32)
> (In reply to yunying.sun from comment #31)
> > (In reply to lo1 from comment #30)
> By the way, the format of the changelog,
> in particular the
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #33 from l...@us.ibm.com ---
> No, I dont think the Fedora 24 local build is mandatory. Sorry, I totally
> ignored the koji and copr for some reasons. To clarify, Koji and Copr build
> would be more appropriate and "clean" as my
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #32 from l...@us.ibm.com ---
(In reply to yunying.sun from comment #31)
> (In reply to lo1 from comment #30)
> > Changelog needs to be updated every time you make changes:
> >
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #31 from yunying@intel.com ---
(In reply to lo1 from comment #30)
> Changelog needs to be updated every time you make changes:
> https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/
> Guidelines#Changelogs
>
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
l...@us.ibm.com changed:
What|Removed |Added
CC||l...@us.ibm.com
--- Comment #30
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #29 from yunying@intel.com ---
Fixed a typo in ExcludeArch list.
Updated SPEC:
https://raw.githubusercontent.com/yunyings/share/master/tpm2-tss.spec
Updated SRPMS:
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #28 from yunying@intel.com ---
@Igor, Ralf, Dmitrij, Orion, could you kindly help to review this package
again? Any comments would be appreciated. Thanks.
--
You are receiving this mail because:
You are on the CC list for the
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #27 from yunying@intel.com ---
(In reply to Orion Poplawski from comment #26)
> You don't need the silly rename-tarball_tss.sh script (which would need be
> changed with each release anyway). Preferred mechanism is in
>
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
Orion Poplawski changed:
What|Removed |Added
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #25 from yunying@intel.com ---
(In reply to Dmitrij S. Kryzhevich from comment #24)
> I meant this:
>
> $ md5sum tpm2-tss-1.0.tar.gz 1.0-beta_1.tar.gz
> 2cdda79640f1e2e534ff897480190686 tpm2-tss-1.0.tar.gz
>
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #24 from Dmitrij S. Kryzhevich ---
I meant this:
$ md5sum tpm2-tss-1.0.tar.gz 1.0-beta_1.tar.gz
2cdda79640f1e2e534ff897480190686 tpm2-tss-1.0.tar.gz
3d6df831cee731d95ef754f6599b3a6c 1.0-beta_1.tar.gz
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #23 from yunying@intel.com ---
(In reply to Dmitrij S. Kryzhevich from comment #22)
> There is no way to get sources via URL in Source0 tag. Moreover, sources in
> src.rpm differs from upstream.
Thanks for reminding, Dmitrij.
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #22 from Dmitrij S. Kryzhevich ---
There is no way to get sources via URL in Source0 tag. Moreover, sources in
src.rpm differs from upstream.
--
You are receiving this mail because:
You are on the CC list for
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #21 from yunying@intel.com ---
(In reply to yunying.sun from comment #20)
> (In reply to Dmitrij S. Kryzhevich from comment #18)
> > There are still *.la files in -devel. They must not be included.
> *.la removed from SPEC.
> >
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #20 from yunying@intel.com ---
(In reply to Dmitrij S. Kryzhevich from comment #18)
> There are still *.la files in -devel. They must not be included.
*.la removed from SPEC.
>
> Trusted Platform Module *could* be installed
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #19 from Dmitrij S. Kryzhevich ---
In addition: and src.rpm too.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
Dmitrij S. Kryzhevich changed:
What|Removed |Added
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #17 from yunying@intel.com ---
(In reply to yunying.sun from comment #16)
> (In reply to Ralf Corsepius from comment #13)
> > (In reply to yunying.sun from comment #12)
> > > Could you help to review again?
> >
> > Here we go:
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #16 from yunying@intel.com ---
(In reply to Ralf Corsepius from comment #13)
> (In reply to yunying.sun from comment #12)
> > Could you help to review again?
>
> Here we go:
>
> - Please append --disable-silent-rules to
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #15 from yunying@intel.com ---
(In reply to Ralf Corsepius from comment #13)
> (In reply to yunying.sun from comment #12)
> > Could you help to review again?
>
> Here we go:
>
> - Please append --disable-silent-rules to
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #14 from Ralf Corsepius ---
Created attachment 1197361
--> https://bugzilla.redhat.com/attachment.cgi?id=1197361=edit
Patch to tpm2-tss.spec as announced in comment#13
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #13 from Ralf Corsepius ---
(In reply to yunying.sun from comment #12)
> Could you help to review again?
Here we go:
- Please append --disable-silent-rules to %configure
This enforces verbose building,
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #12 from yunying@intel.com ---
(In reply to Ralf Corsepius from comment #11)
> (In reply to yunying.sun from comment #9)
>
> > Yes, tpm2-tools.srpm fails to build due to missing BuildRequires for package
> > "tpm2-tss" &
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
yunying@intel.com changed:
What|Removed |Added
Blocks||1369720
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #11 from Ralf Corsepius ---
(In reply to yunying.sun from comment #9)
> Yes, tpm2-tools.srpm fails to build due to missing BuildRequires for package
> "tpm2-tss" & "tpm2-tss-devel".
> To make tpm2-tools koji
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #10 from yunying@intel.com ---
(In reply to Ralf Corsepius from comment #8)
> (In reply to yunying.sun from comment #4)
> > the configure error "cannot run C compiled programs" is there, seems because
> > "%configure" adds an
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #9 from yunying@intel.com ---
(In reply to Ralf Corsepius from comment #8)
> (In reply to yunying.sun from comment #4)
> > the configure error "cannot run C compiled programs" is there, seems because
> > "%configure" adds an
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
Ralf Corsepius changed:
What|Removed |Added
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #7 from yunying@intel.com ---
(In reply to yunying.sun from comment #6)
> (In reply to Igor Gnatenko from comment #5)
> > (In reply to yunying.sun from comment #4)
> > > the configure error "cannot run C compiled programs" is
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #6 from yunying@intel.com ---
(In reply to Igor Gnatenko from comment #5)
> (In reply to yunying.sun from comment #4)
> > the configure error "cannot run C compiled programs" is there, seems because
> > "%configure" adds an
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #5 from Igor Gnatenko ---
(In reply to yunying.sun from comment #4)
> the configure error "cannot run C compiled programs" is there, seems because
> "%configure" adds an extra flag "-Werror" to CFLAGS, which
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #4 from yunying@intel.com ---
the configure error "cannot run C compiled programs" is there, seems because
"%configure" adds an extra flag "-Werror" to CFLAGS, which turns some config
warnings to errors. With "./configure",
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #3 from yunying@intel.com ---
(In reply to Igor Gnatenko from comment #1)
> > BuildRequires: pkgconfig
> > BuildRequires: libcmocka-devel
> BuildRequires: pkgconfig(cmocka)
>
> > CONFIG_SITE=$(pwd)/lib/default_config.site
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #2 from yunying@intel.com ---
(In reply to Igor Gnatenko from comment #1)
> > BuildRequires: pkgconfig
> > BuildRequires: libcmocka-devel
> BuildRequires: pkgconfig(cmocka)
>
> > CONFIG_SITE=$(pwd)/lib/default_config.site
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
--- Comment #1 from Igor Gnatenko ---
> BuildRequires: pkgconfig
> BuildRequires: libcmocka-devel
BuildRequires: pkgconfig(cmocka)
> CONFIG_SITE=$(pwd)/lib/default_config.site ./configure
export
https://bugzilla.redhat.com/show_bug.cgi?id=1369708
yunying@intel.com changed:
What|Removed |Added
Blocks||177841 (FE-NEEDSPONSOR)
92 matches
Mail list logo