[Bug 1373821] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373821

Alan Pevec  changed:

   What|Removed |Added

 Blocks|1327635 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1327635
[Bug 1327635] Review Request: openstack-congress - OpenStack Congress
Service
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373821] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373821

Dan Radez  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2016-12-21 23:12:18



--- Comment #14 from Dan Radez  ---


*** This bug has been marked as a duplicate of bug 1407000 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373821] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373821

Dan Radez  changed:

   What|Removed |Added

  Flags|needinfo?(dra...@redhat.com |
   |)   |



--- Comment #13 from Dan Radez  ---
Good to know, thx will do that now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373821] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373821

Alan Pevec  changed:

   What|Removed |Added

  Flags||needinfo?(dra...@redhat.com
   ||)



--- Comment #12 from Alan Pevec  ---
Dan, you will need to open a new Fedora review bz, b/c Fedora tooling requires
review bz to be reported by the packager. Please close this one as a duplicate
of your new review bz.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373821] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373821

Alan Pevec  changed:

   What|Removed |Added

 CC||ape...@redhat.com
 Blocks|1329341 (RDO-NEWTON)|1373513 (RDO-OCATA)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1329341
[Bug 1329341] Tracker: Blockers and Review requests for new RDO Newton
packages
https://bugzilla.redhat.com/show_bug.cgi?id=1373513
[Bug 1373513] Tracker: Blockers and Review requests for new RDO Ocata
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373821] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373821



--- Comment #11 from Dan Radez  ---
Made a couple more updates:
Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=16969655
SPRM: https://radez.fedorapeople.org/python-PuLP-1.6.1-2.fc25.src.rpm
Spec: https://radez.fedorapeople.org/python-pulp.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373821] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373821

Dan Radez  changed:

   What|Removed |Added

   Assignee|ignate...@redhat.com|dra...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373821] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373821



--- Comment #10 from Dan Radez  ---
I can pick up and run with this review:
New SPRM: https://radez.fedorapeople.org/python-PuLP-1.6.1-2.fc25.src.rpm
New Spec: https://radez.fedorapeople.org/python-pulp.spec
Koji Scratch: https://radez.fedorapeople.org/python-pulp.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373821] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373821



--- Comment #9 from Haïkel Guémar  ---
mflobo changed job since and it seems he's too busy to move forward so as his
sponsor, I suggest to declare this review stalled.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373821] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373821

Igor Gnatenko  changed:

   What|Removed |Added

  Flags|needinfo?(ignatenko@redhat. |
   |com)|
   |needinfo?(ignatenko@redhat. |
   |com)|



--- Comment #8 from Igor Gnatenko  ---
I guess upstream puts something like /usr/lib64 into one of files which makes
it arch-dependent. I would recommend to grep and fix issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373821] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373821

Marcos  changed:

   What|Removed |Added

  Flags||needinfo?(ignatenko@redhat.
   ||com)



--- Comment #7 from Marcos  ---
Hi Igor,

I tried to build the rpm with your modifications
https://github.com/marcosflobo/package_review/commit/45674935dd077a3f14af6875babb0cd50f90a7d0
but unfortunately I had this error:

"Arch dependent binaries in noarch package"

I tried to fix it adding:

%define _binaries_in_noarch_packages_terminate_build   0

At top of the SPEC file, but apparently is not enough.

So, with this SPEC file
https://github.com/marcosflobo/package_review/blob/master/pulp/1.6.1/python-pulp.spec
and this ZIP file https://pypi.python.org/pypi/PuLP I have this issues:

$  rpmbuild -bb --define dist.fc24 rpmbuild/SPEC/python-pulp.spec
[...]
 cd PuLP-1.6.1
+
LICENSEDIR=/home/mflobo/rpmbuild/BUILDROOT/python-PuLP-1.6.1-1.fc24.x86_64/usr/share/licenses/python3-PuLP
+ export LICENSEDIR
+ /usr/bin/mkdir -p
/home/mflobo/rpmbuild/BUILDROOT/python-PuLP-1.6.1-1.fc24.x86_64/usr/share/licenses/python3-PuLP
+ cp -pr LICENSE
/home/mflobo/rpmbuild/BUILDROOT/python-PuLP-1.6.1-1.fc24.x86_64/usr/share/licenses/python3-PuLP
+ exit 0


RPM build errors:
Macro %dist needs whitespace before body
Macro %dist needs whitespace before body
Macro %dist needs whitespace before body
Arch dependent binaries in noarch package
File not found:
/home/mflobo/rpmbuild/BUILDROOT/python-PuLP-1.6.1-1.fc24.x86_64/usr/bin/pulp

Could you give a hand on with this package? is being a bit painful and I don't
understand the issue.

Thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373821] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373821

Haïkel Guémar  changed:

   What|Removed |Added

 CC||karlthe...@gmail.com
 Blocks||1329341 (RDO-NEWTON)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1329341
[Bug 1329341] Tracker: Blockers and Review requests for new RDO Newton
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373821] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373821

Marcos  changed:

   What|Removed |Added

  Flags||needinfo?(ignatenko@redhat.
   ||com)



--- Comment #6 from Marcos  ---
Hi Igor,

Thanks for review and sorry because I didn't update the files at github.
Please, check again and write your comments.

Spec URL:
https://github.com/marcosflobo/package_review/blob/master/pulp/1.6.1/python-pulp.spec
SRPM URL:
https://github.com/marcosflobo/package_review/raw/master/pulp/1.6.1/python-PuLP-1.6.1-1.fc24.src.rpm


Successful scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=15559934

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1373821] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373821

Igor Gnatenko  changed:

   What|Removed |Added

  Flags|needinfo?(ignatenko@redhat. |
   |com)|



--- Comment #5 from Igor Gnatenko  ---
> %define _binaries_in_noarch_packages_terminate_build 0
this is something wrong

> BuildRequires: python-setuptools
python2-setuptools
... same for all packages

> /usr/lib/debug*
no.

* Package should contain py2 and py3 subpackage, it does not

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1373821] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373821

Marcos  changed:

   What|Removed |Added

  Flags||needinfo?(ignatenko@redhat.
   ||com)



--- Comment #4 from Marcos  ---
Hi,

I think I addressed all your comments, please take a look again:

Spec URL:
https://github.com/marcosflobo/package_review/blob/master/pulp/1.6.1/python-pulp.spec
SRPM URL:
https://github.com/marcosflobo/package_review/raw/master/pulp/1.6.1/python-PuLP-1.6.1-1.fc24.src.rpm

Successful scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=15559934

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1373821] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373821



--- Comment #3 from Igor Gnatenko  ---
(In reply to Javier Peña from comment #2)
> For the Source URL, you could use
> https://pypi.io/packages/source/P/%{pypi_name}/%{pypi_name}-%{version}.tar.gz

https://files.pythonhosted.org/packages/source/%(n=%{pypi_name}; echo
${n:0:1})/%{pypi_name}/%{pypi_name}-%{version}.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1373821] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373821

Javier Peña  changed:

   What|Removed |Added

 CC||jp...@redhat.com



--- Comment #2 from Javier Peña  ---
For the Source URL, you could use
https://pypi.io/packages/source/P/%{pypi_name}/%{pypi_name}-%{version}.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1373821] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373821

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|jp...@redhat.com|ignate...@redhat.com



--- Comment #1 from Igor Gnatenko  ---
* package should have py2 and py3 versions
* no hardcoded sha-sums in SourceURL please
* no owning debug files please

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1373821] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373821

Marcos  changed:

   What|Removed |Added

 Blocks||1327635
   Assignee|nob...@fedoraproject.org|jp...@redhat.com




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1327635
[Bug 1327635] Review Request: openstack-congress - OpenStack Congress
Service
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org