https://bugzilla.redhat.com/show_bug.cgi?id=1375926
Fedora Update System changed:
What|Removed |Added
Status|ON_QA |CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1375926
Fedora Update System changed:
What|Removed |Added
Status|MODIFIED|ON_QA
--- Comment #17 from Fed
https://bugzilla.redhat.com/show_bug.cgi?id=1375926
Fedora Update System changed:
What|Removed |Added
Status|NEW |MODIFIED
--
You are receiving
https://bugzilla.redhat.com/show_bug.cgi?id=1375926
--- Comment #16 from Fedora Update System ---
python-nose2-0.6.5-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-de3d12ca85
--
You are receiving this mail because:
You are on the CC li
https://bugzilla.redhat.com/show_bug.cgi?id=1375926
--- Comment #15 from Jon Ciesla ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-nose2
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about
https://bugzilla.redhat.com/show_bug.cgi?id=1375926
Neal Gompa changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #14 from Neal
https://bugzilla.redhat.com/show_bug.cgi?id=1375926
--- Comment #13 from Neal Gompa ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- Binary eggs must be removed in %prep
Note: Binary egg files not removed in %prep
https://bugzilla.redhat.com/show_bug.cgi?id=1375926
--- Comment #12 from Aurelien Bompard ---
Ah, right, I fixed the BuildRequires but not the Requires in the python2
subpackage. Fixed now.
Spec URL: https://abompard.fedorapeople.org/reviews/nose2/python-nose2.spec
SRPM URL:
https://abompard.f
https://bugzilla.redhat.com/show_bug.cgi?id=1375926
--- Comment #11 from Neal Gompa ---
There's a dependency error. "python2-cov-core" doesn't exist. The current
python-cov-core spec doesn't comply with the current Python packaging
guidelines, so the dependency needs to be changed to "python-co
https://bugzilla.redhat.com/show_bug.cgi?id=1375926
--- Comment #10 from Aurelien Bompard ---
Spec URL: https://abompard.fedorapeople.org/reviews/nose2/python-nose2.spec
SRPM URL:
https://abompard.fedorapeople.org/reviews/nose2/python-nose2-0.6.5-1.fc23.src.rpm
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=1375926
--- Comment #9 from Neal Gompa ---
They just have to be posted in the same form as you did in the first post.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product a
https://bugzilla.redhat.com/show_bug.cgi?id=1375926
--- Comment #8 from Aurelien Bompard ---
It's the same links as before, should I set them in a special field?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product a
https://bugzilla.redhat.com/show_bug.cgi?id=1375926
--- Comment #7 from Neal Gompa ---
Could you please post updated Spec and SRPM links so that fedora-review can
process them?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to
https://bugzilla.redhat.com/show_bug.cgi?id=1375926
--- Comment #6 from Aurelien Bompard ---
Darn, sorry for that. Sometimes it's the most obvious things you see last.
Updated.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to
https://bugzilla.redhat.com/show_bug.cgi?id=1375926
--- Comment #5 from Neal Gompa ---
Your file list for the python3_other subpackage is wrong, as it has
"sample-exec" something or other. You might want to verify that the list is
correct...
--
You are receiving this mail because:
You are on
https://bugzilla.redhat.com/show_bug.cgi?id=1375926
--- Comment #4 from Aurelien Bompard ---
Updated, thanks.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
https://bugzilla.redhat.com/show_bug.cgi?id=1375926
--- Comment #3 from Neal Gompa ---
You need to conditionalize the build, install, check, and file lists for the
python3_other subpackage, as they're only supposed to be run in a python3X
bootstrap condition.
--
You are receiving this mail be
https://bugzilla.redhat.com/show_bug.cgi?id=1375926
--- Comment #2 from Aurelien Bompard ---
I updated the package, taking into account two differences between F24 and
EPEL:
- Python2 packages now have the "python2" namespace, not just "python"
- Python2 is still the default in EPEL, not Python
https://bugzilla.redhat.com/show_bug.cgi?id=1375926
--- Comment #1 from Neal Gompa ---
Overall, this spec looks good. It conforms very well to the Fedora guidelines.
However, there are a couple of issues. For example, if this package is intended
to work with EPEL, you need to support the EPEL
https://bugzilla.redhat.com/show_bug.cgi?id=1375926
Neal Gompa changed:
What|Removed |Added
CC||ngomp...@gmail.com
Assignee|nob.
https://bugzilla.redhat.com/show_bug.cgi?id=1375926
Igor Gnatenko changed:
What|Removed |Added
Summary|Review Request: nose2 - |Review Request:
|Next
21 matches
Mail list logo
