[Bug 1376899] Review Request: pcaudiolib - Portable C Audio Library
https://bugzilla.redhat.com/show_bug.cgi?id=1376899 --- Comment #12 from Fedora Update System --- pcaudiolib-1.0-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376899] Review Request: pcaudiolib - Portable C Audio Library
https://bugzilla.redhat.com/show_bug.cgi?id=1376899 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-10-23 18:53:55 --- Comment #11 from Fedora Update System --- pcaudiolib-1.0-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376899] Review Request: pcaudiolib - Portable C Audio Library
https://bugzilla.redhat.com/show_bug.cgi?id=1376899 --- Comment #10 from Fedora Update System --- pcaudiolib-1.0-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7d3d83c78c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376899] Review Request: pcaudiolib - Portable C Audio Library
https://bugzilla.redhat.com/show_bug.cgi?id=1376899 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #9 from Fedora Update System --- pcaudiolib-1.0-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c3d54ee585 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376899] Review Request: pcaudiolib - Portable C Audio Library
https://bugzilla.redhat.com/show_bug.cgi?id=1376899 --- Comment #8 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/pcaudiolib -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376899] Review Request: pcaudiolib - Portable C Audio Library
https://bugzilla.redhat.com/show_bug.cgi?id=1376899 Petr Menšík changed: What|Removed |Added Flags|fedora-review? |fedora-review- --- Comment #6 from Petr Menšík --- [x]: Fully versioned dependency in subpackages if applicable. Thank you, I think it is ready. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376899] Review Request: pcaudiolib - Portable C Audio Library
https://bugzilla.redhat.com/show_bug.cgi?id=1376899 Petr Menšík changed: What|Removed |Added Flags|fedora-review- |fedora-review+ --- Comment #7 from Petr Menšík --- Sorry! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376899] Review Request: pcaudiolib - Portable C Audio Library
https://bugzilla.redhat.com/show_bug.cgi?id=1376899 --- Comment #5 from Ondřej Lysoněk --- Absolutely, I simply forgot about this. Spec URL: http://www.fi.muni.cz/~xlysonek/pcaudiolib.spec SRPM URL: http://www.fi.muni.cz/~xlysonek/pcaudiolib-1.0-3.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376899] Review Request: pcaudiolib - Portable C Audio Library
https://bugzilla.redhat.com/show_bug.cgi?id=1376899 --- Comment #4 from Petr Menšík --- Good, thank you. One last thing, devel subpackage should require also architecture, it should be: Requires: %{name}%{?_isa} = %{version}-%{release} But it is not mandatory. Will you change it too, please? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376899] Review Request: pcaudiolib - Portable C Audio Library
https://bugzilla.redhat.com/show_bug.cgi?id=1376899 --- Comment #3 from Ondřej Lysoněk --- Done, thanks! Spec URL: http://www.fi.muni.cz/~xlysonek/pcaudiolib.spec SRPM URL: http://www.fi.muni.cz/~xlysonek/pcaudiolib-1.0-2.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376899] Review Request: pcaudiolib - Portable C Audio Library
https://bugzilla.redhat.com/show_bug.cgi?id=1376899 Petr Menšík changed: What|Removed |Added Flags|fedora-review+ |fedora-review? --- Comment #2 from Petr Menšík --- Add %dir %{_includedir}/pcaudiolib into %files devel in spec, include directory is unowned. Consider using %{_includedir}/%{name} instead. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376899] Review Request: pcaudiolib - Portable C Audio Library
https://bugzilla.redhat.com/show_bug.cgi?id=1376899 Petr Menšík changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376899] Review Request: pcaudiolib - Portable C Audio Library
https://bugzilla.redhat.com/show_bug.cgi?id=1376899 --- Comment #1 from Petr Menšík --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc make See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)", "Unknown or generated". 5 files have unknown license. Detailed output of licensecheck in /home/pemensik/fedora/rawhide/1376899-pcaudiolib/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: Package requires other packages for directories it uses. Note: No known owner of /usr/include/pcaudiolib [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/include/pcaudiolib [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in pcaudiolib-devel , pcaudiolib-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files
[Bug 1376899] Review Request: pcaudiolib - Portable C Audio Library
https://bugzilla.redhat.com/show_bug.cgi?id=1376899 Petr Menšík changed: What|Removed |Added CC||pemen...@redhat.com Assignee|jskar...@redhat.com |pemen...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376899] Review Request: pcaudiolib - Portable C Audio Library
https://bugzilla.redhat.com/show_bug.cgi?id=1376899 Jaroslav Škarvada changed: What|Removed |Added Status|NEW |ASSIGNED CC||jskar...@redhat.com Assignee|nob...@fedoraproject.org|jskar...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376899] Review Request: pcaudiolib - Portable C Audio Library
https://bugzilla.redhat.com/show_bug.cgi?id=1376899 Ondřej Lysoněk changed: What|Removed |Added Blocks||1376900 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1376900 [Bug 1376900] Review Request: espeak-ng - eSpeak NG Text-to-Speech -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org