[Bug 1381735] Review Request: python-astroscrappy - Cosmic Ray Annihilation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381735

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-10-15 12:10:03



--- Comment #8 from Fedora Update System  ---
python-astroscrappy-1.0.5-2.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381735] Review Request: python-astroscrappy - Cosmic Ray Annihilation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381735

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|ON_QA



--- Comment #7 from Fedora Update System  ---
python-astroscrappy-1.0.5-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-8216cd4338

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381735] Review Request: python-astroscrappy - Cosmic Ray Annihilation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381735



--- Comment #6 from Patrick Uiterwijk  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-astroscrappy

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381735] Review Request: python-astroscrappy - Cosmic Ray Annihilation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381735

Björn "besser82" Esser  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Björn "besser82" Esser  ---
Looks fine now!  =)

Package APPROVED!!!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381735] Review Request: python-astroscrappy - Cosmic Ray Annihilation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381735



--- Comment #4 from Christian Dersch  ---
Indeed, I forgot to add the special licenses of two files.. Added now, thank
you :)

Spec URL: https://lupinix.fedorapeople.org/review/python-astroscrappy.spec
SRPM URL:
https://lupinix.fedorapeople.org/review/python-astroscrappy-1.0.5-2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381735] Review Request: python-astroscrappy - Cosmic Ray Annihilation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381735



--- Comment #3 from Björn "besser82" Esser  ---
Created attachment 1208231
  --> https://bugzilla.redhat.com/attachment.cgi?id=1208231=edit
output of licensecheck

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381735] Review Request: python-astroscrappy - Cosmic Ray Annihilation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381735



--- Comment #2 from Björn "besser82" Esser  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.

 ---> Fine for Python-packages.

[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Apache (v2.0)", "PSF", "Unknown or
 generated". 122 files have unknown license. Detailed output of
 licensecheck in /home/besser82/shared/fedora/review/1381735-python-
 astroscrappy/licensecheck.txt

 ---> please fix License-tag and document license-breakdown in spec-file.

[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 4 files.
[!]: Package complies to the Packaging Guidelines

 ---> See Licensing…

[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in 

[Bug 1381735] Review Request: python-astroscrappy - Cosmic Ray Annihilation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381735

Björn "besser82" Esser  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||fed...@besser82.io
   Assignee|nob...@fedoraproject.org|fed...@besser82.io
  Flags||fedora-review?



--- Comment #1 from Björn "besser82" Esser  ---
taken…  =)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381735] Review Request: python-astroscrappy - Cosmic Ray Annihilation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381735

Christian Dersch  changed:

   What|Removed |Added

 Blocks||115 (Astronomy-SIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=115
[Bug 115] Astronomy SIG - review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org