[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 Jared Wallace changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 Jared Wallace changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2016-12-06 13:07:11 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 --- Comment #24 from Jared Wallace --- F26 has introduced some changes to default compiler flags: https://fedoraproject.org/wiki/Changes/Fedora26CFlags which required some more patches. SPEC: https://bitbucket.org/jared-wallace/orpie/raw/c06bd4f36d4a8fe023364da5c172d281e9941c74/SPECS/orpie.spec SRPM: https://bitbucket.org/jared-wallace/orpie/raw/c06bd4f36d4a8fe023364da5c172d281e9941c74/SRPMS/orpie-1.5.2-4.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 --- Comment #23 from Randy Barlow --- Hello Jared! I see that your e-mail addresses now match, so I have sponsored you as a packager. Congratulations! You can now proceed with the next step here: https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner If you have any questions about being a Fedora maintainer now or in the future, feel free to reach out to me by e-mail or IRC (I'm bowlofeggs on Freenode). I'm happy to help out! Also, you can add me as a co-maintainer on this package if you like. Go forth and do good with your packager powers! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 --- Comment #22 from Randy Barlow --- Hey Jared! I looked at your third review and it looks good. The package is approved, so the last step is that I need to sponsor you into the packager's group. One thing that I am supposed to do is to make sure that your bugzilla account's e-mail address is the same as the e-mail address listed on your FAS account[0]. It seems that they are currently mismatched. Can you update one or the other so they match? Unfortunately I am about to go on a short vacation, so I won't be able to sponsor you until Monday next week. However, it's a short process once the e-mail addresses match! [0] https://fedoraproject.org/wiki/How_to_sponsor_a_new_contributor?rd=PackageMaintainers/SponsorProcess#Sponsoring_Someone_for_Fedora_Package_Collection -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152
Randy Barlow changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #21 from Randy Barlow ---
Alright, you've got this spec file to the point that I'm willing to mark it as
approved! I've left a few notes in there (search for "randy:" for my comments)
about some ways you can improve it, but those are all at your option and you
can do it after you've got the package in Fedora.
I need to go to dinner right now. When I come back I'll take a look at that
third package review you did. If it checks out, I think we'll be ready to mark
you as sponsored!
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://admin.fedoraproject.org/pkgdb/package/orpie
See:
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "LGPL (v2)", "GPL (v2) (with incorrect FSF address)", "Unknown
or generated", "*No copyright* GPL", "*No copyright* LGPL", "GPL (v2
or later) (with incorrect FSF address)", "GPL (v2)". 51 files have
unknown license. Detailed output of licensecheck in
/home/rbarlow/reviews/orpie/licensecheck.txt
randy: I think you can use the word "and" between the licenses. Also,
you don't need to list "GPLv2" and "GPLv2+".
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 348160 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 Jared Wallace changed: What|Removed |Added Flags|needinfo?(jared-wallace@us. | |ibm.com)| --- Comment #20 from Jared Wallace --- Cool beans. Last review is here: https://bugzilla.redhat.com/show_bug.cgi?id=1374510#c4 Specfile: https://bitbucket.org/jared-wallace/orpie/raw/e147c118290433c0db7c7df3a6cb3857f54df718/SPECS/orpie.spec SRPM: https://bitbucket.org/jared-wallace/orpie/raw/e147c118290433c0db7c7df3a6cb3857f54df718/SRPMS/orpie-1.5.2-3.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 --- Comment #19 from Randy Barlow --- P.S. The two reviews you've done so far are great. I especially liked that you took the time to help one of them write a man page! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 Randy Barlow changed: What|Removed |Added Flags||needinfo?(jared-wallace@us. ||ibm.com) --- Comment #18 from Randy Barlow --- Hey Jared! We're almost there with this spec file, there's one last thing I think we should do: let's add comments over the Patch# lines in the spec file explaining what each patch is for, and either a) a link to an upstream pull request that has the patch, or b) an explanation why the patch doesn't need to go upstream. Once you've got that, can you do one more unofficial review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 --- Comment #17 from Jared Wallace --- I'm a little tired...forgot an edit in the changelog Specfile: https://bitbucket.org/jared-wallace/orpie/raw/5004a3f1257d7e4d60c78e5d56fc20aa8da4f48f/SPECS/orpie.spec SRPM: https://bitbucket.org/jared-wallace/orpie/raw/f71b78e9718793be602ce09e93acefadaec5d368/SRPMS/orpie-1.5.2-3.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 --- Comment #16 from Jared Wallace --- Fixed the issue. Looks like the newer Ocaml exposed some pre-existing issues. Patched: gsl/gsl_sf.ml - commented out reference to functions deleted by patch 0 Makefile.in - added two libraries to the GSL_CMO list gsl/mlgsl_error.c - fixing the original issue seen of an undefined function Specfile: https://bitbucket.org/jared-wallace/orpie/raw/f71b78e9718793be602ce09e93acefadaec5d368/SPECS/orpie.spec SRPM: https://bitbucket.org/jared-wallace/orpie/raw/f71b78e9718793be602ce09e93acefadaec5d368/SRPMS/orpie-1.5.2-3.fc24.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16676762 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 --- Comment #15 from Jared Wallace --- There are two Ocaml related changes in rawhide. This is one: https://bugzilla.redhat.com/show_bug.cgi?id=1391950 but unfortunately, adding that dependency did not resolve. The other was the move from Ocaml 4.02 to 4.04, and I think that may be the issue. I'm setting up a rawhide VM for testing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 Jared Wallace changed: What|Removed |Added Flags|needinfo?(jared-wallace@us. | |ibm.com)| --- Comment #14 from Jared Wallace --- Something changed in rawhide, it would seem. I reverted my git repo back to the initial commit, and tried building that version on Rawhide - and it failed. I'll do some digging. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 Randy Barlow changed: What|Removed |Added Flags||needinfo?(jared-wallace@us. ||ibm.com) --- Comment #13 from Randy Barlow --- It seems that there is a build failure now. This command fails to build on my Rawhide box: $ fedora-review -b 1382152 Additionally, I was able to get this build to fail in koji on both Rawhide and F23: http://koji.fedoraproject.org/koji/taskinfo?taskID=16479303 http://koji.fedoraproject.org/koji/taskinfo?taskID=16479312 It does appear that this build succeeds on Fedora 24: https://kojipkgs.fedoraproject.org//work/tasks/9306/16479306/build.log You can navigate to the build.log files on those two Koji links by clicking on the child tasks that are red and then clicking on build.log. For Rawhide: https://kojipkgs.fedoraproject.org//work/tasks/9306/16479306/build.log If you don't intend to add this package to F23 we can ignore that failure, but you will need to make sure it works on Rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 Jared Wallace changed: What|Removed |Added Flags|needinfo?(jared-wallace@us. | |ibm.com)| --- Comment #12 from Jared Wallace --- No problem. Spec URL: https://bitbucket.org/jared-wallace/orpie/raw/19e6466752aac51f6edde20f069d296df1c45cb0/SPECS/orpie.spec SRPM URL: https://bitbucket.org/jared-wallace/orpie/raw/19e6466752aac51f6edde20f069d296df1c45cb0/SRPMS/orpie-1.5.2-2.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 Randy Barlow changed: What|Removed |Added Flags||needinfo?(jared-wallace@us. ||ibm.com) --- Comment #11 from Randy Barlow --- Hello Jared! The new spec looks good. When making changes, it's customary to also rebuild the SRPM when rebuilding the spec, and then to make a formatted BZ comment here so that fedora-review can find and compare them: Spec URL: SRPM URL: Can you rebuild the SRPM with the new spec and link them in a comment here? I think this spec is in pretty good shape. I'll take a look at the reviews you did soon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 --- Comment #10 from Jared Wallace --- Second unofficial review: https://bugzilla.redhat.com/show_bug.cgi?id=1376511#c6 This is far from done though, several issues that need to be tackled before review continues. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 --- Comment #9 from Jared Wallace --- *doh* fixed spec is here: https://bitbucket.org/jared-wallace/orpie/raw/e9223f4935c3716f46c577f389382ef4ccbe07a9/SPECS/orpie.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 Jared Wallace changed: What|Removed |Added Flags|needinfo?(jared-wallace@us. | |ibm.com)| --- Comment #8 from Jared Wallace --- First unofficial review here: https://bugzilla.redhat.com/show_bug.cgi?id=1392599#c2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 Randy Barlow changed: What|Removed |Added Flags||needinfo?(jared-wallace@us. ||ibm.com) --- Comment #7 from Randy Barlow --- Hey Jared! The changes look nice! Two things I noticed in your changelog: * There's a line that says you added the multi-core, but as you noted it doesn't build that way so it's not actually added. I think it's OK to not build multi-core since that doesn't work, so let's just drop that changelog entry. * Typically people add a space between changelog entries for readability, so adding one more newline before the Wed Oct 05 line would improve readability. This is just a suggestion of mine, not a formal requirement, so it's up to you. Let's fix at least that first one, and then I think this'll be ready to pass review. Then we can look at some package reviews. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 --- Comment #6 from Jared Wallace --- New spec: https://bitbucket.org/jared-wallace/orpie/raw/f4be32478c1f3fcbc215e090e08064beb7290c19/SPECS/orpie.spec New SRPM:https://bitbucket.org/jared-wallace/orpie/raw/f4be32478c1f3fcbc215e090e08064beb7290c19/SRPMS/orpie-1.5.2-2.fc24.src.rpm The parallel compiler flag actually breaks the build :/ I opened an issue upstream here: https://github.com/pelzlpj/orpie/issues/9 Copr has new builds as well -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 Jared Wallace changed: What|Removed |Added Flags|needinfo?(jared-wallace@us. | |ibm.com)| --- Comment #5 from Jared Wallace --- Thanks :) I'll get to work on these items and the reviews immediately. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152
Randy Barlow changed:
What|Removed |Added
CC||jared-wall...@us.ibm.com
Flags||needinfo?(jared-wallace@us.
||ibm.com)
--- Comment #4 from Randy Barlow ---
Hello Jared! I'm thrilled that you want to become a Fedora packager, and I'm
happy to work with you to get you sponsored. In addition to this package, I'd
like to request that you perform practice reviews on 3 other packages that need
review. Make sure to mention on those reviews that they are practice reviews so
the submitter doesn't get their hopes up too much ☺ You should put links to
those three packages here, and I'll go take a look as well. This helps
demonstrate that you have a decent command of the packaging guidelines, and is
good since once you are a packager you will have the power to approve other
packages!
I've taken a look at your package, and it's in pretty good shape. There are
just a few things to fix before it meets the required guidelines, and I've also
included a few optional suggestions as well. To be clear, I would only require
you to fix the items noted in the MUST section below, but the others are nice
improvements too. I put notes next to "randy: " to add my own thoughts here and
there:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Dist tag is present.
randy: This means that your Release: should be 1%{?dist} instead of just 1.
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file COPYING is not marked as %license
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
randy: Instead of marking the COPYYING file as a %doc, use %license COPYING.
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://admin.fedoraproject.org/pkgdb/package/orpie
See:
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names
randy: I think this will probably be OK - we'll have to go through the
unretiring
process after getting you sponsored.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or later) (with incorrect FSF address)", "LGPL (v2)",
"GPL (v2) (with incorrect FSF address)", "Unknown or generated". 105
files have unknown license. Detailed output of licensecheck in
/home/rbarlow/reviews/1382152-orpie/licensecheck.txt
randy: You can and should list all the licenses included in this package
in the
license field. Looks like GPLv2, GPLv2+, and LGPLv2 would be
correct.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[!]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
randy: You can just drop that defattr line - the attr you defined is the
default.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 Randy Barlow changed: What|Removed |Added Status|NEW |ASSIGNED CC||ra...@electronsweatshop.com Assignee|nob...@fedoraproject.org|ra...@electronsweatshop.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 --- Comment #3 from Jared Wallace --- Since it wasn't made clear, this package was orphaned and retired: https://admin.fedoraproject.org/pkgdb/package/rpms/orpie/ Not sure now if it requires review or not. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 --- Comment #2 from Jared Wallace --- Tried the fedora-review tool, which fails since the original post did not have raw links. So let's fix that. Spec:https://bitbucket.org/jared-wallace/orpie/raw/2abe80a8c1e7e7c7a72056e14d72380828ccd937/SPECS/orpie.spec SRPM:https://bitbucket.org/jared-wallace/orpie/raw/2abe80a8c1e7e7c7a72056e14d72380828ccd937/SRPMS/orpie-1.5.2-1.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 Antonio Trande changed: What|Removed |Added CC||anto.tra...@gmail.com Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 --- Comment #1 from Jared Wallace --- Another side note: packaging guidelines require a bug to be filed when the package in question does not build on a particular architecture. This will not build on armv7hl but I don't see how to file a bug against a package that's not actually in Fedora right now. Reason for not building is here: https://kojipkgs.fedoraproject.org//work/tasks/7112/15957112/build.log -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
