[Bug 1382813] Review Request: unity-gtk-module - GTK+ module for exporting old-style menus as GMenuModels

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382813



--- Comment #7 from Fedora Update System  ---
appmenu-qt5-0.3.0+16.10.20160628.1-1.fc24,
cinnamon-applet-globalappmenu-0.6-1.git20160913.5b55d2d.fc24,
unity-gtk-module-0.0.0+16.10.20160913-1.fc24 has been pushed to the Fedora 24
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382813] Review Request: unity-gtk-module - GTK+ module for exporting old-style menus as GMenuModels

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382813

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-10-16 14:52:00



--- Comment #6 from Fedora Update System  ---
appmenu-qt5-0.3.0+16.10.20160628.1-1.fc25,
cinnamon-applet-globalappmenu-0.6-1.git20160913.5b55d2d.fc25,
unity-gtk-module-0.0.0+16.10.20160913-1.fc25 has been pushed to the Fedora 25
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382813] Review Request: unity-gtk-module - GTK+ module for exporting old-style menus as GMenuModels

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382813



--- Comment #5 from Fedora Update System  ---
appmenu-qt5-0.3.0+16.10.20160628.1-1.fc25,
cinnamon-applet-globalappmenu-0.6-1.git20160913.5b55d2d.fc25,
unity-gtk-module-0.0.0+16.10.20160913-1.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cda26e7897

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382813] Review Request: unity-gtk-module - GTK+ module for exporting old-style menus as GMenuModels

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382813

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|ON_QA



--- Comment #4 from Fedora Update System  ---
appmenu-qt5-0.3.0+16.10.20160628.1-1.fc24,
cinnamon-applet-globalappmenu-0.6-1.git20160913.5b55d2d.fc24,
unity-gtk-module-0.0.0+16.10.20160913-1.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-aa3eace46c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382813] Review Request: unity-gtk-module - GTK+ module for exporting old-style menus as GMenuModels

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382813



--- Comment #3 from Patrick Uiterwijk  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/unity-gtk-module

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382813] Review Request: unity-gtk-module - GTK+ module for exporting old-style menus as GMenuModels

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382813

Christian Dersch  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Christian Dersch  ---
APPROVED!

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- gtk-query-immodules is invoked when required
  Note: Gtk module file(s) in unity-gtk3-module
  See:
  http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GTK.2B_modules
==> False positive, scriplets are there

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.

===> Unversioned libs are plugins, fine

[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL (v3)", "Unknown or generated". 19 files have unknown
 license. Detailed output of licensecheck in /home/review/1382813
 -unity-gtk-module/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gtk-doc, /usr/share
 /gtk-doc/html, /usr/share/glib-2.0/schemas, /usr/share/glib-2.0

==> Should be fine, checked with other GTK stuff 

[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: glib-compile-schemas is run in %postun and %posttrans if package has
 *.gschema.xml files.
 Note: gschema file(s) in unity-gtk-module-common
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 81920 bytes in 12 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: 

[Bug 1382813] Review Request: unity-gtk-module - GTK+ module for exporting old-style menus as GMenuModels

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382813

Christian Dersch  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||lupi...@mailbox.org
   Assignee|nob...@fedoraproject.org|lupi...@mailbox.org
  Flags||fedora-review?



--- Comment #1 from Christian Dersch  ---
Taken

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382813] Review Request: unity-gtk-module - GTK+ module for exporting old-style menus as GMenuModels

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382813

Björn "besser82" Esser  changed:

   What|Removed |Added

 Blocks||1382810
   ||(cinnamon-applet-globalappm
   ||enu)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1382810
[Bug 1382810] Review Request: cinnamon-applet-globalappmenu - Ubuntu
AppMenu support for Cinnamon Desktop
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382813] Review Request: unity-gtk-module - GTK+ module for exporting old-style menus as GMenuModels

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382813

Björn "besser82" Esser  changed:

   What|Removed |Added

  Alias||unity-gtk-module



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org