[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937



--- Comment #21 from Fedora Update System  ---
python-dominate-2.3.1-1.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-11-03 09:29:30



--- Comment #20 from Fedora Update System  ---
python-dominate-2.3.1-1.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937



--- Comment #19 from Fedora Update System  ---
python-dominate-2.3.1-1.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0c2c0a4de8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #18 from Fedora Update System  ---
python-dominate-2.3.1-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ff90f7c038

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937



--- Comment #17 from Fedora Update System  ---
python-dominate-2.3.1-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0c2c0a4de8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937



--- Comment #16 from Fedora Update System  ---
python-dominate-2.3.1-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ff90f7c038

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937



--- Comment #15 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-dominate

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937

Lumír Balhar  changed:

   What|Removed |Added

   Assignee|mhron...@redhat.com |lbal...@redhat.com
  Flags|fedora-review?  |fedora-review+



--- Comment #14 from Lumír Balhar  ---
Hello.

Thank you. Package looks good to me.

Package approved

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "*No copyright* LGPL (v3 or later)", "GPL (v3)", "Unknown or
 generated". 10 files have unknown license. Detailed output of
 licensecheck in /home/lbalhar/Review/1382937-python-
 dominate/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[-]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-dominate , python3-dominate
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for 

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937



--- Comment #13 from David Hannequin  ---
Hi,

I packaged latest version and fix tests : 

Spec URL:
https://hvad.fedorapeople.org/fedora/python-dominate/python-dominate.spec
SRPM URL:
https://hvad.fedorapeople.org/fedora/python-dominate/python-dominate-2.3.1-1.fc26.src.rpm

Thanks Lumir 

Best regard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937

Lumír Balhar  changed:

   What|Removed |Added

 CC||lbal...@redhat.com



--- Comment #12 from Lumír Balhar  ---
Hello David.

Sorry for the delay. If you still want to package dominate to Fedora, I can
help you and speed up this process.

Dominika and Elliott were right, you should run tests during the build of RPM.
For your package you need to add python2-pytest and python3-pytest as
BuildRequires and change the %check section to `%{__python2} -m pytest tests`
and `%{__python3} -m pytest tests`. And then you will see running tests under
both Pythons.

AFAIK tests were the last issue with this package so after fixing them we can
approve it hopefully.

Have a nice day.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937

Petr Viktorin  changed:

   What|Removed |Added

 CC||pvikt...@redhat.com
   Assignee|dkre...@redhat.com  |mhron...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #11 from Elliott Sales de Andrade  ---
Upstream runs tests on TravisCI, so I'm pretty sure you should be able to get
them working here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937



--- Comment #10 from David Hannequin  ---
Hi,

I packaged latest version :

Spec URL:
https://hvad.fedorapeople.org/fedora/python-dominate/python-dominate.spec
SRPM URL:
https://hvad.fedorapeople.org/fedora/python-dominate/python-dominate-2.3.1-1.fc25.src.rpm

Best regard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937



--- Comment #9 from Dominika Krejčí  ---
[!]: Latest version is packaged.

Could you please package the latest version? 2.3.1 is available.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937



--- Comment #8 from David Hannequin  ---
Any news ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937



--- Comment #7 from David Hannequin  ---
Hi,

New spec file and SRPM :

Spec URL:
https://hvad.fedorapeople.org/fedora/python-dominate/python-dominate.spec
SRPM URL:
https://hvad.fedorapeople.org/fedora/python-dominate/python-dominate-2.2.1-1.fc25.src.rpm

I test with pytest but same way :-(. I think test don't work on this lib. 

Can you anyway accept this lib ?

Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937



--- Comment #6 from David Hannequin  ---
Hi,

I think lib test don't work. Can pass anyway ?

Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937



--- Comment #5 from Dominika Krejčí  ---
Hi David,
I noticed you do not run any test `Ran 0 tests in 0.000s`. You will probably
need to add pytest to BuildRequires and use another command in the check
section.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937



--- Comment #4 from David Hannequin  ---
Hi Dominika,

I'fix issues. 

Thank's for your review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937

Dominika Krejčí  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|dkre...@redhat.com
  Flags||fedora-review?



--- Comment #3 from Dominika Krejčí  ---
Hi David,
here is the formal review. Just to more things. The rest seems fine. ;)

Issues
==
[!]: Changelog in prescribed format. Please change it to this:
* Wed Oct 05 2016 David Hannequin  - 2.2.1-1
- Initial package.

pythonX-dominate.noarch: E: description-line-too-long C Dominate is a Python X
library for creating and manipulating HTML documents using
Put a word "using" on the next line and it will be fine. One line should not be
longer then 80 characters.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-dominate , python3-dominate
[x]: Package functions as described.
[x]: 

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937



--- Comment #2 from David Hannequin  ---
Hello,

* It is better to be more specific and use `python2-setuptools` instead of
`python-setuptools`.

I fix this.

* It is good to indicate in the subpackage description whether it is Python 2
or Python3.

I fix this too.

* Tests are packaged but the %check section is not present.

I add %check but work only with python 2 because pyhon 3 test failed. I'll
report to upstream. 

Could pass anyway for review ? 

Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937

Dominika Krejčí  changed:

   What|Removed |Added

 CC||dkre...@redhat.com



--- Comment #1 from Dominika Krejčí  ---
Hello David, I have some comments:

* It is better to be more specific and use `python2-setuptools` instead of
`python-setuptools`.

* It is good to indicate in the subpackage description whether it is Python 2
or Python3.

* Tests are packaged but the %check section is not present.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937

Igor Gnatenko  changed:

   What|Removed |Added

  Flags|fedora-review?  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937

David Hannequin  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org