[Bug 1385105] Review Request: python-marathon - Python client library/ interface to the Mesos Marathon REST API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385105

Haïkel Guémar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-11-14 05:58:02



--- Comment #10 from Haïkel Guémar  ---
Built in rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385105] Review Request: python-marathon - Python client library/ interface to the Mesos Marathon REST API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385105



--- Comment #9 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-marathon

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385105] Review Request: python-marathon - Python client library/ interface to the Mesos Marathon REST API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385105



--- Comment #8 from David Moreau Simard  ---
Spec URL:
https://raw.githubusercontent.com/dmsimard/python-marathon-distgit/master/python-marathon.spec
SRPM URL:
https://github.com/dmsimard/python-marathon-distgit/raw/master/python-marathon-0.8.7-1.fc24.src.rpm
Description: Python client library/interface to the Mesos Marathon REST API.

Koji scratch build available at
http://koji.fedoraproject.org/koji/taskinfo?taskID=16261092

In this most recent iteration (
https://github.com/dmsimard/python-marathon-distgit/commit/a4e8daa716b7bc47c75ab11e30e8ee91c74dc650
) I've updated the version to 0.8.7 and also addressed concerns about packaging
the license even though it was not in the source tarball.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385105] Review Request: python-marathon - Python client library/ interface to the Mesos Marathon REST API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385105

Chandan Kumar  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Chandan Kumar  ---
The package looks good.
APPROVED.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 21 files have
 unknown license. Detailed output of licensecheck in
 /home/chandankumar/killbox/python/packaging/pkgreview/1385105-python-
 marathon/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-marathon , python3-marathon
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build 

[Bug 1385105] Review Request: python-marathon - Python client library/ interface to the Mesos Marathon REST API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385105



--- Comment #6 from David Moreau Simard  ---
Also, worth mentioning that I've toyed with the idea around also packaging
tests and docs but they are not included in the release tarball.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385105] Review Request: python-marathon - Python client library/ interface to the Mesos Marathon REST API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385105



--- Comment #5 from David Moreau Simard  ---
@Chandan, yes, I did notice the setup.py had extra requirements that were not
expressed in requirements.txt but it looked to me like they were not used.
Thanks for confirming.

I'm not sure what you mean for the LICENSE and README.md file ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385105] Review Request: python-marathon - Python client library/ interface to the Mesos Marathon REST API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385105



--- Comment #4 from Chandan Kumar  ---
Hello David,

After doing git grep sseclient and six, found that sseclient and six is not
required but due to present under install_requires in setup.py
https://github.com/thefactory/marathon-python/blob/master/setup.py#L16 and they
will remove in a new release :
https://github.com/thefactory/marathon-python/pull/143

Sorry for the noise, I will post my final review.

Thanks,

Chandan Kumar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385105] Review Request: python-marathon - Python client library/ interface to the Mesos Marathon REST API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385105

Chandan Kumar  changed:

   What|Removed |Added

 CC||chku...@redhat.com



--- Comment #3 from Chandan Kumar  ---
Hello David,

Thanks for submitting the review.
Below is the few comments:
[1.] Please also include python-six, python-sseclient (Which is not packaged
yet in fedora) as a Requires as they are required by python-marathon.

For more info check this: https://paste.fedoraproject.org/453831/70149814/

[2.] for LICENSE and README.md file Sources, please submit a patch upstream and
put the link in the spec file.

Rest looks ok to me on a first glance.

Thanks,

Chandan Kumar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385105] Review Request: python-marathon - Python client library/ interface to the Mesos Marathon REST API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385105

Chandan Kumar  changed:

   What|Removed |Added

 CC||chkumar...@gmail.com
   Assignee|nob...@fedoraproject.org|chkumar...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385105] Review Request: python-marathon - Python client library/ interface to the Mesos Marathon REST API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385105

Chandan Kumar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385105] Review Request: python-marathon - Python client library/ interface to the Mesos Marathon REST API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385105



--- Comment #2 from David Moreau Simard  ---
Spec URL:
https://raw.githubusercontent.com/dmsimard/python-marathon-distgit/master/python-marathon.spec
SRPM URL:
https://github.com/dmsimard/python-marathon-distgit/raw/master/python-marathon-0.8.6-1.fc24.src.rpm
Description: Python client library/interface to the Mesos Marathon REST API.

Koji scratch build available at
http://koji.fedoraproject.org/koji/taskinfo?taskID=16090465

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385105] Review Request: python-marathon - Python client library/ interface to the Mesos Marathon REST API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385105



--- Comment #1 from David Moreau Simard  ---
Spec URL:
https://raw.githubusercontent.com/dmsimard/python-marathon-distgit/master/python-marathon.spec
SRPM URL:
https://github.com/dmsimard/python-marathon-distgit/raw/master/python-marathon-0.8.6-1.fc24.src.rpm
Description: Python client library/interface to the Mesos Marathon REST API.

Koji scratch build available at
http://koji.fedoraproject.org/koji/taskinfo?taskID=16090283

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385105] Review Request: python-marathon - Python client library/ interface to the Mesos Marathon REST API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385105

David Moreau Simard  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |python-marathon - Python|python-marathon - Python
   |client library/interface to |client library/interface to
   |the Mesos Marathon REST |the Mesos Marathon REST API
   |API.|



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385105] Review Request: python-marathon - Python client library/ interface to the Mesos Marathon REST API.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385105

David Moreau Simard  changed:

   What|Removed |Added

 Blocks||1385086




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1385086
[Bug 1385086] openstack-magnum now requires marathon
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org