[Bug 1416455] Review Request: python-easywatch - super simple directory monitoring

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416455

Athos Ribeiro  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|athoscribe...@gmail.com |nob...@fedoraproject.org
  Flags|fedora-review?  |



--- Comment #5 from Athos Ribeiro  ---
Sorry for the mistake, Fabian. I will just drop this then


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1416455] Review Request: python-easywatch - super simple directory monitoring

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416455

Fabian Affolter  changed:

   What|Removed |Added

 CC|m...@fabian-affolter.ch |
  Flags|needinfo?(mail@fabian-affol |
   |ter.ch) |



--- Comment #4 from Fabian Affolter  ---
(In reply to Athos Ribeiro from comment #3)
> Hi Fabio, still interested on this one?

Hmm, I'm not the reporter.

Looks like that this review is not going on (-> You can't ask Fabio Alessandro
Locati  because that account is disabled.).


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1416455] Review Request: python-easywatch - super simple directory monitoring

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416455

Athos Ribeiro  changed:

   What|Removed |Added

 CC||m...@fabian-affolter.ch
  Flags||needinfo?(mail@fabian-affol
   ||ter.ch)



--- Comment #3 from Athos Ribeiro  ---
Hi Fabio, still interested on this one?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1416455] Review Request: python-easywatch - super simple directory monitoring

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416455

Fabian Affolter  changed:

   What|Removed |Added

 CC||m...@fabian-affolter.ch



--- Comment #2 from Fabian Affolter  ---
0.0.4 was released.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1416455] Review Request: python-easywatch - super simple directory monitoring

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416455



--- Comment #1 from Athos Ribeiro  ---
Hello Fabio,

The summary for the python3 package is the summary of another package. You
could use the summary macro to avoid that.

It would be nice ask upstream to add tags to avoid getting sources from the
commits (of course this is not a blocker).

rpmlint has this warning, would you fix it (not a blocker)?
python2-easywatch.noarch: W: summary-not-capitalized C super simple directory
monitoring


This is the docstring for easywatch/easywatch.py
"""
Simple static page generator.
Uses jinja2 to compile templates.
Templates should live inside `./templates` and will be compiled in '.'.
"""

It would be nice to patch it and send it upstream.

python3 package fails importing watchdog function (see __init__.py), here is
the  error message:

Traceback (most recent call last):
  File "", line 1, in 
  File "/usr/lib/python3.6/site-packages/easywatch/__init__.py", line 1, in

from easywatch import watch
ImportError: cannot import name 'watch'

This happens because __init__.py has a relative import (see
https://www.python.org/dev/peps/pep-0404/). I'd say the package is not python3
compatible yet (probably just because of that import)


Finally, there are Requires: missing, as you can see below:

in easywatch/easywatch.py we have:
from watchdog.observers import Observer
from watchdog.events import FileSystemEventHandler

importing the python2 package results in:
Traceback (most recent call last):
  File "", line 1, in 
ModuleNotFoundError: No module named 'watchdog'

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1416455] Review Request: python-easywatch - super simple directory monitoring

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416455

Athos Ribeiro  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||athoscribe...@gmail.com
   Assignee|nob...@fedoraproject.org|athoscribe...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1416455] Review Request: python-easywatch - super simple directory monitoring

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1416455

Fabio Alessandro Locati  changed:

   What|Removed |Added

 Blocks||1416458




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1416458
[Bug 1416458] Review Request: python-staticjinja - jinja based static site
generator
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org