[Bug 1421046] Review Request: golang-deepin-go-lib - Go bindings for DDE development
https://bugzilla.redhat.com/show_bug.cgi?id=1421046 Bug 1421046 depends on bug 1421063, which changed state. Bug 1421063 Summary: Review Request: deepin-gir-generator - Generate static golang bindings for GObject https://bugzilla.redhat.com/show_bug.cgi?id=1421063 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/Y2SALT45RJBDBK5UUNGVXHKOFKDRCMN5/
[Bug 1421046] Review Request: golang-deepin-go-lib - Go bindings for DDE development
https://bugzilla.redhat.com/show_bug.cgi?id=1421046 Bug 1421046 depends on bug 1480973, which changed state. Bug 1480973 Summary: Review Request: golang-github-alecthomas-kingpin - A Go command line and flag parser https://bugzilla.redhat.com/show_bug.cgi?id=1480973 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/NBORTVALZ7MF25DWMBWBBHPYTMXJ72N4/
[Bug 1421046] Review Request: golang-deepin-go-lib - Go bindings for DDE development
https://bugzilla.redhat.com/show_bug.cgi?id=1421046 Bug 1421046 depends on bug 1480972, which changed state. Bug 1480972 Summary: Review Request: golang-github-BurntSushi-xgbutil - XGB is the X protocol Go language Binding https://bugzilla.redhat.com/show_bug.cgi?id=1480972 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/FM5TE6FAZCWR3FJTFAYFIFWIMONP3TI5/
[Bug 1421046] Review Request: golang-deepin-go-lib - Go bindings for DDE development
https://bugzilla.redhat.com/show_bug.cgi?id=1421046 Zamir SUN changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2018-07-22 09:31:43 --- Comment #13 from Zamir SUN --- This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/UHAASOLF43R5PFHTP2WCSXZDEOAKIQJF/
[Bug 1421046] Review Request: golang-deepin-go-lib - Go bindings for DDE development
https://bugzilla.redhat.com/show_bug.cgi?id=1421046 Zamir SUN changed: What|Removed |Added Alias||golang-deepin-go-lib -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421046] Review Request: golang-deepin-go-lib - Go bindings for DDE development
https://bugzilla.redhat.com/show_bug.cgi?id=1421046 --- Comment #12 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-deepin-go-lib -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421046] Review Request: golang-deepin-go-lib - Go bindings for DDE development
https://bugzilla.redhat.com/show_bug.cgi?id=1421046 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #11 from Robert-André Mauchin --- It's all good for me, package accepted. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421046] Review Request: golang-deepin-go-lib - Go bindings for DDE development
https://bugzilla.redhat.com/show_bug.cgi?id=1421046 --- Comment #10 from sensor@gmail.com --- Diff: https://github.com/FZUG/repo/commit/d8fb40d14bbdc08d96f0ad30a6fc07e17ab73d53 I build pass without failure. Package was updated to 1.1.0, but built not done in Copr. Please see https://copr.fedorainfracloud.org/coprs/mosquito/deepin/build/593683/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421046] Review Request: golang-deepin-go-lib - Go bindings for DDE development
https://bugzilla.redhat.com/show_bug.cgi?id=1421046
--- Comment #9 from Robert-André Mauchin ---
I've got test failures, so I commented them.
#%%gotest %%{import_path}/users/group
#%%gotest %%{import_path}/users/passwd
If you get them too, you should report them upstream.
There's a new release 1.1.0: https://github.com/linuxdeepin/go-lib/releases
Problem is, this new release dropped the dependency to
golang-github-howeyc-fsnotify and deepin forked it locally.
This release also dropped launchpad.net/gocheck and replaced it with
gopkg.in/check.v1
You need to update the BR accordingly:
- remove: BuildRequires: golang(github.com/howeyc/fsnotify) and Requires:
golang(github.com/howeyc/fsnotify)
- change BuildRequires: golang(launchpad.net/gocheck) to BuildRequires:
golang(gopkg.in/check.v1)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421046] Review Request: golang-deepin-go-lib - Go bindings for DDE development
https://bugzilla.redhat.com/show_bug.cgi?id=1421046 --- Comment #8 from sensor@gmail.com --- $ fedrepo-req golang-github-BurntSushi-xgbutil -t 1480972 Error: The Bugzilla ticket is not approved yet golang-github-BurntSushi-xgbutil is not approve. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421046] Review Request: golang-deepin-go-lib - Go bindings for DDE development
https://bugzilla.redhat.com/show_bug.cgi?id=1421046 Robert-André Mauchin changed: What|Removed |Added Status|NEW |ASSIGNED Depends On||1421063, 1480972, 1480973 Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review? --- Comment #7 from Robert-André Mauchin --- Hello, You should rename your spec golang-deepin-go-lib: it should be the same as the name of the package. Missing dependencies: DEBUG util.py:450: No matching package to install: 'deepin-gir-generator' → Bug #1421063 : accepted but not yet built DEBUG util.py:450: No matching package to install: 'golang(github.com/BurntSushi/xgbutil)' → Bug #1480972 : accepted but not yet built DEBUG util.py:450: No matching package to install: 'golang(gopkg.in/alecthomas/kingpin.v2)' → Bug #1480973: nobody's working on it yet Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1421063 [Bug 1421063] Review Request: deepin-gir-generator - Generate static golang bindings for GObject https://bugzilla.redhat.com/show_bug.cgi?id=1480972 [Bug 1480972] Review Request: golang-github-BurntSushi-xgbutil - XGB is the X protocol Go language Binding https://bugzilla.redhat.com/show_bug.cgi?id=1480973 [Bug 1480973] Review Request: golang-github-alecthomas-kingpin - A Go command line and flag parser -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421046] Review Request: golang-deepin-go-lib - Go bindings for DDE development
https://bugzilla.redhat.com/show_bug.cgi?id=1421046 Robert-André Mauchin changed: What|Removed |Added Blocks||1476590 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1476590 [Bug 1476590] Review Request: deepin-daemon - Daemon handling the DDE session settings -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421046] Review Request: golang-deepin-go-lib - Go bindings for DDE development
https://bugzilla.redhat.com/show_bug.cgi?id=1421046 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Blocks||1476583 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1476583 [Bug 1476583] Review Request: startdde - Starter of deepin desktop environment -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421046] Review Request: golang-deepin-go-lib - Go bindings for DDE development
https://bugzilla.redhat.com/show_bug.cgi?id=1421046 --- Comment #6 from sensor@gmail.com --- Diff: https://github.com/FZUG/repo/commit/09b62a0da75d00b9a69b626f6632160a429d1d21 SPEC: https://raw.githubusercontent.com/FZUG/repo/09b62a0da75d00b9a69b626f6632160a429d1d21/rpms/deepin_project/deepin-go-lib.spec Hi Robert I have fixed some problems. If your think it would be ok. I will submit other golang packages for package review. Thanks a lot. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421046] Review Request: golang-deepin-go-lib - Go bindings for DDE development
https://bugzilla.redhat.com/show_bug.cgi?id=1421046
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #5 from Robert-André Mauchin ---
Hello,
I think you should use the gofed script as your basis and not go too far away
from this script.
For example, your Provides should list all the libraries provided by the
package:
Provides: golang(%{import_path}) = %{version}-%{release}
Provides: golang(%{import_path}/app) = %{version}-%{release}
Provides: golang(%{import_path}/appinfo) = %{version}-%{release}
Provides: golang(%{import_path}/appinfo/desktopappinfo) =
%{version}-%{release}
Provides: golang(%{import_path}/arch) = %{version}-%{release}
Provides: golang(%{import_path}/archive) = %{version}-%{release}
Provides: golang(%{import_path}/archive/gzip) = %{version}-%{release}
Provides: golang(%{import_path}/archive/utils) = %{version}-%
and so on. Otherwise golang packages using this library won't be able to find
their dependencies. By the way, this is a problem you have on your other golang
libraries you have on your COPR. If you intend to submit them, I recommend you
to start with the basis of the gofed script and then fix whatever issue
remains.
Also you have no %check for this library. This is highly recommended.
Don't forget to add the various testdata to your unit-test-devel.file-list. For
example:
# pack testdata
for file in $(find */*testdata */*/testdata) ; do
dirprefix=$(dirname $file)
install -d -p %{buildroot}/%{gopath}/src/%{import_path}/$dirprefix
cp -pav $file %{buildroot}/%{gopath}/src/%{import_path}/$file
echo "%%{gopath}/src/%%{import_path}/$file" >> unit-test-devel.file-list
done
You'll some BR for the tests, there are specified in the README.md. Shortlist:
# Required for tests
BuildRequires: dbus-x11
BuildRequires: pkgconfig(gdk-pixbuf-xlib-2.0)
BuildRequires: pkgconfig(libpulse)
BuildRequires: pkgconfig(libcanberra)
BuildRequires: mobile-broadband-provider-info
If some checks fail and you don't know why, best is to report them upstream and
deactivate them with the bugreport url in comment.
This shouldn't be a noarch, you should use the ExclusiveArch for Go:
ExclusiveArch: %{?go_arches:%{go_arches}}%{!?go_arches:%{ix86} x86_64 aarch64
%{arm}}
And BR the right compiler:
BuildRequires: %{?go_compiler:compiler(go-compiler)}%{!?go_compiler:golang}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421046] Review Request: golang-deepin-go-lib - Go bindings for DDE development
https://bugzilla.redhat.com/show_bug.cgi?id=1421046 --- Comment #4 from sensor@gmail.com --- SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00587925-golang-deepin-go-lib/deepin-go-lib.spec SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00587925-golang-deepin-go-lib/golang-deepin-go-lib-1.0.5-2.fc25.src.rpm Back to use golang-github-howeyc-fsnotify package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421046] Review Request: golang-deepin-go-lib - Go bindings for DDE development
https://bugzilla.redhat.com/show_bug.cgi?id=1421046 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Summary|Review Request: |Review Request: |deepin-go-lib - Go bindings |golang-deepin-go-lib - Go |for DDE development |bindings for DDE ||development -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
