[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code
https://bugzilla.redhat.com/show_bug.cgi?id=1421065 Zamir SUN changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed||2018-07-22 09:29:17 --- Comment #13 from Zamir SUN --- This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging effort. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/A3JFGICMOQJUKXR5YUMUVW3MPYABZUA4/
[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code
https://bugzilla.redhat.com/show_bug.cgi?id=1421065 Zamir SUN changed: What|Removed |Added Alias||deepin-qt-dbus-factory -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code
https://bugzilla.redhat.com/show_bug.cgi?id=1421065 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- deepin-qt-dbus-factory-0.3.0-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-35f43291de -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code
https://bugzilla.redhat.com/show_bug.cgi?id=1421065 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code
https://bugzilla.redhat.com/show_bug.cgi?id=1421065 --- Comment #11 from Fedora Update System --- deepin-qt-dbus-factory-0.3.0-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-35f43291de -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code
https://bugzilla.redhat.com/show_bug.cgi?id=1421065 --- Comment #10 from Ralph Bean --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/deepin-qt-dbus-factory -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code
https://bugzilla.redhat.com/show_bug.cgi?id=1421065 --- Comment #9 from Ralph Bean --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/deepin-qt-dbus-factory -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code
https://bugzilla.redhat.com/show_bug.cgi?id=1421065 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|ASSIGNED|POST -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code
https://bugzilla.redhat.com/show_bug.cgi?id=1421065 Robin Lee changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #8 from Robin Lee --- This package is approved by cheeselee. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code
https://bugzilla.redhat.com/show_bug.cgi?id=1421065 --- Comment #7 from sensor@gmail.com --- SPEC: https://raw.githubusercontent.com/FZUG/repo/master/rpms/deepin_project/deepin-qt-dbus-factory.spec Fixed license. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code
https://bugzilla.redhat.com/show_bug.cgi?id=1421065 --- Comment #6 from Robin Lee --- According to licensecheck output, this package should be "GPLv3+ and LGPLv2+" https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios GPL (v3 or later) - dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/types/appupdateinfolist.cpp dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/types/appupdateinfolist.h dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/types/audioport.h dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/types/audioportlist.h dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/types/mirrorinfolist.cpp dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/types/mirrorinfolist.h dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/types/propertylist.cpp dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/types/propertylist.h dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/types/windowlist.cpp dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/types/windowlist.h LGPL (v2.1 or later) dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/qtdbusextended/dbusextended.h dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/qtdbusextended/dbusextendedabstractinterface.cpp dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/qtdbusextended/dbusextendedabstractinterface.h dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/qtdbusextended/dbusextendedpendingcallwatcher.cpp dde-qt-dbus-factory-becf8526235cedac20622e6e1973952c84a14392/libdframeworkdbus/qtdbusextended/dbusextendedpendingcallwatcher_p.h -- And the latest changelog entry version mis-matches. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code
https://bugzilla.redhat.com/show_bug.cgi?id=1421065 --- Comment #5 from sensor@gmail.com --- SPEC: https://raw.githubusercontent.com/FZUG/repo/master/rpms/deepin_project/deepin-qt-dbus-factory.spec It's pretty good. Can i submit it? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code
https://bugzilla.redhat.com/show_bug.cgi?id=1421065 --- Comment #4 from sensor@gmail.com --- -[fix]: no-documentation -[fix]: library-without-ldconfig-postin /usr/lib64/libdframeworkdbus.so.1.0.0 SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-24-x86_64/00582593-deepin-qt-dbus-factory/deepin-qt-dbus-factory.spec SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-24-x86_64/00582593-deepin-qt-dbus-factory/deepin-qt-dbus-factory-0.2.1-1.gitbecf852.fc24.src.rpm Task: https://copr.fedorainfracloud.org/coprs/mosquito/deepin/build/582593/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code
https://bugzilla.redhat.com/show_bug.cgi?id=1421065
--- Comment #3 from Robin Lee ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- ldconfig called in %post and %postun if required.
Note: /sbin/ldconfig not called in deepin-qt-dbus-factory
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "LGPL (v2.1 or v3)", "LGPL (v2.1 or later)", "GPL (v2 or
later)", "GPL (v3 or later)", "Unknown or generated". 110 files have
unknown license. Detailed output of licensecheck in
/home/cheese/Downloads/1421065-deepin-qt-dbus-factory/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in deepin-
qt-dbus-factory-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported N
[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code
https://bugzilla.redhat.com/show_bug.cgi?id=1421065 --- Comment #2 from sensor@gmail.com --- SPEC: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00582127-deepin-qt-dbus-factory/deepin-qt-dbus-factory.spec SRPM: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00582127-deepin-qt-dbus-factory/deepin-qt-dbus-factory-0.2.1-1.gitbecf852.fc25.src.rpm Task: https://copr.fedorainfracloud.org/coprs/mosquito/deepin/build/582127/ I have updated the latest version for this package. Upstream uses two ways to name the same type of package (dde-* and deepin-*). So we need to choose one way for package-naming. 'deepin-*' will be better. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code
https://bugzilla.redhat.com/show_bug.cgi?id=1421065 Robin Lee changed: What|Removed |Added Status|NEW |ASSIGNED CC||robinlee.s...@gmail.com Assignee|nob...@fedoraproject.org|robinlee.s...@gmail.com Flags||fedora-review? --- Comment #1 from Robin Lee --- Please update to the latest version. And since upstream named 'dde-qt-dbus-factory', this package should follow that. And as mentioned in other review, the Spec URL should response the raw text. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code
https://bugzilla.redhat.com/show_bug.cgi?id=1421065 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code
https://bugzilla.redhat.com/show_bug.cgi?id=1421065 Felix Yan changed: What|Removed |Added CC||felixonm...@archlinux.org Blocks||1419330 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1419330 [Bug 1419330] Review Request: deepin-menu - deepin menu service -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code
https://bugzilla.redhat.com/show_bug.cgi?id=1421065 Zamir SUN changed: What|Removed |Added Blocks||1465889 ||(DeepinDEPackageReview) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1465889 [Bug 1465889] Tracking: Deepin Desktop related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1421065] Review Request: deepin-qt-dbus-factory - A repository stores auto-generated Qt5 dbus code
https://bugzilla.redhat.com/show_bug.cgi?id=1421065 sensor@gmail.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
