[Bug 1422123] Review Request: python-pykafka - Full-featured Pure-Python Kafka Client
https://bugzilla.redhat.com/show_bug.cgi?id=1422123 Fedora Update System changed: What|Removed |Added Resolution|CURRENTRELEASE |ERRATA --- Comment #8 from Fedora Update System --- python-pykafka-2.6.0-0.1.dev2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/LMIZJQFFTHP6JQ7FP5CUDNOW754H3SM6/
[Bug 1422123] Review Request: python-pykafka - Full-featured Pure-Python Kafka Client
https://bugzilla.redhat.com/show_bug.cgi?id=1422123 --- Comment #7 from Fedora Update System --- python-pykafka-2.6.0-0.1.dev2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-88e649213a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/XHLYNNWPRZNHPGQQW3DJKPDK7H6ON7IK/
[Bug 1422123] Review Request: python-pykafka - Full-featured Pure-Python Kafka Client
https://bugzilla.redhat.com/show_bug.cgi?id=1422123 --- Comment #6 from Fedora Update System --- python-pykafka-2.6.0-0.1.dev2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-88e649213a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/TUYJQXNFL3GFVXUPBHX3YEXI4VMBGATG/
[Bug 1422123] Review Request: python-pykafka - Full-featured Pure-Python Kafka Client
https://bugzilla.redhat.com/show_bug.cgi?id=1422123 Haïkel Guémar changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2017-08-06 13:18:16 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1422123] Review Request: python-pykafka - Full-featured Pure-Python Kafka Client
https://bugzilla.redhat.com/show_bug.cgi?id=1422123 --- Comment #5 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-pykafka -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1422123] Review Request: python-pykafka - Full-featured Pure-Python Kafka Client
https://bugzilla.redhat.com/show_bug.cgi?id=1422123
Javier Peña changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|needinfo?(jp...@redhat.com) |fedora-review+
--- Comment #4 from Javier Peña ---
Thanks for the update Haïkel, I didn't realize the tarball does not include
documentation.
Here is the fedora-review output.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
(v2.0)". 29 files have unknown license. Detailed output of
licensecheck in /tmp/1422123-python-pykafka/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Macros in Summary, %description expandable at SRPM build time.
Note: Macros in: python2-pykafka (description), python3-pykafka
(description)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Gene
[Bug 1422123] Review Request: python-pykafka - Full-featured Pure-Python Kafka Client
https://bugzilla.redhat.com/show_bug.cgi?id=1422123 Alan Pevec changed: What|Removed |Added CC||ape...@redhat.com --- Comment #3 from Alan Pevec --- > # Note: there's already a python-kafka package which is a separate > # project (kafka-python on pypi) If you are like me wondering just how many Kafka python clients does the world need, here is the justification from the OpenStack upstream: https://review.openstack.org/423400 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1422123] Review Request: python-pykafka - Full-featured Pure-Python Kafka Client
https://bugzilla.redhat.com/show_bug.cgi?id=1422123 Haïkel Guémar changed: What|Removed |Added Flags||needinfo?(jp...@redhat.com) --- Comment #2 from Haïkel Guémar --- 1. ack, removed in latest revision (same links as above) 2. upstream tarball does not include documentation bits so it can't be built. 3. ack, fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1422123] Review Request: python-pykafka - Full-featured Pure-Python Kafka Client
https://bugzilla.redhat.com/show_bug.cgi?id=1422123 Javier Peña changed: What|Removed |Added Status|NEW |ASSIGNED CC||jp...@redhat.com Assignee|nob...@fedoraproject.org|jp...@redhat.com --- Comment #1 from Javier Peña --- I have found a couple things to be fixed in the spec: - There is a .c file under site-packages/pykafka/rdkafka, which I understand should be removed (_rd_kafkamodule.c). - There is no -doc subpackage, and the documentation is not built. - As a minor nit, could you use "cp -p" to ensure timestamps are kept? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1422123] Review Request: python-pykafka - Full-featured Pure-Python Kafka Client
https://bugzilla.redhat.com/show_bug.cgi?id=1422123 Haïkel Guémar changed: What|Removed |Added Blocks||1373513 (RDO-OCATA) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1373513 [Bug 1373513] Tracker: Blockers and Review requests for new RDO Ocata packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
