[Bug 1430147] Review Request: golang-github-mgutz-logxi - A 12-factor app logger built for performance and happy development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430147
Bug 1430147 depends on bug 1430146, which changed state.

Bug 1430146 Summary: Review Request: golang-github-mgutz-ansi - Small, fast 
library to create ANSI colored strings and codes.
https://bugzilla.redhat.com/show_bug.cgi?id=1430146

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |CURRENTRELEASE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430147] Review Request: golang-github-mgutz-logxi - A 12-factor app logger built for performance and happy development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430147

Ed Marshall  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2017-11-20 23:04:52



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430147] Review Request: golang-github-mgutz-logxi - A 12-factor app logger built for performance and happy development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430147



--- Comment #13 from Fedora Update System  ---
golang-github-mgutz-logxi-1-1.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430147] Review Request: golang-github-mgutz-logxi - A 12-factor app logger built for performance and happy development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430147



--- Comment #12 from Fedora Update System  ---
golang-github-mgutz-logxi-1-1.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430147] Review Request: golang-github-mgutz-logxi - A 12-factor app logger built for performance and happy development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430147



--- Comment #11 from Fedora Update System  ---
golang-github-mgutz-logxi-1-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-6fa4e1361a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430147] Review Request: golang-github-mgutz-logxi - A 12-factor app logger built for performance and happy development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430147



--- Comment #10 from Fedora Update System  ---
golang-github-mgutz-logxi-1-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1dbe1eec81

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430147] Review Request: golang-github-mgutz-logxi - A 12-factor app logger built for performance and happy development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430147

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
golang-github-mgutz-logxi-1-1.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-491d3df0cf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430147] Review Request: golang-github-mgutz-logxi - A 12-factor app logger built for performance and happy development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430147



--- Comment #8 from Fedora Update System  ---
golang-github-mgutz-logxi-1-1.el7 has been submitted as an update to Fedora
EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-6fa4e1361a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430147] Review Request: golang-github-mgutz-logxi - A 12-factor app logger built for performance and happy development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430147



--- Comment #7 from Fedora Update System  ---
golang-github-mgutz-logxi-1-1.fc27 has been submitted as an update to Fedora
27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1dbe1eec81

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430147] Review Request: golang-github-mgutz-logxi - A 12-factor app logger built for performance and happy development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430147

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430147] Review Request: golang-github-mgutz-logxi - A 12-factor app logger built for performance and happy development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430147



--- Comment #6 from Fedora Update System  ---
golang-github-mgutz-logxi-1-1.fc26 has been submitted as an update to Fedora
26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-491d3df0cf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430147] Review Request: golang-github-mgutz-logxi - A 12-factor app logger built for performance and happy development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430147



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-mgutz-logxi

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430147] Review Request: golang-github-mgutz-logxi - A 12-factor app logger built for performance and happy development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430147



--- Comment #4 from Ed Marshall  ---
Argh, that's what I get for being in a hurry. Thanks for the catch! (And thanks
so much for all of the reviews!)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430147] Review Request: golang-github-mgutz-logxi - A 12-factor app logger built for performance and happy development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430147

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
The %changelog is wrong, it's version-release, so 1-1, not 1.1:

* Sat Oct 07 2017 Ed Marshall  - 1-1

Package is accepted but please fix this before import.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430147] Review Request: golang-github-mgutz-logxi - A 12-factor app logger built for performance and happy development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430147



--- Comment #2 from Ed Marshall  ---
Spec URL:
https://fedorapeople.org/cgit/logic/public_git/golang-github-mgutz-logxi.git/plain/golang-github-mgutz-logxi.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/5265/22315265/golang-github-mgutz-logxi-1-1.fc28.src.rpm
Description: A 12-factor app logger built for performance and happy development
Fedora Account System Username: logic

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=22315264

(PPC build failure is expected; this has been happening consistently with these
packages, but doesn't happen with real builds.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430147] Review Request: golang-github-mgutz-logxi - A 12-factor app logger built for performance and happy development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430147
Bug 1430147 depends on bug 1376412, which changed state.

Bug 1376412 Summary: Review Request: golang-github-mattn-go-colorable - 
Colorable writer for windows.
https://bugzilla.redhat.com/show_bug.cgi?id=1376412

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430147] Review Request: golang-github-mgutz-logxi - A 12-factor app logger built for performance and happy development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430147
Bug 1430147 depends on bug 1430143, which changed state.

Bug 1430143 Summary: Review Request: golang-github-mattn-go-isatty - isatty for 
Go (golang)
https://bugzilla.redhat.com/show_bug.cgi?id=1430143

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430147] Review Request: golang-github-mgutz-logxi - A 12-factor app logger built for performance and happy development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430147
Bug 1430147 depends on bug 1430143, which changed state.

Bug 1430143 Summary: Review Request: golang-github-mattn-go-isatty - isatty for 
Go (golang)
https://bugzilla.redhat.com/show_bug.cgi?id=1430143

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430147] Review Request: golang-github-mgutz-logxi - A 12-factor app logger built for performance and happy development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430147
Bug 1430147 depends on bug 1430143, which changed state.

Bug 1430143 Summary: Review Request: golang-github-mattn-go-isatty - isatty for 
Go (golang)
https://bugzilla.redhat.com/show_bug.cgi?id=1430143

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430147] Review Request: golang-github-mgutz-logxi - A 12-factor app logger built for performance and happy development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430147

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
Hello, 

 - Please package the version tagged v1:
https://github.com/mgutz/logxi/releases/tag/v1 instead of a development
snapshot.

Version:1
Release:1%{?dist}

   And:

Source0:   
https://%{provider_prefix}/archive/v%{version}/%{repo}-%{version}.tar.gz

  Then:

%setup -q -n %{repo}-%{version}

   And:

* Sat Mar 04 2017 Ed Marshall  - 1-1


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 27 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/golang-github-mgutz-logxi/review-golang-
 github-mgutz-logxi/licensecheck.txt
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gocode/src,
 /usr/share/gocode, /usr/share/gocode/src/github.com
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description 

[Bug 1430147] Review Request: golang-github-mgutz-logxi - A 12-factor app logger built for performance and happy development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430147
Bug 1430147 depends on bug 1430144, which changed state.

Bug 1430144 Summary: Review Request: golang-github-mattn-go-colorable - 
Colorable writer for windows
https://bugzilla.redhat.com/show_bug.cgi?id=1430144

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DUPLICATE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430147] Review Request: golang-github-mgutz-logxi - A 12-factor app logger built for performance and happy development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430147

Robert-André Mauchin  changed:

   What|Removed |Added

 Depends On||1376412




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1376412
[Bug 1376412] Review Request: golang-github-mattn-go-colorable - Colorable
writer for windows.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1430147] Review Request: golang-github-mgutz-logxi - A 12-factor app logger built for performance and happy development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1430147

Ed Marshall  changed:

   What|Removed |Added

 Depends On||1430144, 1430143, 1430146




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1430143
[Bug 1430143] Review Request: golang-github-mattn-go-isatty - isatty for Go
(golang)
https://bugzilla.redhat.com/show_bug.cgi?id=1430144
[Bug 1430144] Review Request: golang-github-mattn-go-colorable - Colorable
writer for windows
https://bugzilla.redhat.com/show_bug.cgi?id=1430146
[Bug 1430146] Review Request: golang-github-mgutz-ansi - Small, fast
library to create ANSI colored strings and codes.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org