[Bug 1434578] Review Request: gtef - GTK+ Text Editor Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434578



--- Comment #13 from Kalev Lember  ---
I've submitted tepl for review as well now,
https://bugzilla.redhat.com/show_bug.cgi?id=1507303

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434578] Review Request: gtef - GTK+ Text Editor Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434578

Kalev Lember  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||gtef-2.0.1-1.fc26
 Resolution|--- |RAWHIDE
Last Closed||2017-10-29 10:01:34



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434578] Review Request: gtef - GTK+ Text Editor Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434578



--- Comment #12 from Kalev Lember  ---
Excellent, thanks for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434578] Review Request: gtef - GTK+ Text Editor Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434578

c72...@yahoo.de changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #11 from c72...@yahoo.de ---
Package OK
Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=21106726

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434578] Review Request: gtef - GTK+ Text Editor Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434578



--- Comment #10 from c72...@yahoo.de ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: gcc
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
# See comment 9 above

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL", "GPL (v3 or later)", "Unknown or generated", "MIT/X11
 (BSD like)", "*No copyright* LGPL", "LGPL (v2.1 or later)", "FSF All
 Permissive". 139 files have unknown license. Detailed output of
 licensecheck in /home/makerpm/fedora-
 review/1434578-gtef/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/share/gir-1.0(gobject-
 introspection-devel, libgee-devel, gtk3-devel, atk-devel, gdk-
 pixbuf2-devel, gspell-devel), /usr/share/gtk-doc(harfbuzz-devel,
 libsecret-devel, gtk-doc, gtkspell3-devel), /usr/share/vala/vapi(vala,
 gspell-devel, gtksourceview3-devel, libgee-devel), /usr/libexec
 /installed-tests(graphene-tests, gdk-pixbuf2-tests, gvfs-tests,
 glib2-tests), /usr/share/installed-tests(gnome-weather-tests,
 libmediaart-tests, eog-tests, dbus-tests, gtk3-tests, cjs-tests,
 evolution-tests, glib2-tests, gvfs-tests, gnome-photos-tests, glib-
 networking-tests, clutter-tests, json-glib-tests, gnome-
 desktop3-tests, gdk-pixbuf2-tests, evolution-data-server-tests, pango-
 tests, gjs-tests), /usr/share/gtk-doc/html(harfbuzz-devel, libsecret-
 devel, gtk-doc, gtkspell3-devel), /usr/lib64/girepository-1.0(gspell,
 libgepub, gnome-autoar, libgee, libzapojit, gsound, libchamplain,
 gobject-introspection, GConf2, vte, libgnome-keyring, libgtop2, gdk-
 pixbuf2, gcr, libxklavier, libgdata, gtk2, gtk3, gnome-bluetooth-libs,
 grilo, gfbgraph, atk, libpeas, vte291, gnome-online-accounts),
 /usr/share/vala(vala, gspell-devel, gtksourceview3-devel, libgee-
 devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.

[Bug 1434578] Review Request: gtef - GTK+ Text Editor Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434578



--- Comment #9 from Kalev Lember  ---
Thanks! I've updated it to 2.0.1.

The gcc BR is not strictly necessary as it's currently included in the default
buildroot, but the packaging guidelines say that this can change over time and
we should not rely on anything else beside RPM being there. Quoting: "You may
assume that enough of an environment exists for RPM to function, to build
packages and execute basic shell scripts, but you should not assume any other
packages are present as RPM dependencies and anything brought into the
buildroot by the build system may change over time."

https://fedoraproject.org/wiki/Packaging:Guidelines#Build-Time_Dependencies_.28BuildRequires.29

Spec URL: https://kalev.fedorapeople.org/gtef.spec
SRPM URL: http://kalev.fedorapeople.org/gtef-2.0.1-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434578] Review Request: gtef - GTK+ Text Editor Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434578



--- Comment #8 from c72...@yahoo.de ---
Some initial review comments:
- This BR is not needed: gcc
http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

- The last released version of gtef was 2.0.1 before the rename to Tepl.
Please update spec and src.rpm to this version
https://download.gnome.org/sources/gtef/2.0/gtef-2.0.1.tar.xz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434578] Review Request: gtef - GTK+ Text Editor Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434578

c72...@yahoo.de changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|c72...@yahoo.de
  Flags||fedora-review?



--- Comment #7 from c72...@yahoo.de ---
Taking this review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434578] Review Request: gtef - GTK+ Text Editor Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434578



--- Comment #6 from c72...@yahoo.de ---
"LaTeXila follows the GNOME versions". With the motivation:
It is easier to know with which GNOME version a certain LaTeXila version was
developed against.
https://wiki.gnome.org/Apps/LaTeXila/History

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434578] Review Request: gtef - GTK+ Text Editor Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434578



--- Comment #5 from Kalev Lember  ---
Fedora 26 has GNOME 3.24 and to match this we'll need to put latexila 3.24.x
there which in turn requires gtef.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434578] Review Request: gtef - GTK+ Text Editor Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434578



--- Comment #4 from c72...@yahoo.de ---
Additional info:
The requirements for LaTeXila Release 3.25.1 are fulfilled in F26.
e.g. GtkSourceView >= 3.24
Compilation tests with LaTeXila 3.25.1 and Tepl 2.99.2 under F26 have been OK.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434578] Review Request: gtef - GTK+ Text Editor Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434578



--- Comment #3 from c72...@yahoo.de ---
LaTeXila has switched from Gtef to Tepl in Release 3.25.1
https://git.gnome.org/browse/latexila/tree/NEWS

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434578] Review Request: gtef - GTK+ Text Editor Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434578



--- Comment #2 from Kalev Lember  ---
Right. We still need gtef though to get latexila updated in F26.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434578] Review Request: gtef - GTK+ Text Editor Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434578

c72...@yahoo.de changed:

   What|Removed |Added

 CC||c72...@yahoo.de



--- Comment #1 from c72...@yahoo.de ---
The program has been renamed to Tepl in the meantime.
https://wiki.gnome.org/Projects/Tepl
https://download.gnome.org/sources/tepl/
The current version is 2.99

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org