[Bug 1469009] Review Request: odcs - On Demand Compose Service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469009

Igor Gnatenko  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-07-23 04:41:36



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469009] Review Request: odcs - On Demand Compose Service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469009



--- Comment #8 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/odcs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469009] Review Request: odcs - On Demand Compose Service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469009



--- Comment #7 from Jan Kaluža  ---
Thanks for the review, Igor :).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469009] Review Request: odcs - On Demand Compose Service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469009

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags||fedora-review+



--- Comment #6 from Igor Gnatenko  ---
Nothing I can complain about ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469009] Review Request: odcs - On Demand Compose Service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469009



--- Comment #5 from Jan Kaluža  ---
Thanks Igor, updated package is here:

Spec URL: http://jkaluza.fedorapeople.org/odcs.spec
SRPM URL: http://jkaluza.fedorapeople.org/odcs-0.0.3-3.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469009] Review Request: odcs - On Demand Compose Service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469009



--- Comment #4 from Igor Gnatenko  ---
Looks good apart from few things:

- a lot of python- prefixed packages, must be using python2- prefix if
available (six, sqlalchemy, pyopenssl are definitely available in that variant)
- add `-p` flag for installing files to preserve timestamp
- BuildRequires:git, do you really need git for building? if yes, isn't
git-core sufficient?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469009] Review Request: odcs - On Demand Compose Service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469009

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ignate...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469009] Review Request: odcs - On Demand Compose Service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469009



--- Comment #3 from Jan Kaluža  ---
Updated package:

Spec URL: http://jkaluza.fedorapeople.org/odcs.spec
SRPM URL: http://jkaluza.fedorapeople.org/odcs-0.0.3-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469009] Review Request: odcs - On Demand Compose Service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469009



--- Comment #2 from Qixiang Wan  ---
I had another check on the packages list, some of the python-* packages are
named as python2-* from Fedora 26, since Fedora 26 is not GA yet, I think we
can keep it as now and update if we find problem with Fedora 26 after GA. The
only one exception is python-futures which is available with python2-futures
from Fedora 24.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469009] Review Request: odcs - On Demand Compose Service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469009

Qixiang Wan  changed:

   What|Removed |Added

 CC||q...@redhat.com



--- Comment #1 from Qixiang Wan  ---
You may want to update some python- prefix packages as comments in
https://bugzilla.redhat.com/show_bug.cgi?id=1468971. I'll check all these
packages and update to you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org