[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475962



--- Comment #14 from Robert-André Mauchin  ---
Thank you for your review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475962

Antonio Trande  changed:

   What|Removed |Added

 CC|anto.tra...@gmail.com   |
  Flags|fedora-review?  |fedora-review+



--- Comment #13 from Antonio Trande  ---
(In reply to Robert-André Mauchin from comment #11)
> It's a MIT type license. More close to a BSD Clause 3 with the no
> advertising part.

Okay.
Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475962



--- Comment #12 from Robert-André Mauchin  ---
See
https://fedoraproject.org/wiki/Licensing:MIT#Old_Style_with_legal_disclaimer 
It's the same text.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475962



--- Comment #11 from Robert-André Mauchin  ---
It's a MIT type license. More close to a BSD Clause 3 with the no advertising
part.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475962

Antonio Trande  changed:

   What|Removed |Added

 Blocks||182235 (FE-Legal)



--- Comment #10 from Antonio Trande  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

NTP license looks not listed among that 'Good for Fedora'
(https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Software_License_List)
Need Fedora-Legal review.

/* 
 * Copyright © 2008-2011 Kristian Høgsberg
 * Copyright © 2010-2011 Intel Corporation
 * 
 * Permission to use, copy, modify, distribute, and sell this
 * software and its documentation for any purpose is hereby granted
 * without fee, provided that\n the above copyright notice appear in
 * all copies and that both that copyright notice and this permission
 * notice appear in supporting documentation, and that the name of
 * the copyright holders not be used in advertising or publicity
 * pertaining to distribution of the software without specific,
 * written prior permission.  The copyright holders make no
 * representations about the suitability of this software for any
 * purpose.  It is provided "as is" without express or implied
 * warranty.
 * 
 * THE COPYRIGHT HOLDERS DISCLAIM ALL WARRANTIES WITH REGARD TO THIS
 * SOFTWARE, INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND
 * FITNESS, IN NO EVENT SHALL THE COPYRIGHT HOLDERS BE LIABLE FOR ANY
 * SPECIAL, INDIRECT OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
 * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN
 * AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION,
 * ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF
 * THIS SOFTWARE.
 */

However, source files released with NTP are not involved during compilation and
we don't need list it with License tag.

- Please, Make must be verbose; add V=1 to %make_build


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (unspecified)", "BSD (3 clause)", "NTP (legal
 disclaimer)", "Unknown or generated". 193 files have unknown license.
 Detailed output of licensecheck in /home/sagitter/1475962-libva-intel-
 hybrid-driver/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other 

[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475962



--- Comment #9 from Robert-André Mauchin  ---
Updated with recommendations from Nicolas.

SPEC URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/libva-intel-hybrid-driver/fedora-rawhide-x86_64/00591499-libva-intel-hybrid-driver/libva-intel-hybrid-driver.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/libva-intel-hybrid-driver/fedora-rawhide-x86_64/00591499-libva-intel-hybrid-driver/libva-intel-hybrid-driver-1.0.2-4.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475962



--- Comment #8 from Robert-André Mauchin  ---
>What do you mean by libva-intel-driver needs an update ?

You need to flip a switch in the build process:

%configure --disable-static --enable-hybrid-codec

cf my copr
https://copr-be.cloud.fedoraproject.org/results/eclipseo/libva-intel-hybrid-driver/fedora-rawhide-x86_64/00581414-libva-intel-driver/libva-intel-driver.spec

There's no need to add a dependecy to this package, but a Recommends would be
nice I guess.

>Is there a package for pkgconfig(libcmrt) ?

Yes I packaged it https://src.fedoraproject.org/rpms/cmrt


>You need to remove the %post/%postun ldconfig calls, the library is meant to 
>be dlopened.

Okay

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475962



--- Comment #7 from Nicolas Chauvet (kwizart)  ---
Not available "from" the system linker (sorry for the typo).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475962



--- Comment #6 from Nicolas Chauvet (kwizart)  ---
You need to remove the %post/%postun ldconfig calls, the library is meant to be
dlopened. So not available wrong from the system linker.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475962

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

 CC||kwiz...@gmail.com



--- Comment #5 from Nicolas Chauvet (kwizart)  ---
@Robert-André
What do you mean by libva-intel-driver needs an update ?
Is this package usable without libva-intel-driver ?

I also wonder if this is still maintained ?

Is there a package for pkgconfig(libcmrt) ?

Can you provide an output of vainfo with this package installed ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475962

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475962



--- Comment #4 from Robert-André Mauchin  ---
Fixed the issues. Thanks for your review!

SPEC URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/libva-intel-hybrid-driver/fedora-rawhide-x86_64/00591481-libva-intel-hybrid-driver/libva-intel-hybrid-driver.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/libva-intel-hybrid-driver/fedora-rawhide-x86_64/00591481-libva-intel-hybrid-driver/libva-intel-hybrid-driver-1.0.2-3.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475962

c72...@yahoo.de changed:

   What|Removed |Added

 CC||c72...@yahoo.de



--- Comment #3 from c72...@yahoo.de ---
Here are some comments concerning the spec file:

- license: Please check the license, see lisensecheck.txt from fedora-review
for details
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (unspecified)", "BSD (3 clause)", "NTP (legal
 disclaimer)", "Unknown or generated". 193 files have unknown license.
 Detailed output of licensecheck in
 1475962-libva-intel-hybrid-driver/licensecheck.txt
- Comment about patch0, what it does
- A file like AUTHORS is usually under %doc, not %license
- Please add an empty line after each changelog entry

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475962



--- Comment #2 from Robert-André Mauchin  ---
SPEC URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/libva-intel-hybrid-driver/fedora-rawhide-x86_64/00586995-libva-intel-hybrid-driver/libva-intel-hybrid-driver.spec
SRpM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/libva-intel-hybrid-driver/fedora-rawhide-x86_64/00586995-libva-intel-hybrid-driver/libva-intel-hybrid-driver-1.0.2-3.fc27.src.rpm

FAS username: eclipseo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475962

Antonio Trande  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475962

Antonio Trande  changed:

   What|Removed |Added

 CC||anto.tra...@gmail.com
 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475962



--- Comment #1 from Robert-André Mauchin  ---
Added a few syntaxic fixes.

SPEC:
https://github.com/eclipseo/packaging/blob/359e8f0/libva-intel-hybrid-driver.spec
SRPM:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/libva-intel-hybrid-driver/fedora-rawhide-x86_64/00586995-libva-intel-hybrid-driver/libva-intel-hybrid-driver-1.0.2-3.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475962

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1475962] Review Request: intel-hybrid-driver - VA driver for Intel G45 & HD Graphics family

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1475962

Robert-André Mauchin  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org