[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1479027 --- Comment #21 from Elliott Sales de Andrade --- *** Bug 1246593 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this

[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1479027 Zamir SUN changed: What|Removed |Added CC||szts...@gmail.com

[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1479027 Athos Ribeiro changed: What|Removed |Added Status|NEW |CLOSED

[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1479027 --- Comment #20 from Athos Ribeiro --- I was waiting for a reply on the golang go-nuts mailing list [1] on the license of some files in the source package to proceed with the build. Fortunately, the reply came

[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1479027 --- Comment #19 from Robert-André Mauchin --- Hey Athos, could you build this package in Koji now that it is accepted, it is needed for building another package. -- You are receiving this mail because: You are on the CC

[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1479027 --- Comment #18 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-golang-image -- You are receiving this mail because: You are on the CC

[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1479027 --- Comment #17 from Athos Ribeiro --- Thank you for the review, Fabio! I will request the repository and wait for the confirmation on the licensing issie before importing the package. I will wait until then to

[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1479027 Fabio Valentini changed: What|Removed |Added Flags|fedora-review? |fedora-review+

[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1479027 --- Comment #15 from Athos Ribeiro --- Oh, sorry for that! I messed up the links. Spec URL: https://athoscr.fedorapeople.org/packaging/golang-github-golang-image.spec SRPM URL:

[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1479027 --- Comment #14 from Fabio Valentini --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === - Package does not contain

[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1479027 --- Comment #13 from Athos Ribeiro --- (In reply to Robert-André Mauchin (afk until next Thu) from comment #12) > You need to install the updated go-srpm-macros from rawhide, then regenerate > your SRPM before you do

[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1479027 Robert-André Mauchin (afk until next Thu) changed: What|Removed |Added CC|

[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1479027 --- Comment #11 from Athos Ribeiro --- (In reply to Fabio Valentini from comment #10) > 1) There are some minor typos / spelling errors which you might want to > correct (line 44: provite->provide, line 275:

[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1479027 --- Comment #10 from Fabio Valentini --- Initial comments: 1) There are some minor typos / spelling errors which you might want to correct (line 44: provite->provide, line 275: skiping-> skipping). 2) Since you are

[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1479027 Athos Ribeiro changed: What|Removed |Added Blocks||1465889

[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1479027 --- Comment #8 from Fabio Valentini --- I'll look at it again right now! By the way, is this (https://bugzilla.redhat.com/show_bug.cgi?id=1480969) a review request for the same go library? If so, you might tell them

[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1479027 --- Comment #7 from Athos Ribeiro --- I opened an issue upstream [1] and am skipping the failing tests for now. Spec URL: https://athoscr.fedorapeople.org/packaging/golang-github-golang-image.spec SRPM URL:

[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1479027 --- Comment #6 from Athos Ribeiro --- We have 3 architectures with failing tests here: - ppc64 - ppc64le - s390x The issue with ppc64 in known, since there's no compiler(go-compiler) for that anymore. Although I am

[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1479027 --- Comment #5 from Fabio Valentini --- The package builds on rawhide now, but the tests fail on 50% of architectures. see: https://koji.fedoraproject.org/koji/taskinfo?taskID=21239167 -- You are receiving this mail

[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1479027 Jan Chaloupka changed: What|Removed |Added CC|

[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1479027 --- Comment #3 from Athos Ribeiro --- Just created the PR in golang-googlecode-text [1]. [1] https://src.fedoraproject.org/rpms/golang-googlecode-text/pull-request/1 -- You are receiving this mail because: You are

[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1479027 --- Comment #2 from Athos Ribeiro --- Sure! I will send the pull requests for the necessary updates later this week, would do it today, but it seems part of our infra is down Thanks for taking this review as well!

[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1479027 Fabio Valentini changed: What|Removed |Added CC|

[Bug 1479027] Review Request: golang-github-golang-image - Go supplementary image libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1479027 Athos Ribeiro changed: What|Removed |Added Blocks||1426972