[Bug 1491456] Review Request: hatch - A modern project, package, and virtual env manager for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491456



--- Comment #9 from Fedora Update System  ---
hatch-0.11.0-1.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491456] Review Request: hatch - A modern project, package, and virtual env manager for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491456

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-09-24 20:51:53



--- Comment #8 from Fedora Update System  ---
hatch-0.11.0-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491456] Review Request: hatch - A modern project, package, and virtual env manager for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491456



--- Comment #7 from Fedora Update System  ---
hatch-0.11.0-1.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5489417b3a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491456] Review Request: hatch - A modern project, package, and virtual env manager for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491456

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
hatch-0.11.0-1.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1fef6c00ec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491456] Review Request: hatch - A modern project, package, and virtual env manager for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491456



--- Comment #5 from Fedora Update System  ---
hatch-0.11.0-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5489417b3a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491456] Review Request: hatch - A modern project, package, and virtual env manager for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491456

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491456] Review Request: hatch - A modern project, package, and virtual env manager for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491456



--- Comment #4 from Fedora Update System  ---
hatch-0.11.0-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1fef6c00ec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491456] Review Request: hatch - A modern project, package, and virtual env manager for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491456



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/hatch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491456] Review Request: hatch - A modern project, package, and virtual env manager for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491456



--- Comment #2 from Lumír Balhar  ---
Thank you very much. 

Yes, you are right, git-core is enough.

I also sent your suggestion related to test directory to upstream developer:
https://github.com/ofek/hatch/issues/13#issuecomment-329304145

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1491456] Review Request: hatch - A modern project, package, and virtual env manager for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1491456

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review+



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
You should talk with upstream to move tests/ to be a subdirectory of the main
module, and keep the tests installed. Users might want to check the installed
package too (e.g. to see if everything still works in the installed system).

+ package name is OK (it's a python module, but primarily an application).
+ license is acceptable for Fedora
+ license is specified correctly
+ BR / R / P are OK (except one nitpick, see below)
+ modern python packaging template is used
+ %python_provide is used
+ python3 is used
+ %check is present and passes
+ no scriptlets are necessary
+ %license is used

You have BR: git. If you don't need a full-blown installation, git-core might
be better, it provides the more-commonly used tools and has a smaller set of
dependencies.

You might want to extend the %description a bit, to provide a more precise
description of what hatch does and how.

Rpmlint
---
Checking: hatch-0.11.0-1.fc28.noarch.rpm
  hatch-0.11.0-1.fc28.src.rpm
hatch.noarch: W: spelling-error Summary(en_US) env -> enc, en, envy
hatch.noarch: W: spelling-error %description -l en_US workflow -> work flow,
work-flow, workforce
hatch.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/hatch/README.rst
hatch.noarch: W: no-manual-page-for-binary hatch
hatch.src: W: spelling-error Summary(en_US) env -> enc, en, envy
hatch.src: W: spelling-error %description -l en_US workflow -> work flow,
work-flow, workforce
2 packages and 0 specfiles checked; 0 errors, 6 warnings.
All OK.

Rpmlint (installed packages)

hatch.noarch: W: spelling-error Summary(en_US) env -> enc, en, envy
hatch.noarch: W: spelling-error %description -l en_US workflow -> work flow,
work-flow, workforce
hatch.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/hatch/README.rst
hatch.noarch: W: no-manual-page-for-binary hatch
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
All OK.

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org