needinfo canceled: [Bug 1494915] Review Request: libreoffice-online - LibreOffice Online Web Socket Daemon

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Christian Glombek  has canceled Package Review
's request for Christian Glombek
's needinfo:
Bug 1494915: Review Request: libreoffice-online - LibreOffice Online Web Socket
Daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1494915
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1494915] Review Request: libreoffice-online - LibreOffice Online Web Socket Daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1494915

Christian Glombek  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
  Flags|needinfo?(cglombek@redhat.c |
   |om) |
Last Closed||2020-08-19 15:47:02




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1494915] Review Request: libreoffice-online - LibreOffice Online Web Socket Daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1494915

Damian Wrobel  changed:

   What|Removed |Added

 CC||dwro...@ertelnet.rybnik.pl



--- Comment #8 from Damian Wrobel  ---
Please consider to move:

CXXFLAGS="%{optflags} -Wno-error"

from [1] to %configure.

[1]
https://github.com/LorbusChris/libreoffice-online-rpm/blob/master/libreoffice-online.spec#L46

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1494915] Review Request: libreoffice-online - LibreOffice Online Web Socket Daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1494915

Robert Scheck  changed:

   What|Removed |Added

 CC||redhat-bugzilla@linuxnetz.d
   ||e



--- Comment #7 from Robert Scheck  ---
The %post section IMHO looks very dubious, my thoughts and suggestions:

 - http://rpm.org/wiki/Releases/4.7.0#POSIX.1edraft15filecapabilities says
   there is %caps() meanwhile, thus no need for direct setcap calls, I would
   guess.
 - Why is %{_localstatedir}/cache/loolwsd created and owned rather using
   %attr(750, lool, lool) %{_localstatedir}/cache/loolwsd in %files?
 - Why is %{_localstatedir}/cache/loolwsd/* removed in %post? That maybe
   should be documented inside of the spec file...if really needed.
 - Why does loolwsd need a directory on the same filesystem like LibreOffice?
   And shouldn't something like this (if really needed) either go to a
   systemd unit file as ExecStartPre or just get part of %files? There is no 
   documented reason why it has to be on the same filesystem...or?

Could you add bugzilla "depends on" for the missing nodejs dependencies (if
there are meanwhile individual review requests) so that somebody can easily
see which dependencies are missing?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/7VRB5B7BW2DRZI5W2HQIIPW56YM6U7JO/

[Bug 1494915] Review Request: libreoffice-online - LibreOffice Online Web Socket Daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1494915



--- Comment #6 from Christian Glombek  ---
I patched the build to not use env.
(Upstream PR has been submitted here:
https://gerrit.libreoffice.org/#/c/49097/)

https://github.com/LorbusChris/libreoffice-online-rpm/blob/master/libreoffice-online.spec


Unfortunately there's still quite a few nodejs deps missing, especially
browserify, which by itself already has lots of unpackackged deps..
I've begun to package them and will create individual Review Requests for them.
Could be a little while.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1494915] Review Request: libreoffice-online - LibreOffice Online Web Socket Daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1494915



--- Comment #5 from Iwicki Artur  ---
Quite a lot of stuff that's available from npm is available in Fedora repos as
'nodejs-*' packages. There's a chance that we might be already packaging all
the needed dependencies, though using this will probably mean you need to patch
the Makefile accordingly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1494915] Review Request: libreoffice-online - LibreOffice Online Web Socket Daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1494915



--- Comment #4 from Christian Glombek  ---
One more thing that probably needs to be adressed before getting this into
Fedora:
The loleaflet part of the build invokes `npm install` in the build.
This isn't allowed in Fedora. There is a npm-shrinkwrap file for versioning the
deps.

Does anybody know of a good way to source these deps?

Maybe
add an individual source file for each of them 
or
`npm install` locally beforehand and tar node_modules to put it in one source
file?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1494915] Review Request: libreoffice-online - LibreOffice Online Web Socket Daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1494915



--- Comment #3 from Christian Glombek  ---
Thanks for the review, it's highly appreciated!

Do you have any ideas how to do the build without the env var?
My idea would be to patch the configure and make files so that configure
recognizes a --building-from-rpmbuild flag (or similar) instead of the makefile
using the env var.

Does that sound about right to you or do you see an easier way of doing it?

The other issues mentioned will be adressed shortly!
Cheers, Chris

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1494915] Review Request: libreoffice-online - LibreOffice Online Web Socket Daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1494915

Iwicki Artur  changed:

   What|Removed |Added

 CC||fed...@svgames.pl



--- Comment #2 from Iwicki Artur  ---
>env BUILDING_FROM_RPMBUILD=yes make ...
I believe using /bin/env inside spec files is discouraged.

>%__install -D -m 444 loolwsd.service %{buildroot}%{_unitdir}/loolwsd.service
>install -d -m 755 %{buildroot}%{_localstatedir}/adm/fillup-templates
Why the mix of "install" and "%__install"? Non-macro forms of system
executables are preferred.

As for "%{buildroot}%{_sysconfdir}/cron.d/loolwsd.cron", I think it'd be
cleaner to use cat and a heredoc to create the file:
>cat > output_file Line 2 of file.
>EOF
You could, alternatively, just create said file and add it as Source1.

>%{_datadir}/%{name}/favicon.ico
>%{_datadir}/%{name}/discovery.xml
>%{_datadir}/%{name}/robots.txt
>%{_datadir}/%{name}/loleaflet/*
This makes the package own the files inside %{_datadir}/%{name}, but the
directory itself is unowned.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1494915] Review Request: libreoffice-online - LibreOffice Online Web Socket Daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1494915



--- Comment #1 from Christian Glombek  ---
Version 5.4.2.2 has been released. I have updated the spec accordingly.

SPEC:
https://github.com/LorbusChris/libreoffice-online-rpm/blob/master/libreoffice-online.spec

COPRs:
https://copr.fedorainfracloud.org/coprs/lorbus/libreoffice-online/monitor/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1494915] Review Request: libreoffice-online - LibreOffice Online Web Socket Daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1494915

Christian Glombek  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |libreoffice-online -|libreoffice-online -
   |LibreOffice Online Web  |LibreOffice Online Web
   |Services Daemon |Socket Daemon



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org