[Bug 1502016] Review Request: deepin-picker - color picker tool for Deepin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502016

Zamir SUN  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-07-22 09:32:17



--- Comment #6 from Zamir SUN  ---
This is already in Rawhide. Closing on behalf of the Deepin Desktop packaging
effort.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/4VW2XNNXLFS5UBCNK7O7MH4FPVCZRU5F/

[Bug 1502016] Review Request: deepin-picker - color picker tool for Deepin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502016

Zamir SUN  changed:

   What|Removed |Added

 CC||szts...@gmail.com
  Alias||deepin-picker



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502016] Review Request: deepin-picker - color picker tool for Deepin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502016



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/deepin-picker

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502016] Review Request: deepin-picker - color picker tool for Deepin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502016

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Robert-André Mauchin  ---
All ok, package accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502016] Review Request: deepin-picker - color picker tool for Deepin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502016



--- Comment #3 from sensor@gmail.com ---
https://koji.fedoraproject.org/koji/taskinfo?taskID=22440296

Thank you for your work. I fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502016] Review Request: deepin-picker - color picker tool for Deepin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502016

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #2 from Robert-André Mauchin  ---
Hello mosquito,

 - update-desktop-database is not needed anymore in Fedora 25 or later. See
https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets=481889#desktop-database

  Just use:

%post
/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :

%postun
if [ $1 -eq 0 ] ; then
/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null
/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
fi

%posttrans
/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :

 - I don't think this dependency should be so strict:

BuildRequires:  pkgconfig(dtkwidget) = 2.0

Maybe use >=.

 - You must validate the .desktop file:

desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop

 - You must add the followinq Require for icons:

Requires:   hicolor-icon-theme

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502016] Review Request: deepin-picker - color picker tool for Deepin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502016



--- Comment #1 from sensor@gmail.com ---
Today, Deepin have a new little project. Could you have free time to review it?
@zebob

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1502016] Review Request: deepin-picker - color picker tool for Deepin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1502016

sensor@gmail.com changed:

   What|Removed |Added

 Blocks||1465889
   ||(DeepinDEPackageReview)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1465889
[Bug 1465889] Tracking: Deepin Desktop related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org