[Bug 1536878] Review Request: elementary-wallpapers - Collection of wallpapers from the elementary project

2018-03-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1536878



--- Comment #19 from Fedora Update System  ---
elementary-wallpapers-5.0-1.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1536878] Review Request: elementary-wallpapers - Collection of wallpapers from the elementary project

2018-03-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1536878

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-03-13 13:17:34



--- Comment #18 from Fedora Update System  ---
elementary-wallpapers-5.0-1.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1536878] Review Request: elementary-wallpapers - Collection of wallpapers from the elementary project

2018-03-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1536878



--- Comment #17 from Fedora Update System  ---
elementary-wallpapers-5.0-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8d9b8c0de1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1536878] Review Request: elementary-wallpapers - Collection of wallpapers from the elementary project

2018-03-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1536878

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #16 from Fedora Update System  ---
elementary-wallpapers-5.0-1.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-5f23d17015

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1536878] Review Request: elementary-wallpapers - Collection of wallpapers from the elementary project

2018-03-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1536878



--- Comment #15 from Fedora Update System  ---
elementary-wallpapers-5.0-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-5f23d17015

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1536878] Review Request: elementary-wallpapers - Collection of wallpapers from the elementary project

2018-03-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1536878



--- Comment #14 from Fedora Update System  ---
elementary-wallpapers-5.0-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8d9b8c0de1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1536878] Review Request: elementary-wallpapers - Collection of wallpapers from the elementary project

2018-03-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1536878

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1536878] Review Request: elementary-wallpapers - Collection of wallpapers from the elementary project

2018-03-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1536878



--- Comment #13 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/elementary-wallpapers

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1536878] Review Request: elementary-wallpapers - Collection of wallpapers from the elementary project

2018-03-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1536878

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #12 from Neal Gompa  ---
Review notes:

* Package is named appropriately
* Package installs cleanly, properly replacing pandora-wallpapers
* Package follows Packaging Guidelines
* Package licensing information is correct and properly included

PACKAGE APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1536878] Review Request: elementary-wallpapers - Collection of wallpapers from the elementary project

2018-03-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1536878



--- Comment #11 from Fabio Valentini  ---
Updated for the new tag:

Spec URL:
https://decathorpe.fedorapeople.org/packages/elementary-wallpapers.spec
SRPM URL:
https://decathorpe.fedorapeople.org/packages/elementary-wallpapers-5.0-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1536878] Review Request: elementary-wallpapers - Collection of wallpapers from the elementary project

2018-03-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1536878



--- Comment #10 from Neal Gompa  ---
There's now an upstream release tagged:
https://github.com/elementary/wallpapers/releases/tag/5.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1536878] Review Request: elementary-wallpapers - Collection of wallpapers from the elementary project

2018-03-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1536878



--- Comment #9 from Fabio Valentini  ---
Upstream has been "considering" tagging a version since Feb 7, so I'm not sure
how to proceed here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1536878] Review Request: elementary-wallpapers - Collection of wallpapers from the elementary project

2018-02-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1536878



--- Comment #8 from Neal Gompa  ---
> - bug upstream to tag a version > 0.1.8

Do this. This should be easier to resolve. They should be doing this anyway
since they have Debian packaging integrated in the repository...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1536878] Review Request: elementary-wallpapers - Collection of wallpapers from the elementary project

2018-02-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1536878



--- Comment #7 from Fabio Valentini  ---
Well ... I think the easiest solution would be to either
- bug upstream to tag a version > 0.1.8
- use Epoch: 1 in this package?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1536878] Review Request: elementary-wallpapers - Collection of wallpapers from the elementary project

2018-02-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1536878



--- Comment #6 from Neal Gompa  ---
The problem is that you previously defined elementary-wallpapers as %version in
pandora-wallpapers.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1536878] Review Request: elementary-wallpapers - Collection of wallpapers from the elementary project

2018-02-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1536878



--- Comment #5 from Fabio Valentini  ---
That doesn't work, because Epoch isn't defined:

warning: line 35: Possible unexpanded macro in: Requires:  
elementary-wallpapers = %{epoch}:0-0.1.20171230.git4f5b8e4.fc27

error: line 35: Invalid version (epoch must be unsigned integer):
%{epoch}:0-0.1.20171230.git4f5b8e4.fc27: Requires:   elementary-wallpapers
= %{epoch}:0-0.1.20171230.git4f5b8e4.fc27

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1536878] Review Request: elementary-wallpapers - Collection of wallpapers from the elementary project

2018-02-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1536878



--- Comment #4 from Neal Gompa  ---
The gnome subpackage needs %epoch in the Requires line, such that:

Requires: %{name} = %{epoch}:%{version}-%{release}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1536878] Review Request: elementary-wallpapers - Collection of wallpapers from the elementary project

2018-02-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1536878



--- Comment #3 from Fabio Valentini  ---
Fixed, same links.

Also, please verify that the Provides/Obsoletes are right - since this is
required by the package renaming guidelines.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1536878] Review Request: elementary-wallpapers - Collection of wallpapers from the elementary project

2018-02-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1536878



--- Comment #2 from Neal Gompa  ---
Review notes:

[x] Package name looks good
[x] Content is installed correctly
[x] Licensing is correct
[!] License file is missing

Please add the license file (in this case, debian/copyright) as %license in the
files section.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org


[Bug 1536878] Review Request: elementary-wallpapers - Collection of wallpapers from the elementary project

2018-01-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1536878

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org