[Bug 1538076] Review Request: insect - A scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1538076 Timothée Floure changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2018-03-15 13:34:46 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1538076] Review Request: insect - A scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1538076 --- Comment #4 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/insect -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1538076] Review Request: insect - A scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1538076 Bug 1538076 depends on bug 1554695, which changed state. Bug 1554695 Summary: Review Request: nodejs-xdg-basedir - A JavaScript library to work with XDG Base Directory paths https://bugzilla.redhat.com/show_bug.cgi?id=1554695 What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1538076] Review Request: insect - A scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1538076 Timothée Floure changed: What|Removed |Added Depends On||1554695 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1554695 [Bug 1554695] Review Request: nodejs-xdg-basedir - A JavaScript library to work with XDG Base Directory paths -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1538076] Review Request: insect - A scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1538076 Bug 1538076 depends on bug 1433798, which changed state. Bug 1433798 Summary: Review Request: nodejs-xdg-basedir - Get XDG Base Directory paths https://bugzilla.redhat.com/show_bug.cgi?id=1433798 What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1538076] Review Request: insect - A scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1538076 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #3 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1538076] Review Request: insect - A scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1538076 --- Comment #2 from Timothée Floure --- Here are the slightly modified specfile and SRPM. Spec URL: https://fnux.fedorapeople.org/pkg-reviews/insect/insect.spec SRPM URL: https://fnux.fedorapeople.org/pkg-reviews/insect/insect-5.0.0-2.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1538076] Review Request: insect - A scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1538076 Bug 1538076 depends on bug 1538069, which changed state. Bug 1538069 Summary: Review Request: nodejs-historic-readline - A JavaScript library extending the node readline module to save history to file https://bugzilla.redhat.com/show_bug.cgi?id=1538069 What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1538076] Review Request: insect - A scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1538076 Bug 1538076 depends on bug 1538067, which changed state. Bug 1538067 Summary: Review Request: nodejs-decimal-js - A Javascript library for arbitrary-precision arithmetic https://bugzilla.redhat.com/show_bug.cgi?id=1538067 What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1538076] Review Request: insect - A scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1538076
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
- Replace /usr/bin/env node with /usr/bin/node:
insect.noarch: E: wrong-script-interpreter
/usr/lib/node_modules/insect/index.js /usr/bin/env node
sed -i '1s/env //' index.js
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 363 files have
unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/insect/review-insect/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %defin
[Bug 1538076] Review Request: insect - A scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1538076 Timothée Floure changed: What|Removed |Added Depends On||1433798, 1538069, 1538067 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1433798 [Bug 1433798] Review Request: nodejs-xdg-basedir - Get XDG Base Directory paths https://bugzilla.redhat.com/show_bug.cgi?id=1538067 [Bug 1538067] Review Request: nodejs-decimal-js - A Javascript library for arbitrary-precision arithmetic https://bugzilla.redhat.com/show_bug.cgi?id=1538069 [Bug 1538069] Review Request: nodejs-historic-readline - A JavaScript library extending the node readline module to save history to file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
