[Bug 1539190] Review Request: golang-github-zyedidia-terminal - Vt10x terminal emulation backend
https://bugzilla.redhat.com/show_bug.cgi?id=1539190 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-03-06 12:21:36 --- Comment #6 from Fedora Update System --- golang-github-zyedidia-terminal-0-0.1.20180126git1760577.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539190] Review Request: golang-github-zyedidia-terminal - Vt10x terminal emulation backend
https://bugzilla.redhat.com/show_bug.cgi?id=1539190 Bug 1539190 depends on bug 1539189, which changed state. Bug 1539189 Summary: Review Request: golang-github-zyedidia-pty - PTY interface for Go https://bugzilla.redhat.com/show_bug.cgi?id=1539189 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539190] Review Request: golang-github-zyedidia-terminal - Vt10x terminal emulation backend
https://bugzilla.redhat.com/show_bug.cgi?id=1539190 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System --- golang-github-zyedidia-terminal-0-0.1.20180126git1760577.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-cbf443fefa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539190] Review Request: golang-github-zyedidia-terminal - Vt10x terminal emulation backend
https://bugzilla.redhat.com/show_bug.cgi?id=1539190 --- Comment #4 from Fedora Update System --- golang-github-zyedidia-terminal-0-0.1.20180126git1760577.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-cbf443fefa -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539190] Review Request: golang-github-zyedidia-terminal - Vt10x terminal emulation backend
https://bugzilla.redhat.com/show_bug.cgi?id=1539190 --- Comment #3 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-zyedidia-terminal -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539190] Review Request: golang-github-zyedidia-terminal - Vt10x terminal emulation backend
https://bugzilla.redhat.com/show_bug.cgi?id=1539190 Robert-André Mauchin changed: What|Removed |Added Assignee|nob...@fedoraproject.org|jsmith.fed...@gmail.com --- Comment #2 from Robert-André Mauchin --- Thanks a lot for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1539190] Review Request: golang-github-zyedidia-terminal - Vt10x terminal emulation backend
https://bugzilla.redhat.com/show_bug.cgi?id=1539190
Jared Smith changed:
What|Removed |Added
Status|NEW |MODIFIED
CC||jsmith.fed...@gmail.com
Flags||fedora-review+
--- Comment #1 from Jared Smith ---
Package is APPROVED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 16 files have unknown license. Detailed
output of licensecheck in
/home/jsmith/Documents/Fedora/Reviews/1539190-golang-github-zyedidia-
terminal/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gocode/src,
/usr/share/gocode, /usr/share/gocode/src/github.com
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/gocode/src/github.com/zyedidia(golang-github-zyedidia-
tcell-devel, golang-github-zyedidia-poller-devel, golang-github-
zyedidia-clipboard-devel, golang-github-zyedidia-glob-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
[Bug 1539190] Review Request: golang-github-zyedidia-terminal - Vt10x terminal emulation backend
https://bugzilla.redhat.com/show_bug.cgi?id=1539190 Robert-André Mauchin changed: What|Removed |Added Depends On||1539189 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1539189 [Bug 1539189] Review Request: golang-github-zyedidia-pty - PTY interface for Go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
