[Bug 1545479] Review Request: hcc - Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 Elliott Sales de Andrade changed: What|Removed |Added Status|POST|CLOSED CC|

[Bug 1545479] Review Request: hcc - Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 Bug 1545479 depends on bug 1666836, which changed state. Bug 1666836 Summary: Review Request: rocminfo - ROCm system info utility https://bugzilla.redhat.com/show_bug.cgi?id=1666836 What|Removed |Added

[Bug 1545479] Review Request: hcc - Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #24 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/hcc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about

[Bug 1545479] Review Request: hcc - Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 Tom Stellard changed: What|Removed |Added Summary|Review Request: hcc-|Review Request: hcc -

[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST

[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #22 from Tom Stellard --- (In reply to Felix Schwarz from comment #17) > Two more things: Tom, some of your SRPM URLs are 404. > Yes, COPR cleans up the older builds after a certain amount of time. -- You are receiving this

[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #21 from Tom Stellard --- (In reply to Felix Schwarz from comment #16) > (In reply to Robert-André Mauchin from comment #14) > > - %{_includedir}/* in %files > > > > Includes should go to a devel package > > > >

[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #20 from Tom Stellard --- SPEC URL: https://copr-be.cloud.fedoraproject.org/results/tstellar/rocm-2.0/fedora-rawhide-x86_64/00870303-hcc/hcc.spec SRPM URL:

[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #19 from Tom Stellard --- (In reply to Felix Schwarz from comment #17) > Two more things: Tom, some of your SRPM URLs are 404. > > Also in your last revision of the spec file you added "libunwind-devel" with > no other changes.

[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #18 from Tom Stellard --- (In reply to Felix Schwarz from comment #16) > (In reply to Robert-André Mauchin from comment #14) > > - %{_includedir}/* in %files > > > > Includes should go to a devel package > > > >

[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #17 from Felix Schwarz --- Two more things: Tom, some of your SRPM URLs are 404. Also in your last revision of the spec file you added "libunwind-devel" with no other changes. Would you mind commenting why you did that? -- You

[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #16 from Felix Schwarz --- (In reply to Robert-André Mauchin from comment #14) > - %{_includedir}/* in %files > > Includes should go to a devel package > > %{_libdir}/cmake/hcc/ too. Not sure if I understood you correctly but

[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #15 from Robert-André Mauchin --- This takes forever to compile. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #14 from Robert-André Mauchin --- %if 0%{?__isa_bits} == 64 %global build_libdir lib64/ %else %global build_libdir lib/ %endif - Why not use %{_lib}? It resolves to either lib or lib64 depending on the arch. -

[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #13 from Tom Stellard --- SPEC URL: https://copr-be.cloud.fedoraproject.org/results/tstellar/rocm-2.0/fedora-rawhide-x86_64/00863201-hcc/hcc.spec SRPM URL:

[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #12 from Tom Stellard --- SPEC URL: https://copr-be.cloud.fedoraproject.org/results/tstellar/rocm-2.0/fedora-rawhide-x86_64/00862882-hcc/hcc.spec SRPM URL:

[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #11 from Felix Schwarz --- I'm mostly done with the review (still hoping that someone more experienced will join here :-). Some questions+bikeshedding and one bigger issue. Let's start with the most important one: .so files in

[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #10 from Tom Stellard --- Spec URL: https://copr-be.cloud.fedoraproject.org/results/tstellar/rocm-2.0/fedora-rawhide-x86_64/00857850-hcc/hcc.spec SRPM URL:

[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #9 from Felix Schwarz --- Hi Tom, fixing all the small issues I brought up (I had hoped someone more experienced than me would have reviewed the package by now). I'm still hesitant to formally reviewing this package but I think I

[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #8 from Tom Stellard --- Spec URL: https://copr-be.cloud.fedoraproject.org/results/tstellar/rocm-2.0/fedora-rawhide-x86_64/00849663-hcc/hcc.spec SRPM URL:

[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 Tom Stellard changed: What|Removed |Added Blocks||1668010 Referenced Bugs:

[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #7 from Felix Schwarz --- I rebuilt your updated hcc package on Fedora 29 which worked fine. The resulting "hcc" binary seems to work. I was able to run "saxpy" and several example programs from

[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 Tom Stellard changed: What|Removed |Added Depends On||1666836 --- Comment #6 from Tom

[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #5 from Tom Stellard --- (In reply to Felix Schwarz from comment #4) > > I'm not going to push a ROCm 1.6 version of hcc into Fedora. I have updated > > the spec file locally to ROCm 1.7, but I would need to

[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #4 from Felix Schwarz --- > I'm not going to push a ROCm 1.6 version of hcc into Fedora. I have updated > the spec file locally to ROCm 1.7, but I would need to update rocm-runtime and > libhsakmt in

[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #3 from Tom Stellard --- I'm not going to push a ROCm 1.6 version of hcc into Fedora. I have updated the spec file locally to ROCm 1.7, but I would need to update rocm-runtime and libhsakmt in Fedora to ROCm

[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 --- Comment #2 from Felix Schwarz --- Just a random note: Do you plan to update the spec to the latest HCC version/roc 1.7/1.8 in this review request or would you like to do that after the package got reviewed?

[Bug 1545479] Review Request: hcc- Heterogeneous C++ Compiler

https://bugzilla.redhat.com/show_bug.cgi?id=1545479 Robert-André Mauchin changed: What|Removed |Added CC|