[Bug 1548798] Review Request: natural-earth-map-data - Free vector and raster map data at 1:10m, 1:50m, and 1:110m scales

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548798



--- Comment #10 from Fedora Update System  ---
natural-earth-map-data-4.0.0-2.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548798] Review Request: natural-earth-map-data - Free vector and raster map data at 1:10m, 1:50m, and 1:110m scales

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548798

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-03-06 12:25:19



--- Comment #9 from Fedora Update System  ---
natural-earth-map-data-4.0.0-2.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548798] Review Request: natural-earth-map-data - Free vector and raster map data at 1:10m, 1:50m, and 1:110m scales

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548798



--- Comment #8 from Fedora Update System  ---
natural-earth-map-data-4.0.0-2.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-82436ae18b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548798] Review Request: natural-earth-map-data - Free vector and raster map data at 1:10m, 1:50m, and 1:110m scales

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548798

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
natural-earth-map-data-4.0.0-2.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-5113a4dec7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548798] Review Request: natural-earth-map-data - Free vector and raster map data at 1:10m, 1:50m, and 1:110m scales

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548798



--- Comment #6 from Fedora Update System  ---
natural-earth-map-data-4.0.0-2.fc26 has been submitted as an update to Fedora
26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-82436ae18b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548798] Review Request: natural-earth-map-data - Free vector and raster map data at 1:10m, 1:50m, and 1:110m scales

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548798



--- Comment #5 from Fedora Update System  ---
natural-earth-map-data-4.0.0-2.fc27 has been submitted as an update to Fedora
27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-5113a4dec7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548798] Review Request: natural-earth-map-data - Free vector and raster map data at 1:10m, 1:50m, and 1:110m scales

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548798

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548798] Review Request: natural-earth-map-data - Free vector and raster map data at 1:10m, 1:50m, and 1:110m scales

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548798



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/natural-earth-map-data

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548798] Review Request: natural-earth-map-data - Free vector and raster map data at 1:10m, 1:50m, and 1:110m scales

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548798

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
Package approved.

You should grab
https://github.com/nvkelso/natural-earth-vector/blob/master/LICENSE.md and add
it as a %license file.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "*No copyright* CC0 (v9)", "CC0", "Unknown or generated", "*No
 copyright* Public domain". 1198 files have unknown license. Detailed
 output of licensecheck in /home/bob/packaging/review/natural-earth-
 map-data/review-natural-earth-map-data/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 583680 bytes in 18 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in natural-
 earth-map-data-110m , natural-earth-map-data-50m , natural-earth-map-
 data-10m
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.

[Bug 1548798] Review Request: natural-earth-map-data - Free vector and raster map data at 1:10m, 1:50m, and 1:110m scales

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548798



--- Comment #2 from Elliott Sales de Andrade  ---
Upstream provides .zip files, but I wonder if I should repackage as tar.xz;
this would save about 105M. I did ask upstream about it [1], but haven't gotten
a response yet.

[1] https://github.com/nvkelso/natural-earth-vector/issues/248

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548798] Review Request: natural-earth-map-data - Free vector and raster map data at 1:10m, 1:50m, and 1:110m scales

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548798

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1548797




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1548797
[Bug 1548797] Review Request: python-cartopy - Cartographic Python library
with Matplotlib visualisations
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1548798] Review Request: natural-earth-map-data - Free vector and raster map data at 1:10m, 1:50m, and 1:110m scales

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1548798



--- Comment #1 from Elliott Sales de Andrade  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=25296534

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org