[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1550317 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-04-14 22:36:25 --- Comment #15 from Fedora Update System --- python-flask-security-3.0.0-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1550317 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System --- python-flask-security-3.0.0-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-48f664b3ed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1550317 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1550317 --- Comment #13 from Fedora Update System --- python-flask-security-3.0.0-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-48f664b3ed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1550317 --- Comment #12 from Itamar Reis Peixoto --- https://pagure.io/releng/fedora-scm-requests/issue/5658 https://pagure.io/releng/fedora-scm-requests/issue/5659 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1550317 --- Comment #11 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-flask-security -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1550317 --- Comment #10 from Itamar Reis Peixoto --- $ fedpkg --module-name python-flask-security request-repo 1550317 https://pagure.io/releng/fedora-scm-requests/issue/5646 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1550317
Randy Barlow changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #9 from Randy Barlow ---
Approved!
Before building, please change the URL from http:// to https://.
Suggestions:
* Use the %{?_smp_mflags} macro on your make commands.
* Remove the execute bit from the man page.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 128 files have
unknown license. Detailed output of licensecheck in
/home/rbarlow/reviews/1550317-python-flask-security/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
-flask-security , python3-flask-security , python-flask-security-doc
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from ups
[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1550317
--- Comment #8 from Itamar Reis Peixoto ---
> Why are you using %{python3_pkgversion} in your Requires and BuildRequires?
> You can just use the number 3, which is simpler. I suggest using this form:
I am interested in maybe building it for epel.
Spec URL: https://itamarjp.fedorapeople.org/review/python-flask-security.spec
SRPM URL:
https://itamarjp.fedorapeople.org/review/python-flask-security-3.0.0-1.fc28.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1550317 Bug 1550317 depends on bug 1562650, which changed state. Bug 1562650 Summary: Review Request: python-flask-babelex - Adds i18n/l10n support to Flask applications https://bugzilla.redhat.com/show_bug.cgi?id=1562650 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1550317 Bug 1550317 depends on bug 1553867, which changed state. Bug 1553867 Summary: Review Request: python-flask-sphinx-themes - Sphinx themes for Flask and related projects https://bugzilla.redhat.com/show_bug.cgi?id=1553867 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1550317 Itamar Reis Peixoto changed: What|Removed |Added Depends On||1562650 Flags|needinfo?(itamar@ispbrasil. | |com.br) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1562650 [Bug 1562650] Review Request: python-flask-babelex - Adds i18n/l10n support to Flask applications -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1550317
Randy Barlow changed:
What|Removed |Added
Flags||needinfo?(itamar@ispbrasil.
||com.br)
--- Comment #7 from Randy Barlow ---
There are still problems with ownership:
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib/python3.6/site-
packages/flask_security/templates/security/email, /usr/lib/python3.6
/site-packages/flask_security/templates, /usr/lib/python3.6/site-
packages/flask_security/translations, /usr/lib/python2.7/site-
packages/flask_security/templates, /usr/lib/python3.6/site-
packages/flask_security/__pycache__, /usr/lib/python2.7/site-
packages/flask_security/translations, /usr/lib/python2.7/site-
packages/flask_security/templates/security/email, /usr/lib/python2.7
/site-packages/flask_security/templates/security, /usr/lib/python3.6
/site-packages/flask_security/templates/security
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python3.6/site-
packages/flask_security/templates/security/email, /usr/lib/python3.6
/site-packages/flask_security/templates, /usr/lib/python3.6/site-
packages/flask_security/__pycache__, /usr/lib/python2.7/site-
packages/flask_security/templates, /usr/lib/python2.7/site-
packages/flask_security/translations, /usr/lib/python2.7/site-
packages/flask_security/templates/security/email, /usr/lib/python3.6
/site-packages/flask_security/translations, /usr/lib/python2.7/site-
packages/flask_security/templates/security, /usr/lib/python3.6/site-
packages/flask_security/templates/security
You can set your files sections to be like I described in Comment #4 to fix
this.
Why are you using %{python3_pkgversion} in your Requires and BuildRequires? You
can just use the number 3, which is simpler. I suggest using this form:
Requires: python3-flask
BuildRequires: python3-flask-sphinx-themes
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1550317 --- Comment #6 from Itamar Reis Peixoto --- Spec URL: https://itamarjp.fedorapeople.org/review/python-flask-security.spec SRPM URL: https://itamarjp.fedorapeople.org/review/python-flask-security-3.0.0-1.fc27.src.rpm building html docs and man page. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1550317 Itamar Reis Peixoto changed: What|Removed |Added Depends On||1553867 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1553867 [Bug 1553867] Review Request: python-flask-sphinx-themes - Sphinx themes for Flask and related projects -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1550317 Itamar Reis Peixoto changed: What|Removed |Added Flags|needinfo?(itamar@ispbrasil. | |com.br) | --- Comment #5 from Itamar Reis Peixoto --- I fixed some items, others still pending, if you unpack Flask-Security-3.0.0.tar.gz and read setup.py you will see that for running tests requires alot of items that's not available in fedora repos. tests_require = [ also for building docs 'Flask-Sphinx-Themes>=1.0.1' is required. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1550317
Randy Barlow changed:
What|Removed |Added
Flags||needinfo?(itamar@ispbrasil.
||com.br)
--- Comment #4 from Randy Barlow ---
A few issues to fix:
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib/python3.6/site-
packages/flask_security/templates/security/email, /usr/lib/python3.6
/site-packages/flask_security/templates, /usr/lib/python3.6/site-
packages/flask_security/translations, /usr/lib/python2.7/site-
packages/flask_security/templates, /usr/lib/python3.6/site-
packages/flask_security/__pycache__, /usr/lib/python2.7/site-
packages/flask_security/translations, /usr/lib/python2.7/site-
packages/flask_security/templates/security/email, /usr/lib/python2.7
/site-packages/flask_security, /usr/lib/python2.7/site-
packages/flask_security/templates/security, /usr/lib/python3.6/site-
packages/flask_security/templates/security, /usr/lib/python3.6/site-
packages/flask_security
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python3.6/site-
packages/flask_security/templates/security/email, /usr/lib/python3.6
/site-packages/flask_security/templates, /usr/lib/python3.6/site-
packages/flask_security/__pycache__, /usr/lib/python2.7/site-
packages/flask_security/templates, /usr/lib/python2.7/site-
packages/flask_security/translations, /usr/lib/python2.7/site-
packages/flask_security/templates/security/email, /usr/lib/python2.7
/site-packages/flask_security, /usr/lib/python3.6/site-
packages/flask_security/translations, /usr/lib/python2.7/site-
packages/flask_security/templates/security, /usr/lib/python3.6/site-
packages/flask_security/templates/security, /usr/lib/python3.6/site-
packages/flask_security
Recommendation: Simply put %{python2_sitelib}/flask_security and
%{python3_sitelib}/flask_security into your %files sections, rather than trying
to write out all the subpaths.
[!]: You have
%{?python_provide:%python_provide python%{python3_pkgversion}-%{pkg_name}}
in the Python 2 subpackage.
Recommendation: It should be %{?python_provide:%python_provide
python2-%{pkg_name}}.
Optional, but recommended: Upstream does have a test suite. I recommend running
it in a %check section.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1550317 Bug 1550317 depends on bug 1550314, which changed state. Bug 1550314 Summary: Review Request: python-flask-mail - A Flask extension for sending email messages. https://bugzilla.redhat.com/show_bug.cgi?id=1550314 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1550317 --- Comment #3 from Itamar Reis Peixoto --- Spec URL: https://itamarjp.fedorapeople.org/review/python-flask-security.spec SRPM URL: https://itamarjp.fedorapeople.org/review/python-flask-security-3.0.0-1.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1550317 --- Comment #2 from Itamar Reis Peixoto --- I will post the updated spec file after we get python-flask-mail in. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1550317 Itamar Reis Peixoto changed: What|Removed |Added Depends On||1550314 Flags|needinfo?(itamar@ispbrasil. | |com.br) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1550314 [Bug 1550314] Review Request: python-flask-mail - A Flask extension for sending email messages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1550317 Randy Barlow changed: What|Removed |Added CC||ita...@ispbrasil.com.br Flags||needinfo?(itamar@ispbrasil. ||com.br) --- Comment #1 from Randy Barlow --- Version 1.7.5 is quite old, and there's a newer 3.0.0 that claims to fix a security issue: - Fixed a security bug when validating a confirmation token, also checks if the email that the token was created with matches the user's current email. https://github.com/mattupstate/flask-security/blob/develop/CHANGES I think we should probably package 3.0.0 instead of 1.7.5. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1550317 Randy Barlow changed: What|Removed |Added Status|NEW |ASSIGNED CC||rbar...@redhat.com Assignee|nob...@fedoraproject.org|rbar...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1550317] Review Request: python-flask-security - Flask-Security quickly adds security features to your Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1550317 Itamar Reis Peixoto changed: What|Removed |Added Blocks||1380826 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1380826 [Bug 1380826] Review Request: pgadmin4 - Management tool for PostgreSQL -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
