[Bug 1554021] Review Request: usbauth - USB firewall against BadUSB attacks
https://bugzilla.redhat.com/show_bug.cgi?id=1554021 Mattia Verga changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2021-07-04 15:23:09 --- Comment #11 from Mattia Verga --- Package is in repos -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 1554021] Review Request: usbauth - USB firewall against BadUSB attacks
https://bugzilla.redhat.com/show_bug.cgi?id=1554021 --- Comment #10 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/usbauth -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1554021] Review Request: usbauth - USB firewall against BadUSB attacks
https://bugzilla.redhat.com/show_bug.cgi?id=1554021 Robert-André Mauchin changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #9 from Robert-André Mauchin --- Refreshing flag -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1554021] Review Request: usbauth - USB firewall against BadUSB attacks
https://bugzilla.redhat.com/show_bug.cgi?id=1554021 Robert-André Mauchin changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Flags|fedora-review+ |fedora-review? Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1554021] Review Request: usbauth - USB firewall against BadUSB attacks
https://bugzilla.redhat.com/show_bug.cgi?id=1554021 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #8 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1554021] Review Request: usbauth - USB firewall against BadUSB attacks
https://bugzilla.redhat.com/show_bug.cgi?id=1554021 --- Comment #7 from Stefan Koch --- The main difference is that usbguard uses the USB device authorization mechanism. usbauth uses the USB interface authorization mechanism, that was introduced since kernel 4.4. Historical, usbguard was published while the working on usbauth has already been started. usbauth could allow/deny usb interfaces using the new usb interface authorization mechanism that is part of linux 4.4 and above. See also: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/?h=v4.4.94=grep=interface+auth Examples: * allow a storage functionality of a USB device and deny USB Ethernet of the same device * allow audio/video functionality of an USB TV card and deny using the remote control functionality * allow USB printing/scanning and deny USB storage usage of a multifunction printer (BTW: the interface mechanism supports denying user space triggered actions (using USB claiming) like scanning) usbguard could allow/deny USB devices using the usb device authorization mechanism of the Linux kernel. It allows to denying a whole device if one interface of it is considered as bad (usbauth supports this, too) usbguard allows creating actions that is not supported by usbauth. I hope this helps. If you can understand German language you could read a detailed description: https://epub.uni-bayreuth.de/3048/1/koch2017sicherheitsaspekte.pdf Currently the usbauth suite is packaged for openSUSE Leap 15.0, Debian Buster including ubuntu 18.04 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1554021] Review Request: usbauth - USB firewall against BadUSB attacks
https://bugzilla.redhat.com/show_bug.cgi?id=1554021 --- Comment #5 from Stefan Koch --- I have added an new revised build at: https://copr.fedorainfracloud.org/coprs/kochstefan/usbauth-all/build/849729 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1554021] Review Request: usbauth - USB firewall against BadUSB attacks
https://bugzilla.redhat.com/show_bug.cgi?id=1554021 --- Comment #4 from Robert-André Mauchin --- - Use %autosetup or %setup -q to make the setup quiet: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1554021] Review Request: usbauth - USB firewall against BadUSB attacks
https://bugzilla.redhat.com/show_bug.cgi?id=1554021 --- Comment #3 from Robert-André Mauchin --- - Please space out your changelog entry, they are difficult to read - I would rather have you not mix Suse stuff with Fedora stuff. - Install the license file with %license, not %doc %doc README %license COPYING - Your %changelog entry must contain the release-version: * Sat Mar 10 2018 stefan.koc...@gmail.com - 1.0-1 - Add a BR for gcc - Split the description to stay below 80 characters per line and fix the typo: usbauth.src: W: spelling-error %description -l en_US descibes -> describes, describe, Delibes usbauth.src: E: description-line-too-long C It is a firewall against BadUSB attacks. A config file descibes in which way devices would be accepted. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is not marked as %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2)", "Unknown or generated". 10 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/usbauth/review-usbauth/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config /etc/dbus-1/system.d/org.opensuse.usbauth.conf [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [-]: Buildroot is not present Note:
[Bug 1554021] Review Request: usbauth - USB firewall against BadUSB attacks
https://bugzilla.redhat.com/show_bug.cgi?id=1554021 Stefan Kochchanged: What|Removed |Added See Also||https://bugzilla.redhat.com ||/show_bug.cgi?id=1554022 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1554021] Review Request: usbauth - USB firewall against BadUSB attacks
https://bugzilla.redhat.com/show_bug.cgi?id=1554021 Stefan Kochchanged: What|Removed |Added See Also||https://bugzilla.redhat.com ||/show_bug.cgi?id=1554020 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1554021] Review Request: usbauth - USB firewall against BadUSB attacks
https://bugzilla.redhat.com/show_bug.cgi?id=1554021 --- Comment #2 from Stefan Koch--- *** Bug 1553496 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1554021] Review Request: usbauth - USB firewall against BadUSB attacks
https://bugzilla.redhat.com/show_bug.cgi?id=1554021 Stefan Kochchanged: What|Removed |Added CC||zebo...@gmail.com See Also||https://bugzilla.redhat.com ||/show_bug.cgi?id=1553496 Blocks||177841 (FE-NEEDSPONSOR) --- Comment #1 from Stefan Koch --- A first review was done by Robert-André Mauchin with Bug 1553496 (complete usbauth suite review request). I have changed the spec files now. There are new build available on COPR. See Bugs: 1554020 libusbauth-configparser review request 1554021 usbauth review request 1554022 usbauth-notifier review request (these bugs will replace bug 1553496) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org