[Bug 1559388] Review Request: dep - Go dependency management tool
https://bugzilla.redhat.com/show_bug.cgi?id=1559388 --- Comment #14 from Fedora Update System --- dep-0.4.1-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1559388] Review Request: dep - Go dependency management tool
https://bugzilla.redhat.com/show_bug.cgi?id=1559388 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2018-04-11 12:31:10 --- Comment #13 from Fedora Update System --- dep-0.4.1-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1559388] Review Request: dep - Go dependency management tool
https://bugzilla.redhat.com/show_bug.cgi?id=1559388 --- Comment #12 from Fedora Update System --- dep-0.4.1-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-b31a1c55d5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1559388] Review Request: dep - Go dependency management tool
https://bugzilla.redhat.com/show_bug.cgi?id=1559388 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- dep-0.4.1-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-fb32f1a2e3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1559388] Review Request: dep - Go dependency management tool
https://bugzilla.redhat.com/show_bug.cgi?id=1559388 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1559388] Review Request: dep - Go dependency management tool
https://bugzilla.redhat.com/show_bug.cgi?id=1559388 --- Comment #9 from Fedora Update System --- dep-0.4.1-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-b31a1c55d5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1559388] Review Request: dep - Go dependency management tool
https://bugzilla.redhat.com/show_bug.cgi?id=1559388 --- Comment #10 from Fedora Update System --- dep-0.4.1-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-fb32f1a2e3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1559388] Review Request: dep - Go dependency management tool
https://bugzilla.redhat.com/show_bug.cgi?id=1559388 --- Comment #8 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/dep -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1559388] Review Request: dep - Go dependency management tool
https://bugzilla.redhat.com/show_bug.cgi?id=1559388 --- Comment #7 from Jan Chaloupka --- Thank you, sir!!! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1559388] Review Request: dep - Go dependency management tool
https://bugzilla.redhat.com/show_bug.cgi?id=1559388 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #6 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1559388] Review Request: dep - Go dependency management tool
https://bugzilla.redhat.com/show_bug.cgi?id=1559388 --- Comment #5 from Jan Chaloupka --- s/Both files has/Both dep and dep-devel have/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1559388] Review Request: dep - Go dependency management tool
https://bugzilla.redhat.com/show_bug.cgi?id=1559388
--- Comment #4 from Jan Chaloupka ---
> [!]: License file installed when any subpackage combination is installed.
$ rpm -qpl
/home/jchaloup/rpmbuild/RPMS/noarch/dep-devel-0.4.1-1.fc24.noarch.rpm | grep
license
/usr/share/gocode/src/github.com/golang/dep/hack/licenseok
/usr/share/gocode/src/github.com/golang/dep/hack/licenseok/main.go
/usr/share/licenses/dep-devel
/usr/share/licenses/dep-devel/LICENSE
/usr/share/licenses/dep-devel/PATENTS
$ rpm -qpl /home/jchaloup/rpmbuild/RPMS/x86_64/dep-0.4.1-1.fc24.x86_64.rpm |
grep license
/usr/share/licenses/dep
/usr/share/licenses/dep/LICENSE
/usr/share/licenses/dep/PATENTS
Both files has at least one file under /usr/share/licenses/dep directory.
Wondering why the fedora-review is not happy.
> - This is not needed, even on EPEL %license is defined:
>
> #define license tag if not already defined
> %{!?_licensedir:%global license %doc}
Removed
> - As Neal said, PATENTS file belongs in %license
PATENTS moved under %license tag.
Both spec and srpm updated. The same links stay.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1559388] Review Request: dep - Go dependency management tool
https://bugzilla.redhat.com/show_bug.cgi?id=1559388
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #3 from Robert-André Mauchin ---
- This is not needed, even on EPEL %license is defined:
#define license tag if not already defined
%{!?_licensedir:%global license %doc}
- As Neal said, PATENTS file belongs in %license
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "BSD (3 clause)", "MIT/X11 (BSD like)", "Apache (v2.0)",
"Unknown or generated", "BSD (2 clause)". 1003 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/dep/review-dep/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gocode/src,
/usr/share/gocode
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/gocode/src/github.com/golang(golang-github-golang-mock-
devel), /usr/share/gocode/src/github.com(golang)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 61440 bytes in 16 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dep-
devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Pac
[Bug 1559388] Review Request: dep - Go dependency management tool
https://bugzilla.redhat.com/show_bug.cgi?id=1559388 Neal Gompa changed: What|Removed |Added CC||ngomp...@gmail.com --- Comment #2 from Neal Gompa --- PATENTS file belongs in %license, not %doc. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1559388] Review Request: dep - Go dependency management tool
https://bugzilla.redhat.com/show_bug.cgi?id=1559388 --- Comment #1 from Jan Chaloupka --- Spec URL: https://jchaloup.fedorapeople.org/reviews/dep/dep.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/dep/dep-0.4.1-1.fc24.src.rpm Description: Go dependency management tool Fedora Account System Username: jchaloup Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=25882121 $ rpmlint dep-0.4.1-1.fc24.src.rpm dep-0.4.1-1.fc24.x86_64.rpm dep-devel-0.4.1-1.fc24.noarch.rpm dep-debuginfo-0.4.1-1.fc24.x86_64.rpm dep.x86_64: W: binaryinfo-readelf-failed /usr/bin/gps dep.x86_64: W: no-manual-page-for-binary gps dep.x86_64: W: no-manual-page-for-binary dep dep-devel.noarch: W: spelling-error %description -l en_US github -> git hub, git-hub, GitHub dep-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/golang/dep/.goipath dep-devel.noarch: E: zero-length /usr/share/gocode/src/github.com/golang/dep/.goipath 4 packages and 0 specfiles checked; 1 errors, 5 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
