[Bug 1559858] Review Request: php-mock-integration2 - Integration package for PHP-Mock

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559858



--- Comment #9 from Fedora Update System  ---
php-mock-integration2-2.0.0-2.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1559858] Review Request: php-mock-integration2 - Integration package for PHP-Mock

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559858
Bug 1559858 depends on bug 1559857, which changed state.

Bug 1559857 Summary: Review Request: php-mock2 - PHP-Mock can mock built-in PHP 
functions
https://bugzilla.redhat.com/show_bug.cgi?id=1559857

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1559858] Review Request: php-mock-integration2 - Integration package for PHP-Mock

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559858

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-04-03 09:25:24



--- Comment #8 from Fedora Update System  ---
php-mock-integration2-2.0.0-2.fc28 has been pushed to the Fedora 28 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1559858] Review Request: php-mock-integration2 - Integration package for PHP-Mock

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559858



--- Comment #7 from Fedora Update System  ---
php-mock-integration2-2.0.0-2.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-c9d2d70192

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1559858] Review Request: php-mock-integration2 - Integration package for PHP-Mock

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559858

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
php-mock-integration2-2.0.0-2.fc28 has been pushed to the Fedora 28 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-72f85cf5d2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1559858] Review Request: php-mock-integration2 - Integration package for PHP-Mock

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559858

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1559858] Review Request: php-mock-integration2 - Integration package for PHP-Mock

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559858



--- Comment #4 from Fedora Update System  ---
php-mock-integration2-2.0.0-2.fc27 has been submitted as an update to Fedora
27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-c9d2d70192

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1559858] Review Request: php-mock-integration2 - Integration package for PHP-Mock

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559858



--- Comment #5 from Fedora Update System  ---
php-mock-integration2-2.0.0-2.fc28 has been submitted as an update to Fedora
28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-72f85cf5d2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1559858] Review Request: php-mock-integration2 - Integration package for PHP-Mock

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559858



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/php-mock-integration2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1559858] Review Request: php-mock-integration2 - Integration package for PHP-Mock

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559858



--- Comment #2 from Remi Collet  ---
Thanks for the review

SCM requests
https://pagure.io/releng/fedora-scm-requests/issue/5410
https://pagure.io/releng/fedora-scm-requests/issue/5411
https://pagure.io/releng/fedora-scm-requests/issue/5412

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1559858] Review Request: php-mock-integration2 - Integration package for PHP-Mock

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559858

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
 - Own the following directory:

[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/php/phpmock2


Package approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "do What The Fuck you want to Public License (v2)", "Unknown or
 generated". 8 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/php-mock-integration2
 /review-php-mock-integration2/licensecheck.txt
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/php/phpmock2
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/php/phpmock2
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.

[Bug 1559858] Review Request: php-mock-integration2 - Integration package for PHP-Mock

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559858

Remi Collet  changed:

   What|Removed |Added

 Blocks||1559861




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1559861
[Bug 1559861] Review Request: php-mock-phpunit2 - Mock built-in PHP
functions with PHPUnit
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1559858] Review Request: php-mock-integration2 - Integration package for PHP-Mock

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1559858

Remi Collet  changed:

   What|Removed |Added

 Depends On||1559857




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1559857
[Bug 1559857] Review Request: php-mock2 - PHP-Mock can mock built-in PHP
functions
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org