[Bug 1563680] Package Review: libocxl - library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 Hanns-Joachim Uhl changed: What|Removed |Added Blocks||1524656

[Bug 1563680] Package Review: libocxl - library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 Fedora Update System changed: What|Removed |Added Status|ON_QA

[Bug 1563680] Package Review: libocxl - library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA

[Bug 1563680] Package Review: libocxl - library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 Fedora Update System changed: What|Removed |Added Status|ASSIGNED

[Bug 1563680] Package Review: libocxl - library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 --- Comment #18 from Fedora Update System --- libocxl-1.0.0-0.1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-80a761dd88 -- You are receiving this mail

[Bug 1563680] Package Review: libocxl - library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 --- Comment #17 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libocxl -- You are receiving this mail because: You are on the CC list for the bug. You

[Bug 1563680] Package Review: libocxl - library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 Michel Normand changed: What|Removed |Added Summary|Package Review: libocxl |Package

[Bug 1563680] Package Review: libocxl library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 --- Comment #16 from Michel Normand --- scratch build on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=26291946 -- You are receiving this mail because: You are on the CC list for the bug. You are

[Bug 1563680] Package Review: libocxl library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 Dan Horák changed: What|Removed |Added Flags||fedora-review+ ---

[Bug 1563680] Package Review: libocxl library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 --- Comment #14 from Michel Normand --- OK I moved man in *devel rpm and kept html in *docs rpm I did not change the Source0 to ease compare with previous URL line and allow direct access from either vi or emacs

[Bug 1563680] Package Review: libocxl library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 --- Comment #13 from Dan Horák --- If the content of the man pages and html file is the same, then I would merge the man pages into the devel subpackage (where usually basic API documentation goes, I mean headers + man pages

[Bug 1563680] Package Review: libocxl library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 --- Comment #12 from Michel Normand --- (In reply to Michel Normand from comment #11) > I updated the spec file for your previous comments > except the man pages and html ones both generated by doxygen, > so kept

[Bug 1563680] Package Review: libocxl library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 --- Comment #11 from Michel Normand --- I updated the spec file for your previous comments except the man pages and html ones both generated by doxygen, so kept them both in the noarch package. -- You are

[Bug 1563680] Package Review: libocxl library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 --- Comment #10 from Dan Horák --- - the Release tag value should be 0.1 as the 1.0.0 version is in beta (see https://fedoraproject.org/wiki/Packaging:Versioning#Prerelease_versions) - I would put the man pages to -devel, but

[Bug 1563680] Package Review: libocxl library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 --- Comment #9 from Michel Normand --- done -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

[Bug 1563680] Package Review: libocxl library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 --- Comment #8 from Dan Horák --- If we won't plan to include libocxl to F-27 (and I think it's not necessary, F-28+ should be good), then you can remove the ldconfig scriptlets. -- You are receiving this mail because: You

[Bug 1563680] Package Review: libocxl library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 --- Comment #7 from Michel Normand --- spec and srpm updated from Robert-Andre's review spec: https://michelmno.fedorapeople.org/libocxl/libocxl.spec srpm:

[Bug 1563680] Package Review: libocxl library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 --- Comment #6 from Dan Horák --- Just add "BuildArch: noarch" into the "%package docs" section. I agree with Robert-Andre's review, but you should be able to drop the "ldconfig" stuff completely as standard stuff is handled

[Bug 1563680] Package Review: libocxl library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 --- Comment #5 from Michel Normand --- (In reply to Michel Normand from comment #4) > > Thank your for all comments; > Question: how to define in spec the *-docs subpackage as noarch package ? > while other

[Bug 1563680] Package Review: libocxl library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 --- Comment #4 from Michel Normand --- (In reply to Robert-André Mauchin from comment #3) > [CUT] ... > Actually since it seems to be documentation, I believe it should be > installed in %{_pkgdocdir} (i.e

[Bug 1563680] Package Review: libocxl library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 --- Comment #3 from Robert-André Mauchin --- - Please add a comment for each patch explaining what they do - Use the new %ldconfig_scriptlets macro instead of: %post -p /sbin/ldconfig %postun -p /sbin/ldconfig See

[Bug 1563680] Package Review: libocxl library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 Hanns-Joachim Uhl changed: What|Removed |Added Blocks||1523862

[Bug 1563680] Package Review: libocxl library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 Hanns-Joachim Uhl changed: What|Removed |Added CC|

[Bug 1563680] Package Review: libocxl library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 Dan Horák changed: What|Removed |Added Status|NEW |ASSIGNED

[Bug 1563680] Package Review: libocxl library for OpenCAPI accelerator

https://bugzilla.redhat.com/show_bug.cgi?id=1563680 Michel Normand changed: What|Removed |Added CC|