[Bug 1711611] Review Request: pdfarranger - PDF file merging, rearranging, and splitting. Maintained fork of pdfshuffler
https://bugzilla.redhat.com/show_bug.cgi?id=1711611 --- Comment #19 from Fedora Update System --- pdfarranger-1.3.0-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1711611] Review Request: pdfarranger - PDF file merging, rearranging, and splitting. Maintained fork of pdfshuffler
https://bugzilla.redhat.com/show_bug.cgi?id=1711611 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2019-09-16 00:01:50 --- Comment #18 from Fedora Update System --- pdfarranger-1.3.0-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1711611] Review Request: pdfarranger - PDF file merging, rearranging, and splitting. Maintained fork of pdfshuffler
https://bugzilla.redhat.com/show_bug.cgi?id=1711611 --- Comment #17 from Fedora Update System --- pdfarranger-1.3.0-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-363ee0b8a9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1711611] Review Request: pdfarranger - PDF file merging, rearranging, and splitting. Maintained fork of pdfshuffler
https://bugzilla.redhat.com/show_bug.cgi?id=1711611 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #16 from Fedora Update System --- pdfarranger-1.3.0-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-13eff29405 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1711611] Review Request: pdfarranger - PDF file merging, rearranging, and splitting. Maintained fork of pdfshuffler
https://bugzilla.redhat.com/show_bug.cgi?id=1711611 --- Comment #15 from Fedora Update System --- FEDORA-2019-363ee0b8a9 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-363ee0b8a9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1711611] Review Request: pdfarranger - PDF file merging, rearranging, and splitting. Maintained fork of pdfshuffler
https://bugzilla.redhat.com/show_bug.cgi?id=1711611 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #14 from Fedora Update System --- FEDORA-2019-13eff29405 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-13eff29405 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1711611] Review Request: pdfarranger - PDF file merging, rearranging, and splitting. Maintained fork of pdfshuffler
https://bugzilla.redhat.com/show_bug.cgi?id=1711611 --- Comment #13 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/pdfarranger -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1711611] Review Request: pdfarranger - PDF file merging, rearranging, and splitting. Maintained fork of pdfshuffler
https://bugzilla.redhat.com/show_bug.cgi?id=1711611
Felix Schwarz changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #12 from Felix Schwarz ---
Package approved - please fix the missing requirement before pushing a build.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
== Issues / comments ==
- missing requirement: "poppler-glib"
- I think %{?python_provide:%python_provide python3-%{name}} is not necessary
here.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GNU General Public License (v3 or
later)", "*No copyright* GNU General Public License (v3 or later)",
"GPL (v3 or later)". 23 files have unknown license. Detailed output of
licensecheck in …/1711611-pdfarranger/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to
[Bug 1711611] Review Request: pdfarranger - PDF file merging, rearranging, and splitting. Maintained fork of pdfshuffler
https://bugzilla.redhat.com/show_bug.cgi?id=1711611 Felix Schwarz changed: What|Removed |Added Assignee|zebo...@gmail.com |fschw...@fedoraproject.org Flags|fedora-review+ |fedora-review? --- Comment #11 from Felix Schwarz --- Taking over from Robert-André to get this review unblocked. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1711611] Review Request: pdfarranger - PDF file merging, rearranging, and splitting. Maintained fork of pdfshuffler
https://bugzilla.redhat.com/show_bug.cgi?id=1711611 --- Comment #10 from David Auer --- I tagged the wrong commit in my Github, sorry for the spam: Spec URL: https://raw.githubusercontent.com/dreua/pdfarranger-rpmspec/1.3.0-1-fixed/pdfarranger.spec SRPM URL: https://github.com/dreua/pdfarranger-rpmspec/releases/download/1.3.0-1-fixed/pdfarranger-1.3.0-1.fc30.src.rpm Diff: https://github.com/dreua/pdfarranger-rpmspec/compare/1.2.1-7...1.3.0-1-fixed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1711611] Review Request: pdfarranger - PDF file merging, rearranging, and splitting. Maintained fork of pdfshuffler
https://bugzilla.redhat.com/show_bug.cgi?id=1711611 --- Comment #9 from David Auer --- @Paul: Thank you for sponsoring me! @Robert-André: It seems like this has been approved for too long, can you re-approve? >$ fedpkg request-repo pdfarranger 1711611 >Could not execute request_repo: The Bugzilla bug's review was approved over 60 >days ago I have already updated the spec with the latest release, just in case you want to have a look: Spec URL: https://raw.githubusercontent.com/dreua/pdfarranger-rpmspec/1.3.0-1/pdfarranger.spec SRPM URL: https://github.com/dreua/pdfarranger-rpmspec/releases/download/1.3.0-1/pdfarranger-1.3.0-1.fc30.src.rpm Diff: https://github.com/dreua/pdfarranger-rpmspec/commit/82c9f681a3176cef85973f8fae5bc13b99482c86 It builds, works and rpmlint is still happy. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1711611] Review Request: pdfarranger - PDF file merging, rearranging, and splitting. Maintained fork of pdfshuffler
https://bugzilla.redhat.com/show_bug.cgi?id=1711611 Paul Howarth changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1711611] Review Request: pdfarranger - PDF file merging, rearranging, and splitting. Maintained fork of pdfshuffler
https://bugzilla.redhat.com/show_bug.cgi?id=1711611 Paul Howarth changed: What|Removed |Added CC||p...@city-fan.org --- Comment #8 from Paul Howarth --- I will sponsor David. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1711611] Review Request: pdfarranger - PDF file merging, rearranging, and splitting. Maintained fork of pdfshuffler
https://bugzilla.redhat.com/show_bug.cgi?id=1711611 Fabian Affolter changed: What|Removed |Added CC||m...@fabian-affolter.ch --- Comment #7 from Fabian Affolter --- FYI, pdfshuffler will be retired soon as there are no effort to port it to Python 3 and it depends on pypoppler (which is also not ported to Python 3). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1711611] Review Request: pdfarranger - PDF file merging, rearranging, and splitting. Maintained fork of pdfshuffler
https://bugzilla.redhat.com/show_bug.cgi?id=1711611 --- Comment #6 from David Auer --- I'd like to take Felix Schwarz's offer to take this package as a maintainer and add me as co-maintainer afterwards since I haven't been able to take the steps required for sponsorship yet. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1711611] Review Request: pdfarranger - PDF file merging, rearranging, and splitting. Maintained fork of pdfshuffler
https://bugzilla.redhat.com/show_bug.cgi?id=1711611 --- Comment #5 from David Auer --- Thank you so much for reviewing and for the better source URL, I already changed the spec accordingly and did another successful test build! I will try to do some unofficial reviews as soon as possible and hope to get sponsored. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1711611] Review Request: pdfarranger - PDF file merging, rearranging, and splitting. Maintained fork of pdfshuffler
https://bugzilla.redhat.com/show_bug.cgi?id=1711611 Robert-André Mauchin changed: What|Removed |Added Summary|Review Request: |Review Request: pdfarranger |python-pdfarranger - PDF|- PDF file merging, |file merging, rearranging, |rearranging, and splitting. |and splitting. Maintained |Maintained fork of |fork of pdfshuffler |pdfshuffler -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
