Product: Fedora
Version: rawhide
Component: Package Review
Package Review has canceled Package
Review 's request for Wart
's needinfo:
Bug 1739290: Review Request: angband - Text-based roguelike RPG game
https://bugzilla.redhat.com/show_bug.cgi?id=1739290
--- Comment #16 from Package Review
https://bugzilla.redhat.com/show_bug.cgi?id=1739290
Wart changed:
What|Removed |Added
Blocks||1364745 (FE-GAMESIG)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1739290
--- Comment #14 from Wart ---
Updated files to address issues in the above review:
https://fedorapeople.org/~wart/angband-4.2.0-1.fc30.src.rpm
https://fedorapeople.org/~wart/angband.spec
The license comments made me take a closer look, and
https://bugzilla.redhat.com/show_bug.cgi?id=1739290
--- Comment #13 from Wart ---
(In reply to J. Scheurich from comment #9)
> %changelog
> * Tue Aug 13 2019 Wart 4.1.3-4
> - Use recommended dynamic allocation for the group%changelog
>
> shouldn't is be
>
> %changelog
> * Tue Aug 13 2019
https://bugzilla.redhat.com/show_bug.cgi?id=1739290
--- Comment #12 from Wart ---
(In reply to J. Scheurich from comment #11)
> Shouldn't you create %{_datadir}/icons/hicolor/32x32/apps/ ?
>
> %files
> ...
> %dir %{_datadir}/icons/hicolor/32x32/apps/
>
https://bugzilla.redhat.com/show_bug.cgi?id=1739290
--- Comment #11 from J. Scheurich ---
Shouldn't you create %{_datadir}/icons/hicolor/32x32/apps/ ?
%files
...
%dir %{_datadir}/icons/hicolor/32x32/apps/
%{_datadir}/icons/hicolor/32x32/apps/%{name}.png
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=1739290
--- Comment #10 from J. Scheurich ---
This only a informal review, i aam not in the packager group 8-(
Sorry to add the review twice, but the first was incomplete
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not
https://bugzilla.redhat.com/show_bug.cgi?id=1739290
--- Comment #9 from J. Scheurich ---
%changelog
* Tue Aug 13 2019 Wart 4.1.3-4
- Use recommended dynamic allocation for the group%changelog
shouldn't is be
%changelog
* Tue Aug 13 2019 Wart 4.1.3-4
- Use recommended dynamic allocation for
https://bugzilla.redhat.com/show_bug.cgi?id=1739290
--- Comment #8 from J. Scheurich ---
Licence shuold be something like
License: GPLv2 and LGPLv3+ and BSD
$ more angband-4.1.3/src/win/include/png.h
...
* Permission is hereby granted to use, copy, modify, and distribute this
* source
https://bugzilla.redhat.com/show_bug.cgi?id=1739290
--- Comment #7 from J. Scheurich ---
Maybe you should sove:
rpm -i rpmbuild/RPMS/x86_64/angband-4.1.3-4.fc30.x86_64.rpm
warning: group angband does not exist - using root
warning: group angband does not exist - using root
warning: group
https://bugzilla.redhat.com/show_bug.cgi?id=1739290
--- Comment #6 from J. Scheurich ---
This only a informal review, i aam not in the packager group 8-(
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
https://bugzilla.redhat.com/show_bug.cgi?id=1739290
J. Scheurich changed:
What|Removed |Added
CC||muft...@web.de
--- Comment #5 from J.
https://bugzilla.redhat.com/show_bug.cgi?id=1739290
--- Comment #4 from Wart ---
Updated spec and src rpm based to fix the issues described in comment #3:
https://wart.fedorapeople.org/angband.spec
https://wart.fedorapeople.org/angband-4.1.3-4.fc30.src.rpm
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=1739290
Elliott Sales de Andrade changed:
What|Removed |Added
CC||quantum.anal...@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1739290
--- Comment #2 from Wart ---
Updated spec and src rpm based on the feedback:
https://wart.fedorapeople.org/angband.spec
https://wart.fedorapeople.org/angband-4.1.3-3.fc30.src.rpm
--
You are receiving this mail because:
You are on the CC
https://bugzilla.redhat.com/show_bug.cgi?id=1739290
Artur Iwicki changed:
What|Removed |Added
CC||fed...@svgames.pl
--- Comment #1 from
16 matches
Mail list logo
