[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos

2020-02-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 --- Comment #22 from Fedora Update System --- git-secrets-1.3.0-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are

[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos

2020-02-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|---

[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos

2020-01-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 --- Comment #20 from Fedora Update System --- git-secrets-1.3.0-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See

[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos

2020-01-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #19 from

[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos

2020-01-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #18 from

[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos

2020-01-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 --- Comment #17 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/git-secrets -- You are receiving this mail because: You are on the CC list for the bug. You are always notified

[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos

2020-01-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 Elliott Sales de Andrade changed: What|Removed |Added Status|ASSIGNED|POST

[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos

2020-01-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 --- Comment #15 from Kees de Jong --- Seems like I need to read those docs again. Below are the correct links. Spec URL: https://raw.githubusercontent.com/AquaL1te/git-secrets/master/git-secrets.spec SRPM URL:

[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos

2020-01-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 --- Comment #14 from Elliott Sales de Andrade --- (In reply to Kees de Jong from comment #11) > > You shouldn't use internal macros like %__make; just run make directly. > Is there a reason for this? If the macro exists, then it can be used,

[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos

2020-01-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 --- Comment #13 from Elliott Sales de Andrade --- fedora-review 404s downloading those links. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos

2020-01-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 --- Comment #12 from Kees de Jong --- I copy pasted the URLs from the top of the thread, which did not contain the raw links. Below are the raw links. Spec URL: https://raw.githubusercontent.com/AquaL1te/git-secrets/master/git-secrets.spec

[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos

2020-01-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 --- Comment #11 from Kees de Jong --- > You shouldn't use internal macros like %__make; just run make directly. Is there a reason for this? If the macro exists, then it can be used, right? I haven't read anything about this in the maintainer

[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos

2019-11-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 --- Comment #10 from Elliott Sales de Andrade --- If you need git at build time, do you not need it at runtime, too? Also, do you need full git, or can git-core work? -- You are receiving this mail because: You are on the CC list for the

[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos

2019-11-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 --- Comment #9 from Elliott Sales de Andrade --- You shouldn't use internal macros like %__make; just run make directly. Also, remember to link both spec and srpm. -- You are receiving this mail because: You are on the CC list for the bug.

[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos

2019-11-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 --- Comment #8 from Kees de Jong --- Thanks! I forgot about that option. I've included the %check and your other suggestions. The changes are included in git. The `make test` runs without errors. New koji build:

[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos

2019-11-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 Elliott Sales de Andrade changed: What|Removed |Added Status|NEW |ASSIGNED

[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos

2019-11-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 --- Comment #6 from Kees de Jong --- (In reply to Elliott Sales de Andrade from comment #4) > The links you've used go to a GitHub webpage; they need to point directly to > the raw file. Use the Download button on GitHub to get it. > > In

[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos

2019-11-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 --- Comment #4 from Elliott Sales de Andrade --- The links you've used go to a GitHub webpage; they need to point directly to the raw file. Use the Download button on GitHub to get it. In the Makefile, PREFIX is set using ?=, which means it

[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos

2019-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 --- Comment #3 from Kees de Jong --- (In reply to Elliott Sales de Andrade from comment #2) > Can you not do `%make_build PREFIX=%{_prefix}` (not %{_usr}!)? > > Also, please use raw links so fedora-review works. Please define what you mean

[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos

2019-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 Elliott Sales de Andrade changed: What|Removed |Added CC||quantum.anal...@gmail.com

[Bug 1768192] Review Request: git-secrets - Prevents committing secrets and credentials into git repos

2019-11-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1768192 --- Comment #1 from Kees de Jong --- Upstream repo: https://github.com/awslabs/git-secrets -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component