[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds

2020-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1787069

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2020-02-24 01:34:35



--- Comment #17 from Fedora Update System  ---
ddnet-12.9.1-1.fc31 has been pushed to the Fedora 31 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds

2020-02-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1787069

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA



--- Comment #16 from Fedora Update System  ---
ddnet-12.9.1-1.fc31 has been pushed to the Fedora 31 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-5fe952b925

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds

2020-02-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1787069



--- Comment #15 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ddnet

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds

2020-02-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1787069



--- Comment #14 from Michael  ---
Updated spec file:
Spec URL:
https://raw.githubusercontent.com/ElXreno/ddnet/d793394035fd23d1966afdb8069cd6225aa1baef/ddnet.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/5213/41495213/ddnet-12.9.1-1.fc31.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds

2020-02-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1787069



--- Comment #13 from Artem  ---
(In reply to Vasiliy Glazov from comment #12)
> 2. Change %{optflags} -flto
> to
> %{optflags} -flto=auto

This will makes non reproducible builds. Don't do this and don't push with
'auto' in repos.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds

2020-02-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1787069

Vasiliy Glazov  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds

2020-02-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1787069

Vasiliy Glazov  changed:

   What|Removed |Added

 CC||vasc...@gmail.com



--- Comment #12 from Vasiliy Glazov  ---
I will sponsor you.

1. Please update to latest version - 12.9.1.
2. Change %{optflags} -flto
to
%{optflags} -flto=auto
3. Remove
%license license.txt
%doc README.md
from %files server

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds

2020-01-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1787069



--- Comment #11 from Michael  ---
Oh yes, I missed this. Thank you for your review and your help!

Spec URL:
https://raw.githubusercontent.com/ElXreno/ddnet/042238f5c09be3f1cc9d099a29634d04c2a3/ddnet.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/2153/40052153/ddnet-12.8.1-6.fc31.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds

2020-01-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1787069

Artem  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #10 from Artem  ---
Few minor issues:

1. '%{_mandir}/man.6/' is incorrect place. Should been '%{_mandir}/man6/'

install -Dp -m 0644 man/DDNet.6 %{buildroot}%{_mandir}/man6/DDNet.6
install -Dp -m 0644 man/DDNet-Server.6
%{buildroot}%{_mandir}/man6/DDNet-Server.6


2. BSD license not needed anymore since you unbundled 'json-parser'. You need
to remove it from License tag and from breakdown license explanation section.

Please fix this before import. Otherwise LGTM.


Rpmlint
---
Checking: ddnet-12.8.1-6.fc32.x86_64.rpm
  ddnet-data-12.8.1-6.fc32.noarch.rpm
  ddnet-server-12.8.1-6.fc32.x86_64.rpm
  ddnet-debuginfo-12.8.1-6.fc32.x86_64.rpm
  ddnet-debugsource-12.8.1-6.fc32.x86_64.rpm
  ddnet-12.8.1-6.fc32.src.rpm
ddnet.x86_64: W: spelling-error %description -l en_US gameplay -> game play,
game-play, nameplate
ddnet-data.noarch: W: no-documentation
ddnet-data.noarch: W: pem-certificate /usr/share/ddnet/data/ca-ddnet.pem
ddnet.src: W: spelling-error %description -l en_US gameplay -> game play,
game-play, nameplate
ddnet.src:95: W: unversioned-explicit-provides
bundled(dejavu-sans-cjkname-fonts)
ddnet.src:96: W: unversioned-explicit-provides
bundled(dejavu-wenquanyi-micro-hei-fonts)
6 packages and 0 specfiles checked; 0 errors, 6 warnings.




Rpmlint (debuginfo)
---
Checking: ddnet-server-debuginfo-12.8.1-6.fc32.x86_64.rpm
  ddnet-debuginfo-12.8.1-6.fc32.x86_64.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)

perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = (unset),
LC_CTYPE = "C.UTF-8",
LANG = "ru_UA.UTF-8"
are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = (unset),
LC_CTYPE = "C.UTF-8",
LANG = "ru_UA.UTF-8"
are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
ddnet-data.noarch: W: no-documentation
ddnet-data.noarch: W: pem-certificate /usr/share/ddnet/data/ca-ddnet.pem
ddnet.x86_64: W: spelling-error %description -l en_US gameplay -> game play,
game-play, nameplate
6 packages and 0 specfiles checked; 0 errors, 3 warnings.



Source checksums

https://github.com/ddnet/ddnet/archive/12.8.1/ddnet-12.8.1.tar.gz :
  CHECKSUM(SHA256) this package :
139e28f02f11569c1adc6119e9eaf732916ea56c4c84c6af10f9fab94e4abfb4
  CHECKSUM(SHA256) upstream package :
139e28f02f11569c1adc6119e9eaf732916ea56c4c84c6af10f9fab94e4abfb4


Requires

ddnet (rpmlib, GLIBC filtered):
ddnet-data
libGL.so.1()(64bit)
libGLEW.so.2.1()(64bit)
libGLU.so.1()(64bit)
libSDL2-2.0.so.0()(64bit)
libX11.so.6()(64bit)
libc.so.6()(64bit)
libcrypto.so.1.1()(64bit)
libcrypto.so.1.1(OPENSSL_1_1_0)(64bit)
libcurl.so.4()(64bit)
libfreetype.so.6()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libgcc_s.so.1(GCC_3.3.1)(64bit)
libjsonparser.so.1.1()(64bit)
libm.so.6()(64bit)
libopusfile.so.0()(64bit)
libpnglite.so.0()(64bit)
libpthread.so.0()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
libstdc++.so.6(CXXABI_1.3.8)(64bit)
libwavpack.so.1()(64bit)
libz.so.1()(64bit)
libz.so.1(ZLIB_1.2.0)(64bit)
rtld(GNU_HASH)

ddnet-data (rpmlib, GLIBC filtered):
ddnet
hicolor-icon-theme

ddnet-server (rpmlib, GLIBC filtered):
ddnet(x86-64)
libc.so.6()(64bit)
libcrypto.so.1.1()(64bit)
libcrypto.so.1.1(OPENSSL_1_1_0)(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libgcc_s.so.1(GCC_3.3.1)(64bit)
libjsonparser.so.1.1()(64bit)
libm.so.6()(64bit)
libpthread.so.0()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
libstdc++.so.6(CXXABI_1.3.8)(64bit)
libz.so.1()(64bit)
libz.so.1(ZLIB_1.2.0)(64bit)
rtld(GNU_HASH)

ddnet-debuginfo (rpmlib, GLIBC filtered):

ddnet-debugsource (rpmlib, GLIBC filtered):



Provides

ddnet:
application()
application(ddnet.desktop)
bundled(dejavu-sans-cjkname-fonts)
bundled(dejavu-wenquanyi-micro-hei-fonts)
ddnet
ddnet(x86-64)
metainfo()
metainfo(ddnet.appdata.xml)
mimehandler(x-scheme-handler/ddnet)

ddnet-data:
ddnet-data

ddnet-server:
ddnet-server
ddnet-server(x86-64)

ddnet-debuginfo:
ddnet-debuginfo
ddnet-debuginfo(x86-64)
debuginfo(build-id)


[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds

2020-01-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1787069



--- Comment #9 from Michael  ---
Spec URL:
https://raw.githubusercontent.com/ElXreno/ddnet/443e001a8d1ee20c985123ece1718cd31086a23f/ddnet.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/1107/40051107/ddnet-12.8.1-6.fc31.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds

2020-01-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1787069



--- Comment #8 from Michael  ---
Thanks for your patch. I applied it.

Also, now I can provide ddnet without bundled md5 and json-parser (thanks
upstream for help with it, issue url: [1]).
[1] https://github.com/ddnet/ddnet/issues/2022

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds

2019-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1787069



--- Comment #7 from Artem  ---
> Also json-parser is bundled, but I think it's temporarily because json-parser 
> package
in Fedora repos doesn't provide json.c file, but it requires for proper build.

'json-parser' available in Fedora repos. You need to investigate why it won't
build with system package. It is patched by upstream or need to fix cmake file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds

2019-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1787069



--- Comment #6 from Artem  ---
Created attachment 1649026
  --> https://bugzilla.redhat.com/attachment.cgi?id=1649026=edit
spec file

LGTM. Few minor issues:

* Please add license breakdown explanation. See example [1] spec file.
  [1]
https://src.fedoraproject.org/rpms/chatterino2/blob/master/f/chatterino2.spec#_40

* Add version for bundled libs:
  Provides:   bundled(json-parser) = 1.1.0
  Provides:   bundled(md5) = 1.6

* Drop 'Requires:   hicolor-icon-theme' for main, non-data package. You
don't need it here.

* You can grab patch directly from GitHub
  Patch2:
https://github.com/ddnet/ddnet/pull/2021.patch#/0002-add-appdata-manifest.patch

* Please add comment describing why necessary patch or what it doing

  # Some commentary
  Patch1: 0001_ddnet_Disabled-network-lookup-test.patch

* Add %{_target_platform} macros.


Check my attached patch for this and other cosmetic improvements.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds

2019-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1787069



--- Comment #5 from Michael  ---
Spec URL:
https://raw.githubusercontent.com/ElXreno/ddnet/db03b62a57571259181d03cc6727a2c46858d386/ddnet.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/684/40010684/ddnet-12.8.1-5.fc31.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds

2019-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1787069



--- Comment #4 from Michael  ---
1. Ok. Now all devel packages now uses pkgconfig besides pnglite-devel.

2. Fixed and now available in upstream.

3. Probably no, because libmysqlcppconn is not available in Fedora repos,
and it not works with mariadb-connector-c-devel. I ask upstream what to do with
it.

4. Working on it.

5. Fixed.

6. Fixed.

7. Fixed.

8. Cannot unbundle md5 because it not available in Fedora repos.
Also json-parser is bundled, but I think it's temporarily because json-parser
package
in Fedora repos doesn't provide json.c file, but it requires for proper build.
I ask upstream about it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds

2019-12-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1787069



--- Comment #3 from Artem  ---
8. Try to delete whole 'src/engine/external/' in '%prep' to be sure that
nothing is bundled here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds

2019-12-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1787069



--- Comment #2 from Artem  ---
5. The license should be probably:
   zlib and CC-BY-SA and ASL 2.0 and MIT and Public Domain and BSD

   Please explaining the multiple licensing breakdown in spec file
  
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/

6. You need to own all directories. In this case you should move
   'Requires:   hicolor-icon-theme'
   to
   '-data' subpackage section.

7. Move
   %{_datadir}/applications/%{name}.desktop
   to
   main package:

   %files
   %{_datadir}/applications/%{name}.desktop

---

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
 BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "zlib/libpng license Apache License
 (v2.0) Creative Commons Attribution-ShareAlike Public License (v3.0)",
 "Expat License", "zlib/libpng license", "*No copyright* Creative
 Commons Attribution-ShareAlike Public License (v3.0)", "*No copyright*
 Public domain", "Khronos License Expat License BSD 2-clause
 "Simplified" License", "BSD 2-clause "Simplified" License",
 "zlib/libpng license Aladdin Free Public License", "BSD 3-clause "New"
 or "Revised" License", "Expat License BSD 2-clause "Simplified"
 License", "Khronos License BSD 2-clause "Simplified" License". 1208
 files have unknown license. Detailed output of licensecheck in
 /mnt/data-linux/tmp/review/1787069-ddnet/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/icons/hicolor,
 /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/512x512,
 /usr/share/man/man.6, /usr/share/icons/hicolor/16x16/apps,
 /usr/share/icons/hicolor/512x512/apps,
 /usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor/32x32/apps,
 /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/128x128/apps,
 /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/16x16,
 /usr/share/icons/hicolor/48x48/apps,
 /usr/share/icons/hicolor/256x256/apps
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/share/ddnet(defaulting,
 Failed, C, locale,, set, to), /usr/share/ddnet/data(defaulting,
 Failed, C, locale,, set, to), /usr/share/ddnet/data/audio(defaulting,
 Failed, C, locale,, set, to),
 /usr/share/ddnet/data/countryflags(defaulting, Failed, C, locale,,
 set, to), /usr/share/ddnet/data/editor(defaulting, Failed, C, locale,,
 set, to), /usr/share/ddnet/data/editor/entities(defaulting, Failed, C,
 locale,, set, to),
 /usr/share/ddnet/data/editor/entities_clear(defaulting, Failed, C,
 locale,, set, to), /usr/share/ddnet/data/fonts(defaulting, Failed, C,
 locale,, set, to), /usr/share/ddnet/data/languages(defaulting, Failed,
 C, locale,, set, to), /usr/share/ddnet/data/mapres(defaulting, Failed,
 C, locale,, set, to), /usr/share/ddnet/data/maps(defaulting, Failed,
 C, locale,, set, to), /usr/share/ddnet/data/shader(defaulting, Failed,
 C, locale,, set, to), /usr/share/ddnet/data/skins(defaulting, Failed,
 C, locale,, set, to), /usr/share/doc/ddnet-server(defaulting, Failed,
 C, locale,, set, to), /usr/share/licenses/ddnet-server(defaulting,
 Failed, C, locale,, set, to), /usr/lib64/ddnet(defaulting, Failed, C,
 locale,, set, to), /usr/share/doc/ddnet(defaulting, Failed, C,
 locale,, set, to), /usr/share/licenses/ddnet(defaulting, Failed, C,
 locale,, set, to)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.

[Bug 1787069] Review Request: ddnet - DDraceNetwork, a cooperative racing mod of Teeworlds

2019-12-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1787069

Artem  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ego.corda...@gmail.com
 Blocks||177841 (FE-NEEDSPONSOR)
   Assignee|nob...@fedoraproject.org|ego.corda...@gmail.com
   Doc Type|--- |If docs needed, set a value
  Flags||fedora-review?



--- Comment #1 from Artem  ---
1. Recommended to use pkgconfig for -devel packages
  
https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/#_buildrequires_pkgconfigfoo_vs_foo_devel

2. Recommended to write AppData manifest file and send it upstream
   https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/

3. Maybe add BR: mysql for 'server' package?
   -DMYSQL=[ON|OFF]
   https://github.com/ddnet/ddnet#building-on-linux-and-macos

4. You need to find a sponsor
   https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org