[Bug 1798797] Review Request: ocaml-ppx-tools - Tools for authors of ppx rewriters
https://bugzilla.redhat.com/show_bug.cgi?id=1798797 Jerry James changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2020-02-12 16:33:17 --- Comment #6 from Jerry James --- Built in Rawhide and F32. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798797] Review Request: ocaml-ppx-tools - Tools for authors of ppx rewriters
https://bugzilla.redhat.com/show_bug.cgi?id=1798797 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-ppx-tools -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798797] Review Request: ocaml-ppx-tools - Tools for authors of ppx rewriters
https://bugzilla.redhat.com/show_bug.cgi?id=1798797
--- Comment #4 from Jerry James ---
Thank you for the review, Ankur!
(In reply to Ankur Sinha (FranciscoD) from comment #2)
> I have a few nitpicks where the spec doesn't match the example spec in the
> guidelines (which doesn't look to up to date). Please do just check on them
> before importing:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/OCaml/
>
> - Should it be BR: ocaml-findlib-devel (even though it builds fine, so
> probably
> not)?
No, we only need the commandline tool "ocamlfind" from the ocaml-findlib
package. We do not need to link to the actual library, which is what
ocaml-findlib-devel enables.
> - Are the _use_internal_dependency_generator etc. bits mentioned in the
> example
> spec not needed?
Good grief, those should have been removed a long time ago. No, those should
not be used anymore.
> - I can't find much information about the cmxs file, so I don't know if it
> should be included or not.
The cmxs files are the OCaml versions of a shared library. On architectures
where OCaml is able to build them ("%ifarch %{ocaml_native_compiler}"), they
should be included.
> - The build.log file shows some warnings/errors related to debuginfo
> generation. They may not be related to the package:
Dan commented on this. Thank you, Ankur!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798797] Review Request: ocaml-ppx-tools - Tools for authors of ppx rewriters
https://bugzilla.redhat.com/show_bug.cgi?id=1798797 --- Comment #3 from dan.cer...@cgc-instruments.com --- (In reply to Ankur Sinha (FranciscoD) from comment #2) > > - The build.log file shows some warnings/errors related to debuginfo > generation. They may not be related to the package: > > Exception caught while booting Guile. > /usr/bin/gdb.minimal: warning: Could not complete Guile gdb module > initialization from: > /usr/share/gdb/guile/gdb/boot.scm. > Limited Guile support is available. > Suggest passing --data-directory=/path/to/gdb/data-directory. > Error in function "open-file": > No such file or directory: "/usr/share/gdb/guile/gdb/boot.scm"Exception > caught while booting Guile. > /usr/bin/gdb.minimal: warning: Could not complete Guile gdb module > initialization from: > /usr/share/gdb/guile/gdb/boot.scm. > Limited Guile support is available. > Suggest passing --data-directory=/path/to/gdb/data-directory. > Exception caught while booting Guile. > /usr/bin/gdb.minimal: warning: Could not complete Guile gdb module > initialization from: > /usr/share/gdb/guile/gdb/boot.scm. > Limited Guile support is available. > Suggest passing --data-directory=/path/to/gdb/data-directory. > Exception caught while booting Guile. > /usr/bin/gdb.minimal: warning: Could not complete Guile gdb module > initialization from: > /usr/share/gdb/guile/gdb/boot.scm. > Limited Guile support is available. > Suggest passing --data-directory=/path/to/gdb/data-directory. > Exception caught while booting Guile. > /usr/bin/gdb.minimal: warning: Could not complete Guile gdb module > initialization from: > /usr/share/gdb/guile/gdb/boot.scm. > Limited Guile support is available. > Suggest passing --data-directory=/path/to/gdb/data-directory. > Error in function "open-file": > No such file or directory: "/usr/share/gdb/guile/gdb/boot.scm"Error in > function "open-file": > No such file or directory: "/usr/share/gdb/guile/gdb/boot.scm"Error in > function "open-file": > No such file or directory: "/usr/share/gdb/guile/gdb/boot.scm"Error in > function "open-file": > No such file or directory: "/usr/share/gdb/guile/gdb/boot.scm"original debug > info size: 7760kB, size after compression: 7764kB > /usr/lib/rpm/sepdebugcrcfix: Updated 5 CRC32s, 0 CRC32s did match. > cpio: bytes.ml: Cannot stat: No such file or directory > cpio: hashtbl.ml: Cannot stat: No such file or directory > cpio: list.ml: Cannot stat: No such file or directory > cpio: parsing/ast_helper.ml: Cannot stat: No such file or directory > cpio: parsing/ast_mapper.ml: Cannot stat: No such file or directory > cpio: parsing/location.ml: Cannot stat: No such file or directory > cpio: parsing/longident.ml: Cannot stat: No such file or directory > cpio: parsing/parse.ml: Cannot stat: No such file or directory > cpio: parsing/pprintast.ml: Cannot stat: No such file or directory > cpio: printexc.ml: Cannot stat: No such file or directory > cpio: printf.ml: Cannot stat: No such file or directory > cpio: utils/load_path.ml: Cannot stat: No such file or directory > 262 blocks This is probably related to this bugd https://bugzilla.redhat.com/show_bug.cgi?id=1801144 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798797] Review Request: ocaml-ppx-tools - Tools for authors of ppx rewriters
https://bugzilla.redhat.com/show_bug.cgi?id=1798797 Ankur Sinha (FranciscoD) changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #2 from Ankur Sinha (FranciscoD) --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === Looks good. XXX APPROVED XXX I have a few nitpicks where the spec doesn't match the example spec in the guidelines (which doesn't look to up to date). Please do just check on them before importing: https://docs.fedoraproject.org/en-US/packaging-guidelines/OCaml/ - Should it be BR: ocaml-findlib-devel (even though it builds fine, so probably not)? - Are the _use_internal_dependency_generator etc. bits mentioned in the example spec not needed? - I can't find much information about the cmxs file, so I don't know if it should be included or not. - The build.log file shows some warnings/errors related to debuginfo generation. They may not be related to the package: Exception caught while booting Guile. /usr/bin/gdb.minimal: warning: Could not complete Guile gdb module initialization from: /usr/share/gdb/guile/gdb/boot.scm. Limited Guile support is available. Suggest passing --data-directory=/path/to/gdb/data-directory. Error in function "open-file": No such file or directory: "/usr/share/gdb/guile/gdb/boot.scm"Exception caught while booting Guile. /usr/bin/gdb.minimal: warning: Could not complete Guile gdb module initialization from: /usr/share/gdb/guile/gdb/boot.scm. Limited Guile support is available. Suggest passing --data-directory=/path/to/gdb/data-directory. Exception caught while booting Guile. /usr/bin/gdb.minimal: warning: Could not complete Guile gdb module initialization from: /usr/share/gdb/guile/gdb/boot.scm. Limited Guile support is available. Suggest passing --data-directory=/path/to/gdb/data-directory. Exception caught while booting Guile. /usr/bin/gdb.minimal: warning: Could not complete Guile gdb module initialization from: /usr/share/gdb/guile/gdb/boot.scm. Limited Guile support is available. Suggest passing --data-directory=/path/to/gdb/data-directory. Exception caught while booting Guile. /usr/bin/gdb.minimal: warning: Could not complete Guile gdb module initialization from: /usr/share/gdb/guile/gdb/boot.scm. Limited Guile support is available. Suggest passing --data-directory=/path/to/gdb/data-directory. Error in function "open-file": No such file or directory: "/usr/share/gdb/guile/gdb/boot.scm"Error in function "open-file": No such file or directory: "/usr/share/gdb/guile/gdb/boot.scm"Error in function "open-file": No such file or directory: "/usr/share/gdb/guile/gdb/boot.scm"Error in function "open-file": No such file or directory: "/usr/share/gdb/guile/gdb/boot.scm"original debug info size: 7760kB, size after compression: 7764kB /usr/lib/rpm/sepdebugcrcfix: Updated 5 CRC32s, 0 CRC32s did match. cpio: bytes.ml: Cannot stat: No such file or directory cpio: hashtbl.ml: Cannot stat: No such file or directory cpio: list.ml: Cannot stat: No such file or directory cpio: parsing/ast_helper.ml: Cannot stat: No such file or directory cpio: parsing/ast_mapper.ml: Cannot stat: No such file or directory cpio: parsing/location.ml: Cannot stat: No such file or directory cpio: parsing/longident.ml: Cannot stat: No such file or directory cpio: parsing/parse.ml: Cannot stat: No such file or directory cpio: parsing/pprintast.ml: Cannot stat: No such file or directory cpio: printexc.ml: Cannot stat: No such file or directory cpio: printf.ml: Cannot stat: No such file or directory cpio: utils/load_path.ml: Cannot stat: No such file or directory 262 blocks = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [-]: %build honors applicable compiler flags or justifies otherwise. ^ I don't see anything in the Ocaml packaging guidelines about build flags. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named a
[Bug 1798797] Review Request: ocaml-ppx-tools - Tools for authors of ppx rewriters
https://bugzilla.redhat.com/show_bug.cgi?id=1798797 Ankur Sinha (FranciscoD) changed: What|Removed |Added Status|NEW |ASSIGNED CC||sanjay.an...@gmail.com Assignee|nob...@fedoraproject.org|sanjay.an...@gmail.com Flags||fedora-review? --- Comment #1 from Ankur Sinha (FranciscoD) --- I'll review this one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798797] Review Request: ocaml-ppx-tools - Tools for authors of ppx rewriters
https://bugzilla.redhat.com/show_bug.cgi?id=1798797 Jerry James changed: What|Removed |Added Blocks||1798798 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1798798 [Bug 1798798] Review Request: ocaml-ppx-deriving - Type-driven code generation for OCaml -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798797] Review Request: ocaml-ppx-tools - Tools for authors of ppx rewriters
https://bugzilla.redhat.com/show_bug.cgi?id=1798797 Jerry James changed: What|Removed |Added CC||dan.cermak@cgc-instruments. ||com Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
