[Bug 1798798] Review Request: ocaml-ppx-deriving - Type-driven code generation for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1798798 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-03-27 08:01:39 --- Comment #15 from Fedora Update System --- FEDORA-2020-d1320503c7 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798798] Review Request: ocaml-ppx-deriving - Type-driven code generation for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1798798 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System --- ocaml-ppx-deriving-4.4.1-1.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-d1320503c7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798798] Review Request: ocaml-ppx-deriving - Type-driven code generation for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1798798 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #13 from Fedora Update System --- FEDORA-2020-d1320503c7 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-d1320503c7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798798] Review Request: ocaml-ppx-deriving - Type-driven code generation for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1798798 --- Comment #12 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-ppx-deriving -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798798] Review Request: ocaml-ppx-deriving - Type-driven code generation for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1798798 --- Comment #11 from Jerry James --- Thank you, Ankur! I appreciate the review. The Requires and Provides look fine to me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798798] Review Request: ocaml-ppx-deriving - Type-driven code generation for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1798798
Ankur Sinha (FranciscoD) changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #10 from Ankur Sinha (FranciscoD) ---
Looks good. XXX APPROVED XXX
Please do check the Requires and Provides once. They look OK, but I don't know
enough about the other OCaml packages to check them for correctness.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
^
Look OK, but please do take a look to confirm.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Ocaml:
[x]: This should never happen
^
I don't know what this is about, perhaps a fedora-review bug..
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
^
Look OK but please check once to confirm.
[!]: Package functions as described.
^
Not tested, leaving this up to you :)
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into bi
[Bug 1798798] Review Request: ocaml-ppx-deriving - Type-driven code generation for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1798798 --- Comment #9 from Ankur Sinha (FranciscoD) --- Yes, sorry, just running it through fedora-review now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798798] Review Request: ocaml-ppx-deriving - Type-driven code generation for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1798798 --- Comment #8 from Jerry James --- Ankur, are you available to continue this review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798798] Review Request: ocaml-ppx-deriving - Type-driven code generation for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1798798 --- Comment #7 from Jerry James --- The ocaml-ppxfind package has now been built for F32. Let me know if you want a buildroot override. Building for Rawhide has been okay for a week, so no problem there. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798798] Review Request: ocaml-ppx-deriving - Type-driven code generation for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1798798 --- Comment #6 from Jerry James --- A problem with the ocaml-ppxfind package that caused the test failures has been fixed in Rawhide. Due to beta freeze, it has not yet been fixed for F32, but will be. New URLs: Spec URL: https://jjames.fedorapeople.org/ocaml-ppx-deriving/ocaml-ppx-deriving.spec SRPM URL: https://jjames.fedorapeople.org/ocaml-ppx-deriving/ocaml-ppx-deriving-4.4.1-1.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798798] Review Request: ocaml-ppx-deriving - Type-driven code generation for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1798798 --- Comment #5 from Ankur Sinha (FranciscoD) --- No worries, please let me know when it's ready for another look :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798798] Review Request: ocaml-ppx-deriving - Type-driven code generation for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1798798 --- Comment #4 from Jerry James --- Yes, I see that, too. I swear that didn't happen when I built it to submit for review. :-) I don't know offhand what is going wrong, but I'll look into it. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798798] Review Request: ocaml-ppx-deriving - Type-driven code generation for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1798798 --- Comment #3 from Ankur Sinha (FranciscoD) --- Hi Jerry, Just managed to run it through FedoraReview now. The build seems to be failing in the check section. Could you please take a look? Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.ffMslv + umask 022 + cd /builddir/build/BUILD + cd ppx_deriving-4.4 + dune runtest File "src_test/deriving/test_ppx_deriving.ml", line 4, characters 25-35: 4 | let sort = List.sort [%derive.ord: int * int] in ^^ Error: Uninterpreted extension 'derive.ord'. File "src_test/create/test_deriving_create.ml", line 38, characters 24-32: 38 | assert_equal ~printer:M.show_a Error: Unbound value M.show_a File "test_deriving_eq.cppo.ml", line 24, characters 31-39: Error: Unbound value equal_a1 File "test_deriving_fold.cppo.ml", line 8, characters 41-51: Error: Unbound value fold_btree File "test_deriving_iter.cppo.ml", line 34, characters 2-12: Error: Unbound value iter_btree File "src_test/enum/test_deriving_enum.ml", line 7, characters 42-52: 7 | assert_equal ~printer:string_of_int 0 (va_to_enum Aa); ^^ Error: Unbound value va_to_enum File "src_test/make/test_deriving_make.ml", line 48, characters 24-32: 48 | assert_equal ~printer:M.show_a Error: Unbound value M.show_a File "test_deriving_map.cppo.ml", line 81, characters 15-24: Error: Unbound value map_btree File "test_deriving_ord.cppo.ml", line 22, characters 30-40: Error: Unbound value compare_a1 Hint: Did you mean compare? File "test_deriving_show.cppo.ml", line 23, characters 35-42: Error: Unbound value show_a1 RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.ffMslv (%check) Bad exit status from /var/tmp/rpm-tmp.ffMslv (%check) Child return code was: 1 EXCEPTION: [Error()] Traceback (most recent call last): File "/usr/lib/python3.7/site-packages/mockbuild/trace_decorator.py", line 93, in trace Cheers, -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798798] Review Request: ocaml-ppx-deriving - Type-driven code generation for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1798798 --- Comment #2 from Jerry James --- Thank you, Ankur! I had to make some changes due to a recent ocaml-ounit update, so I just pushed fixed spec and srpm files to the URLs above. Let me know if you need anything reviewed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798798] Review Request: ocaml-ppx-deriving - Type-driven code generation for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1798798 Ankur Sinha (FranciscoD) changed: What|Removed |Added Status|NEW |ASSIGNED CC||sanjay.an...@gmail.com Assignee|nob...@fedoraproject.org|sanjay.an...@gmail.com Flags||fedora-review? --- Comment #1 from Ankur Sinha (FranciscoD) --- I can review this one too since no one has taken it up yet. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798798] Review Request: ocaml-ppx-deriving - Type-driven code generation for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1798798 Bug 1798798 depends on bug 1798797, which changed state. Bug 1798797 Summary: Review Request: ocaml-ppx-tools - Tools for authors of ppx rewriters https://bugzilla.redhat.com/show_bug.cgi?id=1798797 What|Removed |Added Status|POST|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798798] Review Request: ocaml-ppx-deriving - Type-driven code generation for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1798798 Bug 1798798 depends on bug 1798796, which changed state. Bug 1798796 Summary: Review Request: ocaml-ppxfind - Tool to apply OCaml ppx rewriters to a file https://bugzilla.redhat.com/show_bug.cgi?id=1798796 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798798] Review Request: ocaml-ppx-deriving - Type-driven code generation for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1798798 Jerry James changed: What|Removed |Added Blocks||1801421 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1801421 [Bug 1801421] Review Request: ocaml-ppx-deriving-yojson - JSON codec generator for OCaml -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1798798] Review Request: ocaml-ppx-deriving - Type-driven code generation for OCaml
https://bugzilla.redhat.com/show_bug.cgi?id=1798798 Jerry James changed: What|Removed |Added CC||dan.cermak@cgc-instruments. ||com Depends On||1798796, 1798797 Doc Type|--- |If docs needed, set a value Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1798796 [Bug 1798796] Review Request: ocaml-ppxfind - Tool to apply OCaml ppx rewriters to a file https://bugzilla.redhat.com/show_bug.cgi?id=1798797 [Bug 1798797] Review Request: ocaml-ppx-tools - Tools for authors of ppx rewriters -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
