[Bug 1807979] Review Request: python-whois - Python package for retrieving WHOIS information
https://bugzilla.redhat.com/show_bug.cgi?id=1807979 --- Comment #14 from Fedora Update System --- FEDORA-2020-809c4ef393 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1807979] Review Request: python-whois - Python package for retrieving WHOIS information
https://bugzilla.redhat.com/show_bug.cgi?id=1807979 --- Comment #13 from Fedora Update System --- FEDORA-2020-809c4ef393 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-809c4ef393 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-809c4ef393 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1807979] Review Request: python-whois - Python package for retrieving WHOIS information
https://bugzilla.redhat.com/show_bug.cgi?id=1807979 --- Comment #12 from Fedora Update System --- python-whois-0.9.6-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1807979] Review Request: python-whois - Python package for retrieving WHOIS information
https://bugzilla.redhat.com/show_bug.cgi?id=1807979 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-03-12 21:56:40 --- Comment #11 from Fedora Update System --- python-whois-0.9.6-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1807979] Review Request: python-whois - Python package for retrieving WHOIS information
https://bugzilla.redhat.com/show_bug.cgi?id=1807979 --- Comment #10 from Fedora Update System --- python-whois-0.9.6-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-54b1fb50c1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1807979] Review Request: python-whois - Python package for retrieving WHOIS information
https://bugzilla.redhat.com/show_bug.cgi?id=1807979 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- python-whois-0.9.6-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-47f0552977 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1807979] Review Request: python-whois - Python package for retrieving WHOIS information
https://bugzilla.redhat.com/show_bug.cgi?id=1807979 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED --- Comment #7 from Fedora Update System --- FEDORA-2020-47f0552977 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-47f0552977 --- Comment #8 from Fedora Update System --- FEDORA-2020-54b1fb50c1 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2020-54b1fb50c1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1807979] Review Request: python-whois - Python package for retrieving WHOIS information
https://bugzilla.redhat.com/show_bug.cgi?id=1807979 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-whois -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1807979] Review Request: python-whois - Python package for retrieving WHOIS information
https://bugzilla.redhat.com/show_bug.cgi?id=1807979 Fabian Affolter changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Fabian Affolter --- The versioning is done inside the spec file, trackable by the changelog and is shown in the SRPM. I guess that's my point of view. Anyways, as the SRPM contains a spec file that matches the Guidelines, package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1807979] Review Request: python-whois - Python package for retrieving WHOIS information
https://bugzilla.redhat.com/show_bug.cgi?id=1807979 --- Comment #4 from Artur Iwicki --- I prefer to keep the spec files versioned during the review process so people can compare the changes if they need to. The number goes away when importing to dist-git. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1807979] Review Request: python-whois - Python package for retrieving WHOIS information
https://bugzilla.redhat.com/show_bug.cgi?id=1807979 --- Comment #3 from Fabian Affolter --- python-whois-0.9.6-1.spec should be python-whois.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1807979] Review Request: python-whois - Python package for retrieving WHOIS information
https://bugzilla.redhat.com/show_bug.cgi?id=1807979 --- Comment #2 from Artur Iwicki --- > According to the setup.py file is there a testsuite. Yes there is, but the test suite works by making WHOIS calls, which are going to fail in koji, since the builders run without outernet access. The rest of the issues pointed out in the comment have been fixed. spec: https://svgames.pl/fedora/python-whois-0.9.6-2.spec srpm: https://svgames.pl/fedora/python-whois-0.9.6-2.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=41973641 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1807979] Review Request: python-whois - Python package for retrieving WHOIS information
https://bugzilla.redhat.com/show_bug.cgi?id=1807979
Fabian Affolter changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||m...@fabian-affolter.ch
Assignee|nob...@fedoraproject.org|m...@fabian-affolter.ch
Doc Type|--- |If docs needed, set a value
Flags||fedora-review?
--- Comment #1 from Fabian Affolter ---
- %{?python_enable_dependency_generator} is enabled by default
- The "URL:" line contains a tailing whitespace
- README file is missing, not shipped in %doc
- According to the setup.py file is there a testsuite.
- "Summary: %{Summary}" should be "Summary: %{summary}"
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Spec file name must match the spec package %{name}, in the format
%{name}.spec.
Note: python-whois-0.9.6-1.spec should be python-whois.spec
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_spec_file_naming
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "do What The Fuck you want to Public
License (v2)". 9 files have unknown license. Detailed output of
licensecheck in /home/fab/Documents/repos/reviews/1807979-python-
whois-0.9.6-1/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Macros in Summary, %description expandable at SRPM build time.
Note: Macros in: python3-whois (summary)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
[Bug 1807979] Review Request: python-whois - Python package for retrieving WHOIS information
https://bugzilla.redhat.com/show_bug.cgi?id=1807979 Artur Iwicki changed: What|Removed |Added Blocks||1807981 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1807981 [Bug 1807981] Review Request: dnstwist - domain name permutation engine -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
