[Bug 1815091] Review Request: python-adb - A Python implementation of the Android ADB and Fastboot protocols
https://bugzilla.redhat.com/show_bug.cgi?id=1815091 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-07-09 01:04:56 --- Comment #10 from Fedora Update System --- FEDORA-2020-f9f2a1ed43 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815091] Review Request: python-adb - A Python implementation of the Android ADB and Fastboot protocols
https://bugzilla.redhat.com/show_bug.cgi?id=1815091 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- FEDORA-2020-f9f2a1ed43 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-f9f2a1ed43 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f9f2a1ed43 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815091] Review Request: python-adb - A Python implementation of the Android ADB and Fastboot protocols
https://bugzilla.redhat.com/show_bug.cgi?id=1815091 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #8 from Fedora Update System --- FEDORA-2020-f9f2a1ed43 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f9f2a1ed43 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815091] Review Request: python-adb - A Python implementation of the Android ADB and Fastboot protocols
https://bugzilla.redhat.com/show_bug.cgi?id=1815091 --- Comment #7 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-adb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815091] Review Request: python-adb - A Python implementation of the Android ADB and Fastboot protocols
https://bugzilla.redhat.com/show_bug.cgi?id=1815091 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #6 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815091] Review Request: python-adb - A Python implementation of the Android ADB and Fastboot protocols
https://bugzilla.redhat.com/show_bug.cgi?id=1815091 --- Comment #5 from Fabian Affolter --- (In reply to Robert-André Mauchin from comment #4) > Try backporting this patch maybe: > https://github.com/google/python-adb/commit/ > 4b555e64d1e49d91ed851c59bb11b734b302f71d.patch Thanks %changelog * Mon Jun 29 2020 Fabian Affolter - 1.3.0-3 - Add patch for py-cryptography Updates files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-adb.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-adb-1.3.0-3.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815091] Review Request: python-adb - A Python implementation of the Android ADB and Fastboot protocols
https://bugzilla.redhat.com/show_bug.cgi?id=1815091 --- Comment #4 from Robert-André Mauchin --- Try backporting this patch maybe: https://github.com/google/python-adb/commit/4b555e64d1e49d91ed851c59bb11b734b302f71d.patch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815091] Review Request: python-adb - A Python implementation of the Android ADB and Fastboot protocols
https://bugzilla.redhat.com/show_bug.cgi?id=1815091 --- Comment #3 from Robert-André Mauchin --- Ok maybe but current package is still not installable: DEBUG util.py:621: Error: DEBUG util.py:621: Problem: conflicting requests DEBUG util.py:621:- nothing provides (python3.8dist(m2crypto) >= 0.21.1 with python3.8dist(m2crypto) <= 0.26.4) needed by python3-adb-1.3.0-2.fc33.noarch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815091] Review Request: python-adb - A Python implementation of the Android ADB and Fastboot protocols
https://bugzilla.redhat.com/show_bug.cgi?id=1815091 --- Comment #2 from Fabian Affolter --- (In reply to Robert-André Mauchin from comment #1) > - Package is not installable: > > DEBUG util.py:621: Problem: conflicting requests > DEBUG util.py:621:- nothing provides (python3.8dist(m2crypto) >= 0.21.1 > with python3.8dist(m2crypto) <= 0.26.4) needed by > python3-adb-1.3.0-1.fc33.noarch > DEBUG util.py:623: (try to add '--skip-broken' to skip uninstallable > packages or '--nobest' to use not only best candidate packages) Upstream is moving to pycryptodome(x). %changelog * Sun Apr 05 2020 Fabian Affolter - 1.3.0-2 - Fix requirements (rhbz#1815091) Updates files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-adb.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-adb-1.3.0-2.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1815091] Review Request: python-adb - A Python implementation of the Android ADB and Fastboot protocols
https://bugzilla.redhat.com/show_bug.cgi?id=1815091
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
Doc Type|--- |If docs needed, set a value
--- Comment #1 from Robert-André Mauchin ---
- Package is not installable:
DEBUG util.py:621: Problem: conflicting requests
DEBUG util.py:621:- nothing provides (python3.8dist(m2crypto) >= 0.21.1
with python3.8dist(m2crypto) <= 0.26.4) needed by
python3-adb-1.3.0-1.fc33.noarch
DEBUG util.py:623: (try to add '--skip-broken' to skip uninstallable packages
or '--nobest' to use not only best candidate packages)
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Apache License 2.0". 9 files have
unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/python-adb/review-python-
adb/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from up
