[Bug 1816295] Review Request: python-mysqlclient - MySQL/mariaDB database connector for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1816295 --- Comment #14 from Fedora Update System --- FEDORA-EPEL-2020-6984cdde39 has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816295] Review Request: python-mysqlclient - MySQL/mariaDB database connector for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1816295 --- Comment #13 from Fedora Update System --- FEDORA-2020-f8ae67d409 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816295] Review Request: python-mysqlclient - MySQL/mariaDB database connector for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1816295 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-07-01 01:35:18 --- Comment #12 from Fedora Update System --- FEDORA-2020-077ea0d190 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816295] Review Request: python-mysqlclient - MySQL/mariaDB database connector for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1816295 --- Comment #11 from Fedora Update System --- FEDORA-2020-077ea0d190 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-077ea0d190 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-077ea0d190 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816295] Review Request: python-mysqlclient - MySQL/mariaDB database connector for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1816295 --- Comment #10 from Fedora Update System --- FEDORA-EPEL-2020-6984cdde39 has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-6984cdde39 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816295] Review Request: python-mysqlclient - MySQL/mariaDB database connector for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1816295 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- FEDORA-2020-f8ae67d409 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-f8ae67d409 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f8ae67d409 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816295] Review Request: python-mysqlclient - MySQL/mariaDB database connector for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1816295 --- Comment #8 from Fedora Update System --- FEDORA-EPEL-2020-6984cdde39 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-6984cdde39 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816295] Review Request: python-mysqlclient - MySQL/mariaDB database connector for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1816295 --- Comment #7 from Fedora Update System --- FEDORA-2020-f8ae67d409 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f8ae67d409 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816295] Review Request: python-mysqlclient - MySQL/mariaDB database connector for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1816295 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #6 from Fedora Update System --- FEDORA-2020-077ea0d190 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-077ea0d190 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816295] Review Request: python-mysqlclient - MySQL/mariaDB database connector for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1816295 --- Comment #5 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-mysqlclient -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816295] Review Request: python-mysqlclient - MySQL/mariaDB database connector for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1816295 --- Comment #4 from Fabian Affolter --- Thanks for reviewing this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816295] Review Request: python-mysqlclient - MySQL/mariaDB database connector for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1816295 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #3 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816295] Review Request: python-mysqlclient - MySQL/mariaDB database connector for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1816295 --- Comment #2 from Fabian Affolter --- (In reply to Robert-André Mauchin from comment #1) > - License is GPLv2 not MIT: Fixed > - Add BR gcc Added > - Tests are not properly run: > > + /usr/bin/python3 setup.py test > running test > running egg_info > WARNING: Testing via this command is deprecated and will be removed in a > future version. Users looking for a generic test entry point independent of > test runner are encouraged to use tox. > writing mysqlclient.egg-info/PKG-INFO > writing dependency_links to mysqlclient.egg-info/dependency_links.txt > writing top-level names to mysqlclient.egg-info/top_level.txt > reading manifest file 'mysqlclient.egg-info/SOURCES.txt' > reading manifest template 'MANIFEST.in' > writing manifest file 'mysqlclient.egg-info/SOURCES.txt' > running build_ext > copying > build/lib.linux-x86_64-3.8/MySQLdb/_mysql.cpython-38-x86_64-linux-gnu.so -> > MySQLdb > -- > Ran 0 tests in 0.000s > > They seem to be run using Pytest, but they need a mysql server I think. Yes, they need a DB instance. Add but not enabled by default. %changelog * Mon May 18 2020 Fabian Affolter - 1.4.6-2 - Add tests and missing BR - Fix license (rhbz#1816295) Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-mysqlclient.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-mysqlclient-1.4.6-2.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816295] Review Request: python-mysqlclient - MySQL/mariaDB database connector for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1816295 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com Doc Type|--- |If docs needed, set a value --- Comment #1 from Robert-André Mauchin --- - License is GPLv2 not MIT: https://github.com/PyMySQL/mysqlclient-python/blob/master/LICENSE - Add BR gcc - Tests are not properly run: + /usr/bin/python3 setup.py test running test running egg_info WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox. writing mysqlclient.egg-info/PKG-INFO writing dependency_links to mysqlclient.egg-info/dependency_links.txt writing top-level names to mysqlclient.egg-info/top_level.txt reading manifest file 'mysqlclient.egg-info/SOURCES.txt' reading manifest template 'MANIFEST.in' writing manifest file 'mysqlclient.egg-info/SOURCES.txt' running build_ext copying build/lib.linux-x86_64-3.8/MySQLdb/_mysql.cpython-38-x86_64-linux-gnu.so -> MySQLdb -- Ran 0 tests in 0.000s They seem to be run using Pytest, but they need a mysql server I think. Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License", "GPL (v2 or later)". 46 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/python-mysqlclient/review- python-mysqlclient/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/python3.8/site- packages/MySQLdb(python3-mysql), /usr/lib64/python3.8/site- packages/MySQLdb/__pycache__(python3-mysql), /usr/lib64/python3.8/site-packages/MySQLdb/constants(python3-mysql), /usr/lib64/python3.8/site- packages/MySQLdb/constants/__pycache__(python3-mysql), /usr/lib64/python3.8/site-packages/mysqlclient-1.4.6-py3.8.egg- info(python3-mysql) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directo
[Bug 1816295] Review Request: python-mysqlclient - MySQL/mariaDB database connector for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1816295 Fabian Affolter changed: What|Removed |Added Blocks||1816367 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1816367 [Bug 1816367] Review Request: patator - A multi-purpose brute-forcer -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
