[Bug 1816733] Review Request: rust-libslirp - High-level bindings & helper process for libslirp
https://bugzilla.redhat.com/show_bug.cgi?id=1816733 Igor Raits changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Flags|needinfo?(igor.raits@gmail. | |com)| Last Closed||2020-05-12 05:04:52 --- Comment #8 from Igor Raits --- We've discussed that over IRC and it is already in bodhi for F32. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816733] Review Request: rust-libslirp - High-level bindings & helper process for libslirp
https://bugzilla.redhat.com/show_bug.cgi?id=1816733 Marc-Andre Lureau changed: What|Removed |Added Flags||needinfo?(i.gnatenko.brain@ ||gmail.com) --- Comment #7 from Marc-Andre Lureau --- I managed to get it to build in rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1504659 What's the process now to get it in f32? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816733] Review Request: rust-libslirp - High-level bindings & helper process for libslirp
https://bugzilla.redhat.com/show_bug.cgi?id=1816733 --- Comment #6 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-libslirp -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816733] Review Request: rust-libslirp - High-level bindings & helper process for libslirp
https://bugzilla.redhat.com/show_bug.cgi?id=1816733 Igor Gnatenko changed: What|Removed |Added Status|ASSIGNED|POST Flags|needinfo?(i.gnatenko.brain@ |fedora-review+ |gmail.com) | --- Comment #5 from Igor Gnatenko --- Sorry, I was quite busy lately. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816733] Review Request: rust-libslirp - High-level bindings & helper process for libslirp
https://bugzilla.redhat.com/show_bug.cgi?id=1816733 --- Comment #4 from Marc-Andre Lureau --- ping Igor? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816733] Review Request: rust-libslirp - High-level bindings & helper process for libslirp
https://bugzilla.redhat.com/show_bug.cgi?id=1816733 Marc-Andre Lureau changed: What|Removed |Added Flags||needinfo?(i.gnatenko.brain@ ||gmail.com) --- Comment #3 from Marc-Andre Lureau --- Unfortunately, I can't run the make test on koji: https://kojipkgs.fedoraproject.org//work/tasks/6009/42946009/build.log Perhaps I should open a bug for koji to allow unshare.. (fwiw, it works in gitlab CI: https://gitlab.freedesktop.org/slirp/libslirp-rs/-/jobs/2040152) With this result, Igor, is the current version ok? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816733] Review Request: rust-libslirp - High-level bindings & helper process for libslirp
https://bugzilla.redhat.com/show_bug.cgi?id=1816733 --- Comment #2 from Marc-Andre Lureau --- (In reply to Igor Gnatenko from comment #1) > Can you put a comment why you disable tests? Also, any reason why you use > --all-features? The rust tests require etherparse, but they are very incomplete. I am considering removing them. I added python/scapy tests, however, they have a number of dependencies (python, scapy, dbus..): https://gitlab.freedesktop.org/slirp/libslirp-rs/-/blob/master/Makefile. I can try to make that work on Fedora/koji, if it's necesary. I use --all-features, as otherwise the libslirp-helper binary is not built. thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1816733] Review Request: rust-libslirp - High-level bindings & helper process for libslirp
https://bugzilla.redhat.com/show_bug.cgi?id=1816733 Igor Gnatenko changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|i.gnatenko.br...@gmail.com --- Comment #1 from Igor Gnatenko --- Can you put a comment why you disable tests? Also, any reason why you use --all-features? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
