[Bug 1821459] Review Request: golang-github-aryann-difflib - Library for diffing two sequences of text

2021-07-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1821459

Mattia Verga  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2021-07-31 09:53:41



--- Comment #4 from Mattia Verga  ---
Package is available in repos


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure


[Bug 1821459] Review Request: golang-github-aryann-difflib - Library for diffing two sequences of text

2020-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1821459



--- Comment #3 from Fabian Affolter  ---
Thanks for your feedback.

(In reply to Hirotaka Wakabayashi from comment #1)
> * If difflib_server need to start at boot this package must have
>   a systemd unit file. Please see:
>  
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Systemd/
> #_unit_files

IMHO, difflib_server looks more like a CLI tool despite the name . The tool
starts a webserver that shows the diff but there is no hot-reload functionality
which would make it a "real" service.

> * A man page for difflib_server is recommended. Please see:
>   https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages

Is now on my todo list.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1821459] Review Request: golang-github-aryann-difflib - Library for diffing two sequences of text

2020-06-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1821459



--- Comment #2 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-aryann-difflib


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1821459] Review Request: golang-github-aryann-difflib - Library for diffing two sequences of text

2020-06-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1821459

Hirotaka Wakabayashi  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Hirotaka Wakabayashi  ---
Hello Fabian,

Package approved. Please check the following notes before import.

* If difflib_server need to start at boot this package must have
  a systemd unit file. Please see:
 
https://docs.fedoraproject.org/en-US/packaging-guidelines/Systemd/#_unit_files
* A man page for difflib_server is recommended. Please see:
  https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages

Best,
Hirotaka Wakabayashi

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: There is no build directory. Running licensecheck on vanilla
 upstream sources. Licenses found: "Unknown or generated". 1 files have
 unknown license. Detailed output of licensecheck in
 /home/vagrant/FedoraReview/1821459-golang-github-aryann-
 difflib/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/gocode/src/github.com(compat-golang-github-commonmark-puny-
 devel, golang-github-gobwas-glob-devel, golang-github-googleapis-gax-
 devel, golang-github-coreos-iptables-devel, golang-github-jeffail-
 gabs-devel, golang-github-goftp-server-devel, golang-github-
 ianlancetaylor-cgosymbolizer-devel, golang-github-davecgh-spew-devel,
 compat-golang-github-redis-devel, compat-golang-github-xorm-builder-
 devel, golang-github-xorm-devel, golang-github-flynn-json5-devel,
 golang-github-transip-gotransip-devel, golang-github-cbroglie-
 mapstructure-devel, golang-github-vmware-photon-controller-sdk-devel,
 golang-github-cyphar-filepath-securejoin-devel, golang-github-
 hashicorp-hil-devel, golang-github-nkovacs-streamquote-devel, golang-
 github-opentracing-devel, golang-github-tcnksm-input-devel, golang-
 github-tg-gosortmap-devel, golang-github-chi-devel, golang-github-
 antihax-optional-devel, golang-github-onsi-gomega-devel, golang-
 github-sqshq-sampler-devel, golang-github-martini-contrib-render-
 devel, golang-github-nicksnyder-i18n-devel, golang-github-jzelinskie-
 whirlpool-devel, golang-github-lucas-clemente-quic-certificates-devel,
 golang-github-sendgrid-devel, golang-github-niklasfasching-org-devel,
 golang-github-azure-service-bus-devel, golang-github-benlaurie-
 objecthash-devel, golang-github-gofrs-uuid-devel, golang-github-
 howeyc-gopass-devel, golang-github-jaguilar-vt100-devel, golang-
 github-otiai10-copy-devel, golang-github-asaskevich-govalidator-devel,
 golang-github-hashicorp-lru-devel, golang-github-golangplus-bytes-
 devel, golang-github-apache-arrow-devel, golang-github-mschoch-smat-
 devel, golang-github-mitchellh-mapstructure-devel, golang-github-
 thorduri-libusb-devel, golang-github-glacjay-goini-devel, golang-
 github-data-dog-godog-devel, golang-github-circonus-labs-
 circonusllhist-devel, golang-github-influxdata-line-protocol-devel,
 golang-github-sabhiram-gitignore-devel, golang-github-sony-gobreaker-
 devel, golang-github-thinkerou-favicon-devel, golang-github-
 tv42-httpunix-devel, golang-github-google-cmp-devel, golang-github-
 zmap-zcrypto-devel, golang-github-daviddengcn-algs-devel, golang-
 github-jacobsa-ogletest-devel, golang-github-acme-lego-devel, golang-
 github-logr-devel, golang-github-andy-kimball-arenaskl-devel, golang-
 github-haproxytech-config-parser-devel, golang-github-tarm-serial-
 devel, golang-github-soheilhy-cmux-devel, golang-github-calmh-xdr-
 devel, golang-github-tidwall-pretty-devel, golang-github-bruth-assert-
 devel, golang-github-jessevdk-flags-devel, golang-github-influxdata-
 influxdb1-client-devel, golang-github-fluent-logger-devel, golang-
 github-lunixbochs-vtclean-devel, golang-github-mattn-ieproxy-devel,
 golang-github-pelletier-toml-devel, golang-github-yunify-qingstor-sdk-
 devel, golang-github-google-subcommands-devel, golang-github-
 prometheus-common-devel, golang-github-cespare-xxhash-devel, golang-
 github-azure-ansiterm-devel, golang-github-abbot-http-auth-devel,
 golang-github-cockroachdb-ttycolor-devel, golang-github-facebookgo-
 atomicfile-devel, golang-github-10gen-esc

[Bug 1821459] Review Request: golang-github-aryann-difflib - Library for diffing two sequences of text

2020-06-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1821459

Hirotaka Wakabayashi  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||hiw...@yahoo.com
   Assignee|nob...@fedoraproject.org|hiw...@yahoo.com
   Doc Type|--- |If docs needed, set a value
  Flags||fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1821459] Review Request: golang-github-aryann-difflib - Library for diffing two sequences of text

2020-04-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1821459

Fabian Affolter  changed:

   What|Removed |Added

 Blocks||1804085





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1804085
[Bug 1804085] golang-github-kit-0.10.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1821459] Review Request: golang-github-aryann-difflib - Library for diffing two sequences of text

2020-04-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1821459

Fabian Affolter  changed:

   What|Removed |Added

 Blocks||1821691





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1821691
[Bug 1821691] Review Request: golang-github-kit - Library for microservices
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org