[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 --- Comment #35 from Fedora Update System --- FEDORA-EPEL-2020-6e4abc955e has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 --- Comment #34 from Fedora Update System --- FEDORA-EPEL-2020-6e4abc955e has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-6e4abc955e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 --- Comment #33 from Fedora Update System --- FEDORA-EPEL-2020-def71cae41 has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-def71cae41 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2020-07-03 01:18:55 --- Comment #32 from Fedora Update System --- FEDORA-2020-63ec62898d has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #31 from Fedora Update System --- FEDORA-EPEL-2020-9ee16640e9 has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-9ee16640e9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED --- Comment #30 from Fedora Update System --- FEDORA-EPEL-2020-9ee16640e9 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-9ee16640e9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 Gwyn Ciesla changed: What|Removed |Added Flags|needinfo?(gwync@protonmail. | |com)| --- Comment #29 from Gwyn Ciesla --- Yes. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 Itamar Reis Peixoto changed: What|Removed |Added Status|ON_QA |NEW CC||ita...@ispbrasil.com.br Flags||needinfo?(gwync@protonmail. ||com) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #28 from Fedora Update System --- FEDORA-2020-63ec62898d has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-63ec62898d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-63ec62898d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 --- Comment #27 from Ron Olson --- Gwyn, will you also add this to the EPEL 8 repo for CentOS/RHEL users? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED --- Comment #26 from Fedora Update System --- FEDORA-2020-63ec62898d has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-63ec62898d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 --- Comment #25 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gnucobol -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 --- Comment #24 from Gwyn Ciesla --- Thank you! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #23 from Robert-André Mauchin --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 --- Comment #22 from Gwyn Ciesla --- Thank you! Addressed all issues but -devel package for previously stated reasons. SRPM: https://fedorapeople.org/~limb/review/gnucobol/gnucobol-3.1-3.fc32.src.rpm SPEC: https://fedorapeople.org/~limb/review/gnucobol/gnucobol.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 Robert-André Mauchin changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review? --- Comment #21 from Robert-André Mauchin --- - Add an explicit BR for gcc - [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools AutoTools: Obsoleted m4s found -- AC_PROG_LIBTOOL found in: gnucobol-3.1-dev/configure.ac:378 Patch this with LT_INIT instead and suggest patch upstream.kk Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Header files in -devel subpackage, if present. Note: gnucobol : /usr/include/libcob.h gnucobol : /usr/include/libcob/cobgetopt.h gnucobol : /usr/include/libcob/common.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU Lesser General Public License", "FSF All Permissive License", "GPL (v3 or later)", "GNU General Public License GNU Lesser General Public License", "GNU Lesser General Public License (v3 or later)", "FSF Unlimited License (with Retention)", "Expat License", "GPL (v7)", "GNU Free Documentation License (v1.3 or later)", "*No copyright* GPL (v3 or later)", "GNU Lesser General Public License (v2.1 or later)", "FSF Unlimited License (with Retention) GNU General Public License GNU Lesser General Public License", "FSF Unlimited License (with Retention) GNU General Public License (v2)". 124 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/gnucobol/review-gnucobol/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 92160 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file,
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 --- Comment #20 from Gwyn Ciesla --- I've removed the ldconfig requires in my local spec. A devel package doesn't make sense in this instance, as this is a compiler. The main package would need to require the -devel package to function, and the -devel package wouldn't be relevant without the main package. I'm not using the make install macro currently because of a build issue that I'm troubleshooting with upstream, hence the tarball. It's currently a SVN snapshot but will revert to a traditional Source0 URL once resolved and released. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #19 from Robert-André Mauchin ---
- Not needed
Requires(post): /sbin/ldconfig
Requires(postun): /sbin/ldconfig
- You need a libcob-devel subpackage to contains include and unversioned .so
file. This subpackage must depend on the libcob subpackage.
%package -n libcob-devel
Summary:GnuCOBOL development library
Requires: libcob%{?_isa} = %{version}-%{release}
%description -n libcob-devel
%{summary}.
Development libraries for GnuCOBOL
[…]
%files -n libcob-devel
%{_libdir}/libcob.so
%{_includedir}/*
- make install DESTDIR=%{buildroot} → %make_install
- You should use a URL for Source0 or explain how you generated the archive.
For example there is
https://ci.appveyor.com/api/projects/GitMensch/gnucobol-3-x/artifacts/gnucobol-3.1-dev.tar.gz?job=Image:%20Ubuntu1804
for the latest dev. See
https://sourceforge.net/projects/open-cobol/files/gnucobol/nightly_snapshots/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 --- Comment #18 from Gwyn Ciesla --- SRPM: https://fedorapeople.org/~limb/review/gnucobol/gnucobol-3.1-2.fc32.src.rpm SPEC: https://fedorapeople.org/~limb/review/gnucobol/gnucobol.spec Updated. The requires and lack of devel package are because this is a compiler, and those pieces are always needed. The nightly release is because 3.1 isn't out yet, and contains build fixes needed that are missing in 3.0. cob-config is a shell script. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419
--- Comment #17 from dan.cer...@cgc-instruments.com ---
A few additional notes:
- Requires(post): /sbin/install-info is not required, the same is the case for
Requires(post/postun): /sbin/ldconfig.
- %setup -q -> %autosetup
- make %{?_smp_mflags} -> %make_build
- make install DESTDIR=$RPM_BUILD_ROOT -> %make_install
- $RPM_BUILD_ROOT -> %{buildroot}
- $RPM_OPT_FLAGS -> %optflags or %build_cflags
- there are headers and a shared library in the main package, these usually
belong into -devel subpackages
- libcob.so is included in the libcob subpackage via a wildcard, this is
strongly discouraged as that hides the SONAME
- You appear to be packaging the nightly release, why? Since there is no stable
URL to that, this makes reproducability complicated.
- The Requires: glibc-devel and gmp-devel should not be required, rpm finds out
by itself that libcob requires libc, libgmp and libm
- Your package does not own %{_libdir}/%{name}, but creates it.
- cob-config is a static executable, which is afaik not permitted in Fedora
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 --- Comment #16 from Rubén Lledó --- (In reply to Gwyn Ciesla from comment #15) > This isn't part of the current distributions, but I'll keep an eye on it. Thanks! ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 --- Comment #15 from Gwyn Ciesla --- This isn't part of the current distributions, but I'll keep an eye on it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 --- Comment #14 from Rubén Lledó --- Hello. It would be nice to have GnuCOBOL esqlOC packaged, as well. https://sourceforge.net/p/open-cobol/contrib/HEAD/tree/trunk/esql/ Regards. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 --- Comment #13 from Gwyn Ciesla --- SRPM: https://fedorapeople.org/~limb/review/gnucobol/gnucobol-3.1-1.fc32.src.rpm SPEC: https://fedorapeople.org/~limb/review/gnucobol/gnucobol.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 --- Comment #12 from Gwyn Ciesla --- Updated. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 dan.cer...@cgc-instruments.com changed: What|Removed |Added CC||dan.cermak@cgc-instruments. ||com --- Comment #11 from dan.cer...@cgc-instruments.com --- Calling ldconfig and install-info in %post and %postun is no longer required, both is handled by rpm file triggers in Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 --- Comment #10 from Gwyn Ciesla --- Thank you! I'll integrate these. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419
Toshio Ernie Kuratomi changed:
What|Removed |Added
CC||a.bad...@gmail.com
--- Comment #9 from Toshio Ernie Kuratomi ---
I've been outside of Fedora for quite a while so I might not know what I'm
doing here but I think these would be good changes:
--- gnucobol.spec.vanilla 2020-04-16 23:44:30.448960249 -0700
+++ gnucobol.spec 2020-04-16 23:45:48.743879632 -0700
@@ -2,7 +2,7 @@
Name: gnucobol
Version:3.0
-Release:0.rc1%{?dist}.1
+Release:0.1.rc1%{?dist}
Summary:COBOL compiler
License:GPLv2+ and LGPLv2+
@@ -63,6 +63,7 @@
%files -f %{name}.lang
%license COPYING
+%license COPYING.DOC
%doc AUTHORS ChangeLog
%doc NEWS README THANKS
%{_bindir}/cobc
@@ -77,15 +78,16 @@
%files -n libcob
+%license COPYING.LESSER
%{_libdir}/libcob.so.*
%{_libdir}/gnucobol/CBL_OC_DUMP.so
%post
-/sbin/install-info %{_infodir}/open-cobol.info %{_infodir}/dir 2>/dev/null ||
:
+/sbin/install-info %{_infodir}/gnucobol.info %{_infodir}/dir 2>/dev/null || :
%postun
if [ $1 = 0 ]; then
- /sbin/install-info --delete %{_infodir}/open-cobol.info %{_infodir}/dir
2>/dev/null || :
+ /sbin/install-info --delete %{_infodir}/gnucobol.info %{_infodir}/dir
2>/dev/null || :
fi
%post -n libcob -p /sbin/ldconfig
* Changing Release will let you keep the initial .0 to designate the
pre-release and increment the second number no matter how upstream's version or
the disttag changes. ie: 0.1.rc1.fc31 0.2.r2.fc31 0.3.r2.fc32
* The %license additions just add the other license files that upstream seems
to have added for completeness (with different licenses for different parts of
the code)
* The install-info changes are because the info filenames have changed.
Thanks for packaging this :-)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 --- Comment #8 from Gwyn Ciesla --- Toshio beat me to it. :) https://sourceforge.net/p/open-cobol/patches/49/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 --- Comment #7 from Gwyn Ciesla --- And I'll contact upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 --- Comment #6 from Gwyn Ciesla --- I've applied the patch from the prior review to fix this issue. SRPM: https://fedorapeople.org/~limb/review/gnucobol/gnucobol-3.0-0.rc1.1.fc31.src.rpm SPEC: https://fedorapeople.org/~limb/review/gnucobol/gnucobol.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 --- Comment #5 from Artur Iwicki --- I know, I remember that from Anton's review request. But I think if anything, that's a reason to try and patch the configure script, rather than not use the optflags. Which reminds me, it might be a good idea to contact upstream and let them know that their "remove unwanted CFLAGS code" is broken. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 --- Comment #4 from Gwyn Ciesla --- I'll fix the release and group. Regarding flags, if we build with optflags, the -strong flag breaks the build. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419
Artur Iwicki changed:
What|Removed |Added
CC||fed...@svgames.pl
--- Comment #3 from Artur Iwicki ---
>Release:0.rc1%{?dist}
Shouldn't this be something like 0.1.rc1 or 0.rc1.1? It must start with a 0.
since this is a pre-release, but you'll still want a number you can increment
if you change something in the spec while staying at 3.0.0-rc1.
>Group: Development/Languages
>Group: Development/Libraries
Not used in Fedora.
>%build
>#export CFLAGS="$RPM_OPT_FLAGS -fPIC -O"
>export CPPFLAGS="$CFLAGS"
Setting the CFLAGS is commented-out. CPPFLAGS is thus set to an empty var. The
build ends up not using Fedora's %{optflags}.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 Gwyn Ciesla changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 from Gwyn Ciesla --- %configure unusable, -devel not needed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1823419] Review Request: gnucobol - COBOL compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1823419 Gwyn Ciesla changed: What|Removed |Added CC||tachokni...@gmail.com --- Comment #2 from Gwyn Ciesla --- *** Bug 1823134 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
