[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #36 from Simone Caronni --- I've tested with a few wallets and everything is fine, no conversion needed. Spec URL: https://slaanesh.fedorapeople.org/bitcoin.spec SRPM URL:

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-07-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #35 from Simone Caronni --- Spec URL: https://slaanesh.fedorapeople.org/bitcoin.spec SRPM URL: https://slaanesh.fedorapeople.org/bitcoin-0.20.0-6.fc32.src.rpm * Tue Jul 21 2020 Simone Caronni - 0.20.0-6 - Update systemd unit. -

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-07-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #34 from Simone Caronni --- I'll be away from the 25th of July for holidays until the 17th of August. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-07-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #33 from Simone Caronni --- (In reply to Björn Persson from comment #32) > Thank you for adding the signature verification, but you're still using HTTP > instead of HTTPS in URL and Source20 for no reason I can see. Just forgot

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-07-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #32 from Björn Persson --- Thank you for adding the signature verification, but you're still using HTTP instead of HTTPS in URL and Source20 for no reason I can see. -- You are receiving this mail because: You are on the CC

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-07-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #31 from Simone Caronni --- Spec URL: https://slaanesh.fedorapeople.org/bitcoin.spec SRPM URL: https://slaanesh.fedorapeople.org/bitcoin-0.20.0-4.fc32.src.rpm * Sun Jul 19 2020 Simone Caronni - 0.20.0-4 - Fix tests on

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-07-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #30 from Simone Caronni --- Thanks, I've added signature verification which is a bit from all comments above. The packaging guidelines are pretty clear about signatures, so: - Key is downloaded from the keyserver (as also

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-07-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #29 from Oleg Girko --- (In reply to Björn Persson from comment #28) > (In reply to Oleg Girko from comment #27) > > I think, the main PGP public key's checksum should be embedded into spec > > file and checked against to make

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-07-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #28 from Björn Persson --- (In reply to Oleg Girko from comment #27) > What about those who want to re-build the package from the spec file I would recommend rebuilding from the source RPM package. Rebuilding from only a spec

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-07-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #27 from Oleg Girko --- (In reply to Björn Persson from comment #26) > (In reply to marco from comment #25) > > Source12 simply downloads the key from > > https://bitcoin.org/laanwj-releases.asc without checking the hash or > >

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-07-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #26 from Björn Persson --- (In reply to marco from comment #25) > Source12 simply downloads the key from > https://bitcoin.org/laanwj-releases.asc without checking the hash or > fingerprint, so there is no way to detect changes.

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-07-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #25 from marco --- > packagers must be very careful when a release-signing key changes Source12 simply downloads the key from https://bitcoin.org/laanwj-releases.asc without checking the hash or fingerprint, so there is no way to

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-07-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #24 from Björn Persson --- (In reply to marco from comment #23) > If you fetch the key from the same website the binaries are taken from, > there is no security. Anyone replacing the binaries can trivially replace > the key. That

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-07-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #23 from marco --- If you fetch the key from the same website the binaries are taken from, there is no security. Anyone replacing the binaries can trivially replace the key. Also, bitcoincore.org is the official download site

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-07-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 Björn Persson changed: What|Removed |Added CC||bj...@xn--rombobjrn-67a.se ---

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #21 from Daniel Walsh --- Don't think you have to build multiple different SELinux policies, one should work on all variants. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #20 from Simone Caronni --- (In reply to marco from comment #17) > * In the spec file, what exactly is `Source4` used for? Contains some things related to packaging (icon, desktop menu, etc.). I might remove it entirely at some

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #19 from Simone Caronni --- (In reply to Eugene A. Pivnev from comment #16) > (In reply to Simone Caronni from comment #10) > > (In reply to Robert-André Mauchin from comment #7) > > > Also create a logrotate file for the log: > >

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-06-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #18 from Eugene A. Pivnev --- (In reply to marco from comment #17) > * Why is the Bitcoin Core package called `bitcoin` and not `bitcoin-core` > like in other package managers. E.g. https://snapcraft.io/bitcoin-core or >

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-06-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #17 from marco --- Some questions. * In the spec file, what exactly is `Source4` used for? * Why is the Bitcoin Core package called `bitcoin` and not `bitcoin-core` like in other package managers. E.g.

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-06-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #16 from Eugene A. Pivnev --- (In reply to Simone Caronni from comment #10) > (In reply to Robert-André Mauchin from comment #7) > > Also create a logrotate file for the log: > >

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-06-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #15 from Simone Caronni --- (In reply to Vit Mojzis from comment #14) > The Independent policy guide > (https://fedoraproject.org/wiki/SELinux/IndependentPolicy) should cover all > you need in terms of packaging the policy. > As

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-06-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 Vit Mojzis changed: What|Removed |Added CC||vmoj...@redhat.com --- Comment #14

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-06-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #13 from Simone Caronni --- (In reply to Robert-André Mauchin from comment #12) > - Could you follow the rules specified at > https://fedoraproject.org/wiki/SELinux/IndependentPolicy and use the > %pre/%post macros documented

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-06-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #12 from Robert-André Mauchin --- - Could you follow the rules specified at https://fedoraproject.org/wiki/SELinux/IndependentPolicy and use the %pre/%post macros documented there? - See the post by DWalsh on the -devel ML:

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-06-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #11 from Simone Caronni --- In the meanwhile, before changing anything for the logging: Spec URL: https://slaanesh.fedorapeople.org/bitcoin.spec SRPM URL: https://slaanesh.fedorapeople.org/bitcoin-0.20.0-2.fc32.src.rpm * Tue Jun

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-06-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #10 from Simone Caronni --- (In reply to Robert-André Mauchin from comment #7) > Also create a logrotate file for the log: > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_logrotate_config_file A couple of notes

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-06-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #9 from Simone Caronni --- (In reply to Robert-André Mauchin from comment #6) > Source0: > http://github.com/%{name}/%{name}/archive/v%{version}/%{name}-%{version}.tar. > gz Updated. > - Why does the core subpackage

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-06-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #8 from Simone Caronni --- Thanks for the feedback, updating the package now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-06-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #7 from Robert-André Mauchin --- Also create a logrotate file for the log: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_logrotate_config_file -- You are receiving this mail because: You are on the CC list for the

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-06-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 Robert-André Mauchin changed: What|Removed |Added CC||zebo...@gmail.com --- Comment

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-06-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 Eugene A. Pivnev changed: What|Removed |Added CC||ti.eug...@gmail.com --- Comment

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-05-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #4 from Simone Caronni --- Thanks I will look at it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-05-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 --- Comment #3 from Oleg Girko --- I was packaging a Dash client for Fedora for quite some time. Dash was originally a fork of Bitcoin, and now it still synchronises its codebase with newer versions of Bitcoin. Hence, Dash is not different

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-05-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 Simone Caronni changed: What|Removed |Added Doc Type|--- |If docs needed, set a value ---

[Bug 1834731] Review Request: bitcoin - Peer to Peer Cryptographic Currency

2020-05-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1834731 Simone Caronni changed: What|Removed |Added CC||j.orti.alca...@gmail.com ---