[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865 ycollet changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG Last Closed|2020-11-24 19:18:32 |2020-12-12 21:32:19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865 ycollet changed: What|Removed |Added Status|CLOSED |NEW Resolution|NOTABUG |--- Keywords||Reopened -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865 ycollet changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NOTABUG Last Closed||2020-11-24 19:18:32 --- Comment #25 from ycollet --- Package review opened more than 5 months ago. Nobody seems to be interested ... So, I close the package review. Somebody else will had back this if somebody at fedora is interested. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865 Petr Pisar changed: What|Removed |Added CC||ppi...@redhat.com Assignee|nob...@fedoraproject.org|vasc...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865 --- Comment #24 from Vasiliy Glazov --- Yes, inform me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865 --- Comment #23 from ycollet --- OK. I will certainly try to do a mix: submitting some new spec files and try to do some review. When I do a review, I add you to the review ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865 --- Comment #22 from Vasiliy Glazov --- Because your spec was not good at start I need to make sure you understand most significant rules of Fedora packaging guidellines. https://docs.fedoraproject.org/en-US/packaging-guidelines/ First variant - you can make few reviews for other packages in bugzilla. Second variant - as I understand you want to add more packages from your copr. So you can make 2-4 new review requests for it with good specs at start (not ideally, I anderstand that you beginner, but without big mistakes). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865 --- Comment #21 from ycollet --- I finished reading the wiki page related to sponsoring. What can I do so as you sponsor me ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865 --- Comment #20 from Vasiliy Glazov --- I can be a sponsor. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865 --- Comment #19 from ycollet --- OK, thanks a lot for your review. I will now try to find a sponsor. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865 --- Comment #18 from Vasiliy Glazov --- Now you need to get sponsored. https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Get_Sponsored -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865
Vasiliy Glazov changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #17 from Vasiliy Glazov ---
Approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Artistic License (v2.0)", "*No
copyright* Public domain", "BSD 3-clause "New" or "Revised" License".
15 files have unknown license. Detailed output of licensecheck in
/home/vascom/1840865-lv2lint/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[!]: Sources can be downloaded from URI in Source: tag
Note: Could not download Source0:
https://gitlab.com/drobilla/lv2lint/-/archive/0.2.0/lv2lint-0.2.0.tar.gz
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/SourceURL/
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865 --- Comment #16 from ycollet --- Yes, you're right, c++ was not required. I cleaned up the spec file. The URL to the last version of the spec file: https://download.copr.fedorainfracloud.org/results/ycollet/linuxmao/fedora-32-x86_64/01415006-lv2lint/lv2lint.spec The URL to the last src rpm file: https://download.copr.fedorainfracloud.org/results/ycollet/linuxmao/fedora-32-x86_64/01415006-lv2lint/lv2lint-0.2.0-4.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865
--- Comment #15 from Vasiliy Glazov ---
It is really need gcc-c++ to build? I don't see it in build.log
If not then remove it from BuildRequires.
Source0:
https://gitlab.com/drobilla/lv2lint/-/archive/%{version}/lv2lint-%{version}.tar.gz
can be changed to
Source0: %{url}/-/archive/%{version}/lv2lint-%{version}.tar.gz
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865 Vasiliy Glazov changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865 Vasiliy Glazov changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865 --- Comment #14 from ycollet --- I was waiting for the build to finish on COPR. The link to the lv2lint spec file on the COPR repo: https://download.copr.fedorainfracloud.org/results/ycollet/linuxmao/fedora-32-x86_64/01414998-lv2lint/lv2lint.spec The link to the corresponding src rpm package: https://download.copr.fedorainfracloud.org/results/ycollet/linuxmao/fedora-32-x86_64/01414998-lv2lint/lv2lint-0.2.0-4.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865 --- Comment #13 from Vasiliy Glazov --- Now post new URLs. It needed to make review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865 --- Comment #12 from ycollet --- Ah, sorry. I thought you where talking about the %buildroot in the build and install section. I commit a change ASAP. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865 --- Comment #11 from Vasiliy Glazov --- Just use Spec URL: ... SRPM URL: ... As in first message. And you still not removed BuildRoot string from spec! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865 --- Comment #10 from ycollet --- The link to the lv2lint spec file on the COPR repo: https://download.copr.fedorainfracloud.org/results/ycollet/linuxmao/fedora-32-x86_64/01414984-lv2lint/lv2lint.spec The link to the corresponding src rpm package: https://download.copr.fedorainfracloud.org/results/ycollet/linuxmao/fedora-32-x86_64/01414984-lv2lint/lv2lint-0.2.0-4.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865 --- Comment #9 from Vasiliy Glazov --- Now please post direct links to updated Spec URL: and SRPM URL: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865
--- Comment #8 from ycollet ---
OK, Thanks.
I updated the build / install part. I removed %{set_build_flags} and used
%meson %meson_build and %meson_install.
I replaced the license by Artistic 2.0 and I fixed the %file part by using
%{name}.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865
--- Comment #7 from Vasiliy Glazov ---
8. Don't use glob * in %files section such way.
Change paths to something like
%{_bindir}/{name}*
%{_mandir}/man1/%{name}.1*
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865 --- Comment #6 from Vasiliy Glazov --- 7. Change License: field to Artistic 2.0 Here you can find all allowed licenses and how they must be writed in License: field https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865
--- Comment #5 from Vasiliy Glazov ---
No need patches here put it near your spec file. If you added patch then need
%autosetup -p1
URL should be this
https://raw.githubusercontent.com/ycollet/fedora-spec/master/lv2lint/lv2lint.spec
You still not removed BuildRoot.
6. Instead of
VERBOSE=1 meson --buildtype release --prefix=/usr build
you should use macro
%meson
%meson_build
Then %{set_build_flags} not needed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865 --- Comment #4 from ycollet --- I just fixed the spec file. I added a patch because of a duplicated symbol problem on Fedora 32. I don't understand the point 5 ? In the Review request, I must add the spec file and not give an URL to the spec file ? In the review request template, an URL is indicated in the spec field. I use rpmlint on the spec file and 0 error / 0 warnings are reported. Thanks for the %autosetup, and for the %set_build_flags too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865 --- Comment #3 from ycollet --- Created attachment 1692809 --> https://bugzilla.redhat.com/attachment.cgi?id=1692809=edit A requested patch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865 --- Comment #2 from ycollet --- Created attachment 1692808 --> https://bugzilla.redhat.com/attachment.cgi?id=1692808=edit The spec file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1840865] Review Request: lv2lint - LV2 turtle language checker
https://bugzilla.redhat.com/show_bug.cgi?id=1840865
Vasiliy Glazov changed:
What|Removed |Added
CC||vasc...@gmail.com
Doc Type|--- |If docs needed, set a value
--- Comment #1 from Vasiliy Glazov ---
1. Remove
%global debug_package %{nil}
2. Add
%{set_build_flags}
at begin of %build section.
3. Change
%setup -qn lv2lint-%{version}
to
%autosetup
4. Remove BuildRoot string.
5. Spec URL must be to raw text.
It is not all mistakes.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
