[Bug 1843256] Review Request: abcMIDI - ABC/MIDI translation
https://bugzilla.redhat.com/show_bug.cgi?id=1843256 Stuart D Gathman changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2020-07-06 14:45:12 --- Comment #9 from Stuart D Gathman --- Since it did build for rawhide, I'll close this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1843256] Review Request: abcMIDI - ABC/MIDI translation
https://bugzilla.redhat.com/show_bug.cgi?id=1843256 --- Comment #8 from Stuart D Gathman --- DUP unretire https://pagure.io/releng/issue/9499 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1843256] Review Request: abcMIDI - ABC/MIDI translation
https://bugzilla.redhat.com/show_bug.cgi?id=1843256 --- Comment #7 from Stuart D Gathman --- https://pagure.io/releng/issue/9564 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1843256] Review Request: abcMIDI - ABC/MIDI translation
https://bugzilla.redhat.com/show_bug.cgi?id=1843256 --- Comment #6 from Stuart D Gathman --- Package is still blocked for all but rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1843256] Review Request: abcMIDI - ABC/MIDI translation
https://bugzilla.redhat.com/show_bug.cgi?id=1843256
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #5 from Robert-André Mauchin ---
- BuildRoot: is not used in Fedora
Package approved, please fix this remaining issue before import.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://src.fedoraproject.org/rpms/abcMIDI
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Naming/#_conflicting_package_names
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "GPL (v2 or later)", "Expat License",
"GNU General Public License", "GNU Lesser General Public License",
"GNU General Public License (v2 or later)". 68 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/abcMIDI/review-abcMIDI/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 624640 bytes in 17 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[!]: Buildroot is not present
Note: Buildroot: present but not needed
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]:
[Bug 1843256] Review Request: abcMIDI - ABC/MIDI translation
https://bugzilla.redhat.com/show_bug.cgi?id=1843256 --- Comment #4 from Stuart D Gathman --- Spec URL: https://gathman.org/linux/SPECS/abcMIDI.spec SRPM URL: https://gathman.org/linux/f33/src/abcMIDI-2020.06.29-1.fc33.src.rpm New upstream release. Includes my patches, so they are removed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1843256] Review Request: abcMIDI - ABC/MIDI translation
https://bugzilla.redhat.com/show_bug.cgi?id=1843256
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #3 from Robert-André Mauchin ---
- Group:, BuildRoot: are not used in Fedora
- Add a comment above the patch explaining why it is needed.
-Don't:
rm -rf %{buildroot}
- %defattr(-,root,root,-) is the default, therefore not needed.
- -Ask upstream for a License file-, strike that the license is provided in
doc/gpl.txt
- The Source should be the official archive. Any modification must happen
within the SPEC: this could be patches, but could also be a script that you
join as SourceX that is used to modify the official archive.
Another issue I have with your repo is that you joined the LICENSE file
yourself, this is contrary to the Packaging guidelines which states that the
License file must be provided by upstream and that the packager can't add it
themselves.
Another issue is the maintainability of the package, if you link to your repo
and you fail to update it after a while, we would maybe miss new releases.
- Bump to 0.6.25
- Use install -p to keep timestamps
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1843256] Review Request: abcMIDI - ABC/MIDI translation
https://bugzilla.redhat.com/show_bug.cgi?id=1843256 --- Comment #2 from Stuart D Gathman --- Spec URL: https://gathman.org/linux/SPECS/abcMIDI.spec SRPM URL: https://gathman.org/linux/f33/src/abcMIDI-2020.05.06-2.fc33.src.rpm Added patches to build on rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 1843256] Review Request: abcMIDI - ABC/MIDI translation
https://bugzilla.redhat.com/show_bug.cgi?id=1843256 Stuart D Gathman changed: What|Removed |Added Doc Type|--- |If docs needed, set a value --- Comment #1 from Stuart D Gathman --- Also, upstream has no SCM, and posts new latest every few months. I have been tracking changes in a mirror repo: https://github.com/sdgathman/abcmidi Should I continue to pull the zip file from upstream? Or from my mirror (which includes LICENSE, etc)? I've already gotten an opinion to continue with upstream format, but maybe there is a counter argument. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
