https://bugzilla.redhat.com/show_bug.cgi?id=1853172
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |POST
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review+
--- Comment #2 from Robert-André Mauchin ---
Package approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Expat License". 7 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/ghc-js-flot/review-ghc-js-
flot/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/doc/ghc(ghc-
EdisonAPI-doc, ghc-Agda-doc, ghc-uri-encode-doc, ghc-HsYAML-doc, ghc-
EdisonCore-doc, ghc-filepattern-doc, ghc-parsers-doc, ghc-geniplate-
mirror-doc, ghc-lukko-doc, ghc-dns-doc, ghc-bitarray-doc, ghc-
serialise-doc, ghc-compiler, ghc-js-jquery-doc, ghc-aeson-better-
errors-doc, ghc-murmur-hash-doc, ghc-cborg-json-doc, ghc-http2-doc,
ghc-time-manager-doc, ghc-cborg-doc), /usr/share/doc/ghc/html(ghc-
EdisonAPI-doc, ghc-Agda-doc, ghc-uri-encode-doc, ghc-HsYAML-doc, ghc-
EdisonCore-doc, ghc-filepattern-doc, ghc-parsers-doc, ghc-geniplate-
mirror-doc, ghc-lukko-doc, ghc-dns-doc, ghc-bitarray-doc, ghc-
serialise-doc, ghc-compiler, ghc-js-jquery-doc, ghc-aeson-better-
errors-doc, ghc-murmur-hash-doc, ghc-cborg-json-doc, ghc-http2-doc,
ghc-time-manager-doc, ghc-cborg-doc),
/usr/share/doc/ghc/html/libraries(ghc-EdisonAPI-doc, ghc-Agda-doc,
ghc-uri-encode-doc, ghc-HsYAML-doc, ghc-EdisonCore-doc, ghc-
filepattern-doc, ghc-parsers-doc, ghc-geniplate-mirror-doc, ghc-lukko-
doc, ghc-dns-doc, ghc-bitarray-doc, ghc-serialise-doc, ghc-compiler,
ghc-js-jquery-doc, ghc-aeson-better-errors-doc, ghc-murmur-hash-doc,
ghc-cborg-json-doc, ghc-http2-doc, ghc-time-manager-doc, ghc-cborg-
doc), /usr/share/doc/ghc/html/libraries/js-flot-0.8.3(ghc-js-flot-
doc), /usr/share/doc/ghc/html/libraries/js-flot-0.8.3/src(ghc-js-flot-
doc)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages
