[Bug 1853622] Review Request: perl-Test-RandomResult - Test that results of a running code look random

2020-07-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1853622



--- Comment #4 from Jitka Plesnikova  ---
Thank you for the review and the repository.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1853622] Review Request: perl-Test-RandomResult - Test that results of a running code look random

2020-07-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1853622

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Test-RandomResult-0.00
   ||1-1.fc33
 Resolution|--- |RAWHIDE
Last Closed||2020-07-07 07:01:19




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1853622] Review Request: perl-Test-RandomResult - Test that results of a running code look random

2020-07-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1853622



--- Comment #3 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-Test-RandomResult


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1853622] Review Request: perl-Test-RandomResult - Test that results of a running code look random

2020-07-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1853622



--- Comment #2 from Jitka Plesnikova  ---
https://pagure.io/releng/fedora-scm-requests/issue/26811


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1853622] Review Request: perl-Test-RandomResult - Test that results of a running code look random

2020-07-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1853622

Petr Pisar  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Petr Pisar  ---
URL and Source0 addresses are Ok.
Source0 archive (SHA-256:
06d948be8fbb4ed8854e70fc79cd50b9b3fb161e3feb6e3967c341ba572c1eae) is original.
Ok.
Summary verified from lib/Test/RandomResult.pm. Ok.

FIX: Add a full stop to the description text.

License verified from README, LICENSE, Makefile.PL, and
lib/Test/RandomResult.pm. Ok.
No XS code, noarch BuildArch is Ok.
Pod::Coverage::TrustPod, Test::Pod::Coverage, Test::Perl::Critic, and Test::Pod
are not used. Ok.

TODO: Unset AUTHOR_TESTING variable from the environment in a %check section
before executing "make test".

All tests pass. Ok.

$ rpmlint perl-Test-RandomResult.spec
../SRPMS/perl-Test-RandomResult-0.001-1.fc33.src.rpm
../RPMS/noarch/perl-Test-RandomResult-0.001-1.fc33.noarch.rpm 
sh: /usr/bin/python2: No such file or directory
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Test-RandomResult-0.001-1.fc33.noarch.rpm 
drwxr-xr-x2 root root0 Jul  3 14:09
/usr/share/doc/perl-Test-RandomResult
-rw-r--r--1 root root   71 Jul 17  2019
/usr/share/doc/perl-Test-RandomResult/Changes
-rw-r--r--1 root root 2239 Jul 17  2019
/usr/share/doc/perl-Test-RandomResult/README
drwxr-xr-x2 root root0 Jul  3 14:09
/usr/share/licenses/perl-Test-RandomResult
-rw-r--r--1 root root18367 Jul 17  2019
/usr/share/licenses/perl-Test-RandomResult/LICENSE
-rw-r--r--1 root root 2187 Jul  3 14:09
/usr/share/man/man3/Test::RandomResult.3pm.gz
drwxr-xr-x2 root root0 Jul  3 14:09
/usr/share/perl5/vendor_perl/Test
-rw-r--r--1 root root 5051 Jul 17  2019
/usr/share/perl5/vendor_perl/Test/RandomResult.pm
File layout ans permissions are Ok.

$ rpm -q --requires -p
../RPMS/noarch/perl-Test-RandomResult-0.001-1.fc33.noarch.rpm | sort -f | uniq
-c
  1 perl(:MODULE_COMPAT_5.32.0)
  1 perl(Exporter)
  1 perl(strict)
  1 perl(Test2::API)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsZstd) <= 5.4.18-1
TODO: Constrain 'perl(Exporter)' with >= 5.57.

$ rpm -q --provides -p
../RPMS/noarch/perl-Test-RandomResult-0.001-1.fc33.noarch.rpm | sort -f | uniq
-c
  1 perl(Test::RandomResult) = 0.001
  1 perl-Test-RandomResult = 0.001-1.fc33
Binary provides are Ok.

$ resolvedeps f33-build
../RPMS/noarch/perl-Test-RandomResult-0.001-1.fc33.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in Fedora 33
(https://koji.fedoraproject.org/koji/taskinfo?taskID=46511820). Ok.
Otherwise the package is in line with Fedora and Perl packagaging guidelines.

Please correct the 'FIX' item, and consider fixing 'TODO' items before building
this package.
Resolution: Package APPROVED.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1853622] Review Request: perl-Test-RandomResult - Test that results of a running code look random

2020-07-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1853622

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com
   Assignee|nob...@fedoraproject.org|ppi...@redhat.com
  Flags||fedora-review?




-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org


[Bug 1853622] Review Request: perl-Test-RandomResult - Test that results of a running code look random

2020-07-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1853622

Jitka Plesnikova  changed:

   What|Removed |Added

 Blocks||1853629





Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1853629
[Bug 1853629] Review Request: perl-Color-RGB-Util - Utilities related to RGB
colors
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org